Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d7c3ce9f-d144-0083-162b-448570f2b5e5@suse.com>
Date:   Tue, 28 Jun 2022 13:26:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] drivers/net/usb/r8152: Enable MAC address passthru
 support
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>,
        Franklin Lin <franklin_lin@wistron.corp-partner.google.com>
Cc:     edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, davem@davemloft.net,
        franklin_lin@wistron.com
References: <20220628015325.1204234-1-franklin_lin@wistron.corp-partner.google.com>
 <YrrVT33IZ1hMkhw2@lunn.ch>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <YrrVT33IZ1hMkhw2@lunn.ch>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnlpdFErNHZzNU9URzFOdThjb3RzLzRiMmttREJvMC9HZjl3bDFOMHg4V1lQ?=
 =?utf-8?B?MG9MVXJ2aUJXSXBNRHNBc2V4aU9OdGNIQkZ2bFkwUkhoc0ZjZkZYdnFVclJX?=
 =?utf-8?B?ejBQSXZiajEvQjZKbU1wRmZGRzdsb0xWRnowaktrYVgvVG4vd3phbkFEWjRV?=
 =?utf-8?B?OXBtUTQweFczQVZza2UrOCsydS9lSjB0OGtTeWdDUnB6cHdtc1NwcWFJU3RW?=
 =?utf-8?B?WVBlNGtkNys2RFhqRVprcjNYck4wUkpRRDJ0RDhQZWtHdnp3Ti9mRWl0N2R3?=
 =?utf-8?B?eUUyZE9ZTXZ2cWNsWUphVWx3VDlJWWJVdzJTVW8zK1djQnJ1bGdMbm92Rmhz?=
 =?utf-8?B?YTYwS0tpNEUwZGl6ZjhPb05XVUFMbFFmWnF5Qk9WNHgyWWNVSmx0ckkvTUQ2?=
 =?utf-8?B?R1dlVjhpZGYxUitvU2hnNEJLMUJnbFRQK1VkYUpSWDJoUW5PcnJpUGdyd1kr?=
 =?utf-8?B?UmVpUUZBSk9lKytXK01GLzZtQ3ZvMGZUalFYVDRsRlVBaUVaZS80WkIxS01l?=
 =?utf-8?B?bThXTzhIS2F5MjdtYVZ4Sy95S1RlSExBaG5TUzJwY0tzc2xKQzBTWUtoeitT?=
 =?utf-8?B?Z2xoNVlkRERteXVpcWZOWHA0U1RLT2VKZlQ1UEtaVmhCMmVob0xJREhkblVV?=
 =?utf-8?B?NzNwNENWOXpNVFpRTXlSOEZzb2N3Qm52aHBPdnlVeDVFTlR0V3ZKRG1kNmcw?=
 =?utf-8?B?UmpjSDc3WTFQOHhWbDZUbjRnNXVxK2I4SlcxYU9IZVNuNExjLzBtZjBHRXV0?=
 =?utf-8?B?V3VVYzBabXpBTHg4azhHcWN5Skd5bUVhUW5XWEhicHFYQ1dLdTFIYXZhWnB1?=
 =?utf-8?B?VUEzMmtmeUhiTEtiZlA1UDBXR1ArZ0xrL3REN3QzRXdYTFhpRjJ5MFFLRnJa?=
 =?utf-8?B?Y00xMlVnRGNjUHhFTGMrRGgyRWVzcjREellNbkt1bkovd2JEMHJqQ1l5T25x?=
 =?utf-8?B?cEd0MitCa2liemtKVC9temRzRG1rZUY1SW5lSHZCUTFFem1jQ1JXeERrUkht?=
 =?utf-8?B?aG51WUNvUnZHa002dllJYVZrRlRlZmg5TS9XWDZpdEFsdjBWUXVKY0xhNDE1?=
 =?utf-8?B?TXZjL0QralpPUzlzVndobTlrVmtDbnhocWFJdmRJRUlJZ2lKOWVEYmwvVHRT?=
 =?utf-8?B?YkZUZGd6bGhPb05TWjFaVFJ2ak5uVXFRVUxjVmMwOXkwdk9oT24xdXYrMS8z?=
 =?utf-8?B?cUxyV1NWbGk5cUlIaG5DeDJDY001OC9MZ0kwVElIQTZFLzljWEJZcGdkczRE?=
 =?utf-8?B?Y3lFTS9uenoxbHJvK2dWM2NpUTF0Z1U3VzRWU1dyNlBaY3MwV2tWQjNuSlE5?=
 =?utf-8?B?VFFSdDJ6VHh4ZnJYY3JFU2Q4RDRoT0V5STBudG0yaXVXZklqcm8ra0wvOHk5?=
 =?utf-8?B?TkxjNElqdEhtalBYaExrckVtc0tucXRvZUpzQjVMUHpZbjMzVU1KdzJwQll2?=
 =?utf-8?B?OHRiLzN0b2ZaTW15R3pGM0RLcXVxdXdKdjVuSHJ2R3NESnoyQzFTaTVEYkpm?=
 =?utf-8?B?YlVyTkJNSHNEeGo0cUFXQUpJak1NY292dDNKRVJYczdwWTNNc1RtNUlBdHJP?=
 =?utf-8?B?NkFFQ0RTQU55OElxNkg4NlN0TzBWOWlwc2MvZDllMzQzVUFzMjhzN1c2Smcw?=
 =?utf-8?B?bHUrZ1hQK3ZGSEZrMjNuSVNWNzFYUVhMM1lwNmZHNll3VHFOYlViMnU0T3F0?=
 =?utf-8?B?bDVUM05PR3ZCRDhycXdZcCtSbmdSd0h4OWp2aWg1dUs1YjFXN0FjNkRydjdr?=
 =?utf-8?B?aXdvYWRSWVBDRWhMdnVyL3g5UEdPVUl0YUVkL1FySVAwNXlSVXk4dWQrR2xv?=
 =?utf-8?B?L1dOU2hhT212M2VHT1NmUXpLSlJZOWd6cXR5dVJLNjlTVXkvWGpMc0pKd0VR?=
 =?utf-8?B?T3dZbUVJUFlDRDBlRTNCZFdxclZWZjNpK0lYR3NaZE5TSUJOZnQ3eFJxbVd4?=
 =?utf-8?B?RlZacldVbzdHOHl2TExGbm5kMWJJWmE2bGlRYS9tVDcvVC9aWnByZnZCRDUy?=
 =?utf-8?B?MzlhaTJmTVhteGxId044dkswYUdhR0hMUXE3a2twYzYzMEdFRG9LM3JXeTZo?=
 =?utf-8?B?UGJYNEorTGZBTkRpMUtpZVdWT0tZNnBMcmFvbDVqaE5qWWlQWnlSZGRES0Vh?=
 =?utf-8?B?N3lhOE9oWUw4NXl2MDc4VGo4VXdBU2d4eFBucWdPT2xXTmF3c2t0dnhMR2gw?=
 =?utf-8?Q?V4Vbv+ggQ74ZF97gGUrFvJ1ZfiXzzDxmVPQtvmpXKXSX?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bd165b6-958d-472e-cb31-08da58f9138b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2526.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 11:26:42.5938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DYdQhjEr4DgS6520kkKgVcm0e/11+sRPXx8pHwq36Ux7a7Edo9132ETbWS05siHC80V1Bixn2xgDt0XcYIzF6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2753
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 28.06.22 12:17, Andrew Lunn wrote:
> On Tue, Jun 28, 2022 at 09:53:25AM +0800, Franklin Lin wrote:
>> From: franklin_lin <franklin_lin@wistron.corp-partner.google.com>
>>
>> Enable the support for providing a MAC address
>> for a dock to use based on the VPD values set in the platform.
> 
> Maybe i'm missing it, but i don't see any code which verifies this
> r8152 is actually in the dock, and not a USB ethernet dongle plugged
> into some port of either the laptop or the dock itself.

And it will happily assign the same MAC to multiple devices.
I am afraid this patch needs some basic redesign.

	Regards
		Oliver