Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3918457iog; Tue, 28 Jun 2022 05:36:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sDOk/EoRl/ZUI4dGEIofqUCWcFsgs95OBzExOCGDYJ0dXSGwhggHpSDe2k/QQoyFlprR/s X-Received: by 2002:a17:907:c14:b0:726:9118:3326 with SMTP id ga20-20020a1709070c1400b0072691183326mr15390764ejc.68.1656419772468; Tue, 28 Jun 2022 05:36:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656419772; cv=none; d=google.com; s=arc-20160816; b=skxvAdCJsF1OVRf5d+bBOauZKQIxfTS6LfmCpCgeoFpT5pzQSyhWjb4ekC6sPy4BpS 5kxD8H5xaAHSZiB/O9sw1FDUmBTvmR001pOyI9t+hZo3vIRikGBJmSoz/Tn+5PvbD4Io WlNk1VAGf7nfqRjXOTpfDeadUdJLX2Dql3DgNB59WCyQSvvPxZpat3P1GNCoDpyjkD6N Ic5wuFwi55DQa4jWewwJk08rjtYU/X2S6VPeycUEzVlYk3n17QWC2uZnHxqqJ9CIrC0n sdO0YQ0VVP2D4t0lF8Swl43W0v7HRTZSZAlBJdR6yYBa1yGSBGUJOcPF1VDPmbRzcCUE rxNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=meEj07WgP17kCAxmyWFmfPo3EWzRrucLVHloJVwVfzI=; b=l7MdBr4FHHwp9bdhgJuhQb2RsRfV6vpw9UCcAQAnhfPDJQhTIKcrTVkErhQCHI5AtK Yn+ptn9mL/6ghf5W0BV9i/qqNfq8Hea8iZjt5f2v600m8r/A9aJh7cGM69zlFaaaDlr+ t6k6WnXZ4EQrXuCDQ4t7sjvgVYC3bk9mxPRov65cKbgVnCVRE5GPoTpeCUgnGrPIX+ZV 08j3yiQhI0TFEi5iecpW4ZcSihCx8TvVo/uHhjxBkwUn2XfX/3Hh1JJyyzWZHSk/YhK/ VD3Z2TluiH2NFvz0sZa+d4FVmLfi1XeQpqx05Z5TLzo4McG2nMwaAL+0qaYIlmsE3GKj icLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=nUXN4NQb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bq16-20020a170906d0d000b00708423d4250si671372ejb.228.2022.06.28.05.35.47; Tue, 28 Jun 2022 05:36:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=nUXN4NQb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344908AbiF1L5L (ORCPT + 99 others); Tue, 28 Jun 2022 07:57:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344876AbiF1L5J (ORCPT ); Tue, 28 Jun 2022 07:57:09 -0400 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B76783135A; Tue, 28 Jun 2022 04:57:07 -0700 (PDT) Received: by mail-yb1-xb2f.google.com with SMTP id i15so21873948ybp.1; Tue, 28 Jun 2022 04:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=meEj07WgP17kCAxmyWFmfPo3EWzRrucLVHloJVwVfzI=; b=nUXN4NQbgs8R07Q3F9idMurCvTBqS180V7LUFPW9xG/4GbJsC5G9GMRYWxDvS8vHVU uvCdtyI8qAdQ7AhHruDB2L5qNXFrbtfVALrttTGovR2SgBuwdTrwSuYQV74CjQZQgmvj HYcyVjkdsYwLaFwO/+1xuqvqjXbzZxRsk5BBAis/bjPxVCPAtt1jJj2humxgQMfU7Bc6 RCPw+sSoyWikaySEZeRhEcIgtWERGhzHi/IdeEjZfMln1Pt1OEqH9gYt7ZI+8vmUjdIU TPb2nvchPVSlB98dyYZaLbunSzSi3Sbx6IlBQ3Qr2V/AmBxO63kGjzEVaml8n/GlNDYj HRTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=meEj07WgP17kCAxmyWFmfPo3EWzRrucLVHloJVwVfzI=; b=jBZPTnOJeVAOlBsmnAwYScn9Vt30nryh6o8Ssu2AIevnWkCiKk+IF5wTec5ezpHaj6 2FJRauyvfdPqLhdCw5C42o0a3DhAthkp+pyXmQMcx+7xsr8ZY/e2BlHpc+o2GgPDwaU5 zci43d+WTHoGmC5js2TffevvtROXstn5qoJcOZXIyTADholk9rBeOZk22DVSHAJZaKCz RVTx4JKLOEZRm4P2Sre/WVqZuSiZe2GNQSp0lCctTnjpAGuVsemLtWEMYfk9EfngijuX sxhe2gjOHoXJDxoTT1+HP7s0/T7J4iyR8MsIBB/40hPOxMOMwZbSBkLRgxJoi8cuHYCX kzfg== X-Gm-Message-State: AJIora/NIfvlL/Pi1BnFxyEJ1MLTuapvE0c/aDLTCR1FTDC2h+aMiXjb ePhnQ5vttoSqt+nzmE0FuW/pJ4dlZzJYekRbpvw= X-Received: by 2002:a25:b2a8:0:b0:66c:8110:3331 with SMTP id k40-20020a25b2a8000000b0066c81103331mr19815871ybj.460.1656417426922; Tue, 28 Jun 2022 04:57:06 -0700 (PDT) MIME-Version: 1.0 References: <20220623170844.2189814-1-marcus.folkesson@gmail.com> <20220623170844.2189814-6-marcus.folkesson@gmail.com> In-Reply-To: From: Andy Shevchenko Date: Tue, 28 Jun 2022 13:56:30 +0200 Message-ID: Subject: Re: [PATCH 06/10] iio: adc: mcp3911: add support for oversampling ratio To: Marcus Folkesson Cc: Kent Gustavsson , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , linux-iio , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2022 at 2:07 PM Marcus Folkesson wrote: > On Thu, Jun 23, 2022 at 09:20:01PM +0200, Andy Shevchenko wrote: > > On Thu, Jun 23, 2022 at 9:08 PM Marcus Folkesson > > wrote: ... > > > +static const int mcp3911_osr_table[] = {32, 64, 128, 256, 512, 1024, 2048, 4096}; > > > > Spaces inside {}. > > Not sure what you mean? int foo = { 1, 2, 3 }; ... > > > + ret = mcp3911_update(adc, MCP3911_REG_CONFIG, > > > + MCP3911_CONFIG_OSR, > > > + val, 2); > > > > sizeof() ? > > sizeof() what? sizeof(val) ? -- With Best Regards, Andy Shevchenko