Received: by 2002:a05:6512:e85:0:0:0:0 with SMTP id bi5csp3083903lfb; Tue, 28 Jun 2022 06:07:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u6+YGlA0WUSui2WU4F0pFbuRLY6qPkxKcwt0cnpgHeX1mlF0HGkIw1eruRwGOMvO3nCE0T X-Received: by 2002:a05:6a00:1892:b0:527:c203:7708 with SMTP id x18-20020a056a00189200b00527c2037708mr4635138pfh.26.1656421666430; Tue, 28 Jun 2022 06:07:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656421666; cv=none; d=google.com; s=arc-20160816; b=TYekGU9Vr+P2iJyS+MPoEtotgq2R6V8NoE8jPgvPaboWk2kNqDsOKvfYY1NYA9lYYt z1qyhoqpW9a8iLwKuaPlJpW8NLVsxvLOoL2ydEGra/cZQOgw4z53KBrQY7pd4R0laZUD esAbcPvhWJGftZUtAPDFFSCatEwqbvriH3jh4usa//+MpXn8Co2Ovb3UwLjJgVXzCbTA SAbsUnYf5PvhJbCibNsXZ9s8OyJUDhF45Kg0iSsn9qetwL+ccZjFbUZzdTP0/LSdQ0h8 kT67ahWZQgf2Pp0LJD9nzq3jxQlOE6eLeqN+wCJkvdgu/cJhPflMgvLwC/B5XiR+u3q0 Mc3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:mime-version:date :dkim-signature:message-id; bh=mqAG6NtuPeXXT/iyoPFvKD2DWm9Jh7e8oexC24YjANo=; b=g9m01Bh7wmMqFY/zLOsTevvi6ZLEXE2kunKDfg4RL6RC1OR7Ow2HYbq1YnecNgtlrR 2USVR98DAPe1SGM3aI0/5YLh0K/pDv1jESQ8txSAhGbqHzZrA/oYWhsqDBPalfJoAXJe mkLKMZq0jlXy8D84rwWB6zjuzq5ZpsJ40h/S2lM8ZhxggcAHDEseU8c1zisFK8DDYPHu NL3Wi9HvM2k8bVRPH64cqficfYWha+vBsVudXCkMUhB/N3PRwYHWsoPtCVdnFqSUp0N7 KB/uUsANIdb9EVLMNIJHkRjd/HESOoHvJc45WMdlzwkMHqnee9IXuITojXHHsddoS9s7 s4Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=JppEkjCy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y10-20020a17090a600a00b001e86a88ccbesi18524469pji.81.2022.06.28.06.07.27; Tue, 28 Jun 2022 06:07:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=JppEkjCy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345989AbiF1Mzk (ORCPT + 99 others); Tue, 28 Jun 2022 08:55:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345995AbiF1Mze (ORCPT ); Tue, 28 Jun 2022 08:55:34 -0400 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 345DE2F39A for ; Tue, 28 Jun 2022 05:55:33 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1656420931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mqAG6NtuPeXXT/iyoPFvKD2DWm9Jh7e8oexC24YjANo=; b=JppEkjCyCOm7jL3qbB/qIlKo/Ny7szXdrp5BiRkHoo7g9tt/HVC3/+2Ua/h1/dEEMiDk5G GXWSHNvPaVj2lYes5quE+T4r5wIt/zUC4j4HUgMZ+zzK+ReON1jee0ET5c00Sn2te7xwSx iRZWGfNPsQKGuvAsmnFDzrfsOuGgrXg= Date: Tue, 28 Jun 2022 15:55:29 +0300 MIME-Version: 1.0 Subject: Re: [PATCH v3 1/1] Create debugfs file with virtio balloon usage information Content-Language: en-US To: Alexander Atanasov , "Michael S. Tsirkin" , David Hildenbrand , Jason Wang Cc: kernel@openvz.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20220627163714-mutt-send-email-mst@kernel.org> <20220628092324.23656-1-alexander.atanasov@virtuozzo.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vasily Averin In-Reply-To: <20220628092324.23656-1-alexander.atanasov@virtuozzo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/28/22 12:23, Alexander Atanasov wrote: > +static int virtio_balloon_debug_show(struct seq_file *f, void *offset) > +{ > + struct virtio_balloon *b = f->private; > + u32 num_pages; > + struct sysinfo i; > + > + si_meminfo(&i); > + > + seq_printf(f, "%-22s: %d\n", "page_size", 4096); This output of the constant looks strange for me. Could you please explain why this is required? Thank you, Vasily Averin