Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <84d30ead-7c8e-1f81-aa43-8a959e3ae7d0@amd.com>
Date:   Tue, 28 Jun 2022 20:20:20 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v6 00/17] Introducing AMD x2AVIC and hybrid-AVIC modes
Content-Language: en-US
To:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     pbonzini@redhat.com, mlevitsk@redhat.com, seanjc@google.com,
        joro@8bytes.org, jon.grimm@amd.com, wei.huang2@amd.com,
        terry.bowman@amd.com
References: <20220519102709.24125-1-suravee.suthikulpanit@amd.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <20220519102709.24125-1-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWdybWQ2UHdVYmRzSXF4YU9wOHRybWxjSmcycEVBcXpUTDZJeURJblZDeXVx?=
 =?utf-8?B?Qkl3cmhLSTBqNEo0Sm5VNGlPb0d1djFPT3VEWnVuTG9TUENCc2lCQlozNm1w?=
 =?utf-8?B?MGQ3a3lLYVVWeTFJSGRkajZYdW95bC9FZVBOMFRTN1l6U0hWUURvcGlRdFJt?=
 =?utf-8?B?WU1oaGJ5Z2hzQ1RITmJUemZmWnZtNW1iYzZzYXZoOFVNaDJRaU9FRTdIT2ZG?=
 =?utf-8?B?djdhTXlPWW8zcTBLNzNYZmZWZng1SWpRbERENWgyNTB1SGxuOGd6ajlYTUpH?=
 =?utf-8?B?OFg4STNlMzVUa0ZOTEdwcU05TFZUblhJbGY2Z1ZNM1hwNkU1N0ViNVczNXpn?=
 =?utf-8?B?RWZnbkQydUJrL25LdUtuZldwc1FvWlZIMmI4TTlNSUlxRTNGOFZ5SW4zUzRZ?=
 =?utf-8?B?VVQyOHdZbjU2alROdWdFY21BZ0pKSjgzM202VkthbTY3ZXdiWXJaeG1SeGdG?=
 =?utf-8?B?WE5RTzMwajU3bTQ4ajVEMFFqZWxJTGdIaUllbDlGZEY3eUFtTUdSNDBFVmRX?=
 =?utf-8?B?d2k4L2c4aFRzRm1PL2o2bmtOWmdCY1FwV1UrNnFyRHJJVVRwYmErZDlQWE9T?=
 =?utf-8?B?Rnpaa0U3REpaS0tBYkwzRExCUHFlSURQWjlGWDdyQVFZb3AzMFl1bks3Sm0z?=
 =?utf-8?B?cWZzelBMWjh2cExOWU1XWmI1T3VpWWlBY0NkL1BWMUhwbHRMNWtnUk9TRFFj?=
 =?utf-8?B?cFE0dnl4OGoxb2VLOTBhUSszQk85empoS09hNzFpZk9ZVkgzOU02SUNEVGs0?=
 =?utf-8?B?Z0xkT0N3RmtFYUozOVpyWmxYcE41MjNPaWMyNzJ0THhRY0luNWlDM1dLTGJX?=
 =?utf-8?B?d1drR0JlTzhmTTY1Si9TR2Rsdkl5K2ppZmNFdmNDVnVWMXVuRW45TkxjU0hp?=
 =?utf-8?B?YkN0a1dDRHp6eXdxaGc4VThRTjdabU16V0IrMll1NG5jeVBBM2N5dUlFUFpU?=
 =?utf-8?B?UGlHcXBVTW1lYkhvYjVoMDdqODh3M0VJYTlJdVNCbDh2eXIyYUVkbzdtOUpy?=
 =?utf-8?B?R0t1WkthQmdvZVFPdCsrVDBVUG9TT1Yyb2hla1B6VEt6NUw2aWZsZStZWWFH?=
 =?utf-8?B?YWRHOWJ5NlNCM2dEUFJpcDJId1Rqc080Yzd5Z1NIZGpWRlNmY0lrZWtmQW1X?=
 =?utf-8?B?RTRRM2o5T0N2N1lYeHdUbVNxNXl6RjF2R2w5cHRzdjlBd0hkbmgzNS9TQ3Bx?=
 =?utf-8?B?cmplZkozckJkNlJRUXBwejllMy91cnlyOVE3N3MzcG0zVzJ4cFpCSUNJaWh0?=
 =?utf-8?B?SVl1TmdVcGxOc1B2YU1NVFgxVDlSSmtUdHpXYWRuckJrbnlETEVlc3h0UFUv?=
 =?utf-8?B?ZWkvY3VoN3BJNGJ3WXllSmdyVVc2RER1TmNCbmt2QlRoMnpuaFRCTHdIR1pw?=
 =?utf-8?B?b3lhNW80MGVxcjFISElVT1hNYUQ2TTkvekxEOXhFWjJVby9hZndRRFBYZG9w?=
 =?utf-8?B?VUNCRml3UHlZOHg2QktLVW5sdjQxY283bUpkWVhzU00wQ1A3ck1QR1FUalBh?=
 =?utf-8?B?dSs2dXBNcVpIT3MrejUrS285S0pNcnJsZFFOVlRFUi9PNXBFVUZaNFV1SWU1?=
 =?utf-8?B?TVZTYkJBR21WdXg1OWVUSWxmNnZYU3ZwbUxQSmhhUVU3elE5ZUpkL21VRU0r?=
 =?utf-8?B?V0lIalcwd3lkMm8yeFp4MkVlQ0piU05oUW55clVpVjFzZWROd2xVWCtJZkU0?=
 =?utf-8?B?Y1JyTEExNUF6NXBZbzl2RmVKQmQ0blluRU1TVkM0MktaaXNpRVNJcDhRZDB5?=
 =?utf-8?B?VDBBeHJ2eldUTzB5eWtQZjRkdXRTYlIyRHhyK2pjUGt2VktnMUhKQlJnRmh6?=
 =?utf-8?B?c0pXTEhVbEJ1elQraHl5Rmx2Zzh4emlMVWhnTGlVaVQ4UWpNeDZnc3BwOE1y?=
 =?utf-8?B?d1gydjFOZ3liZ1VDME5sNFlYWXFBMWJzaS9CZXVYL2JFQ2hKMlRIRktKWHlx?=
 =?utf-8?B?NHVnUGpGci9adVMzV2ZIOFhKaHdoMjA4Wlo3TTBXeEx4TVlsd0lPWWpDMFVI?=
 =?utf-8?B?blRobllmVW91akdJU0tzUjZTK0MvSDkvUS9KMXVibDVLRm1WVXRlSXNUOVI4?=
 =?utf-8?B?U0pnV3dTY2tDclVoOS8vdDhXL2RtcmkrNXU2eEtnaFAyeVQ4ci9QSUpEZm9G?=
 =?utf-8?Q?ZXpvI969n8dJ/oa4xYLDPtmS5?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c69c80b9-d3d8-47d6-c73c-08da5908f8f4
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 13:20:30.0872
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pkeNE4g9wTogTKr14JJqrgODlxDempvRO0ho3qHyOGpCR58NM98hnqufMALboOgMNiRmhttu+kKhjFiT78pgtw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5554
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Maxim,

On 5/19/2022 5:26 PM, Suravee Suthikulpanit wrote:
> Introducing support for AMD x2APIC virtualization. This feature is
> indicated by the CPUID Fn8000_000A EDX[14], and it can be activated
> by setting bit 31 (enable AVIC) and bit 30 (x2APIC mode) of VMCB
> offset 60h.
> 
> With x2AVIC support, the guest local APIC can be fully virtualized in
> both xAPIC and x2APIC modes, and the mode can be changed during runtime.
> For example, when AVIC is enabled, the hypervisor set VMCB bit 31
> to activate AVIC for each vCPU. Then, it keeps track of each vCPU's
> APIC mode, and updates VMCB bit 30 to enable/disable x2APIC
> virtualization mode accordingly.
> 
> Besides setting bit VMCB bit 30 and 31, for x2AVIC, kvm_amd driver needs
> to disable interception for the x2APIC MSR range to allow AVIC hardware
> to virtualize register accesses.
> 
> This series also introduce a partial APIC virtualization (hybrid-AVIC)
> mode, where APIC register accesses are trapped (i.e. not virtualized
> by hardware), but leverage AVIC doorbell for interrupt injection.
> This eliminates need to disable x2APIC in the guest on system without
> x2AVIC support. (Note: suggested by Maxim)
> 
> Testing for v5:
>    * Test partial AVIC mode by launching a VM with x2APIC mode
>    * Tested booting a Linux VM with x2APIC physical and logical modes upto 512 vCPUs.
>    * Test the following nested SVM test use cases:
> 
>               L0     |    L1   |   L2
>         ----------------------------------
>                 AVIC |    APIC |    APIC
>                 AVIC |    APIC |  x2APIC
>          hybrid-AVIC |  x2APIC |    APIC
>          hybrid-AVIC |  x2APIC |  x2APIC
>               x2AVIC |    APIC |    APIC
>               x2AVIC |    APIC |  x2APIC
>               x2AVIC |  x2APIC |    APIC
>               x2AVIC |  x2APIC |  x2APIC

With the commit 3743c2f02517 ("KVM: x86: inhibit APICv/AVIC on changes to APIC ID or APIC base"),
APICV/AVIC is now inhibit when the guest kernel boots w/ option "nox2apic" or "x2apic_phys"
due to APICV_INHIBIT_REASON_APIC_ID_MODIFIED.

These cases used to work. In theory, we should be able to allow AVIC works in this case.
Is there a way to modify logic in kvm_lapic_xapic_id_updated() to allow these use cases
to work w/ APICv/AVIC?

Best Regards,
Suravee