Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp4014779iog; Tue, 28 Jun 2022 07:23:38 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u0glbcM25dNcyhDe1lSO7rmPTL/Z5gKXMoQ8U0n9eU+xqff5c16UZ2AN1iPFp7roPTygMT X-Received: by 2002:a17:902:ebc1:b0:168:fd13:8adc with SMTP id p1-20020a170902ebc100b00168fd138adcmr3976764plg.161.1656426218665; Tue, 28 Jun 2022 07:23:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656426218; cv=none; d=google.com; s=arc-20160816; b=wQTtlS3eDo6fIawoQqSi8HtDhPU+a+39tyC4+2dohK7zZI8E9sgjA3DB6hbMlJIP1q CNvOVNV1HQs4vOI0zdOe8l9bvOFyeSVR4G1Qbc490fYeW+nznB/oJJvoxTHWoLZ5Wzmg 1o3hd0V3DW68RYrDjT9tq4moSh7X4blHXCUD5R9EUiWuAmics8u9i01DYJttLz9Byci8 8qTUyI7ExOI4ol2L5zV0FCz5ZXC2AHtObDRR9V2e6YrSZQevdPtbm9Hu1EBG8+ObHBdd SRut2Amzioh7ZGfdTupII78ZzPUjOu55zv+guw7MnP280Ff2gEbD9TSH64cHL5q+qm6y WiPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=AZ1tY/fbYnbotdriO5S1rk84v9dQ1fc1bIXXi25ViSs=; b=jX3Mt3gpmdj/wd24FbaxOAMvbaGQKKFoBIXxrhfNxFrLFGaOaw8JC6bkpUdMbHzjiO r5YqEqfiGAQcw+boAx10mRGQnoZKAYaKnf6IqHysb4Pb8eo2c/Ipg4jybiKOFxQGlJSL xV4xL95+onRgcmMeBnd/fvKn04MG5Nqjxk8qYN4T8zYJCD6HAdt7DHlRn3XsxxsjXQOa XLl+VzWXK64+s4fN5Iirl2KrJG5MM/711UVGxfcuIrHFHEXuclT2zIRYw3NQZavxewrr LsYM6EQcgFPbJOt/rTTbNfguSg7ywDoE3iFLJdwQUsTFEL4VOJuhQKMhK6aozgYAOdsI bZ1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M4Yy8bip; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fy7-20020a17090b020700b001ece9122d3fsi21193369pjb.95.2022.06.28.07.23.24; Tue, 28 Jun 2022 07:23:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M4Yy8bip; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345252AbiF1OVN (ORCPT + 99 others); Tue, 28 Jun 2022 10:21:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344577AbiF1OVK (ORCPT ); Tue, 28 Jun 2022 10:21:10 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56B632C13E for ; Tue, 28 Jun 2022 07:21:09 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id ay16so26126687ejb.6 for ; Tue, 28 Jun 2022 07:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=AZ1tY/fbYnbotdriO5S1rk84v9dQ1fc1bIXXi25ViSs=; b=M4Yy8biplcD6xIbSik7Fcanj3qmtX6uFR9Lkcg9HY9n8g3FbAUo/QCyipVsW7Jci/W 76nJc0C4Qpa49bHjnodI8YHf+WPa5SaGG+EjfkUFHOKnlUtuQ6CROXVHEuKZnX/CpnBb mX6lu4SJJksUAqA5Mt/x2GJW7I+b6qEIW+PXpPA/+w2YWkE+9QRCSUIvYGi5xprrKF9D rVQ3kf6SiheUWDlrr/LE0VkX54WLqK4BZIiUu0tzWsts/0WbnNKrk0IqYkokD3unorO7 V0ZCyCwpJtlkSobho6Ucmi7hZHCLLGDYI8FgiZaC5zhiI7DhrFhYUjIn7/mV5L1eDGZb V2PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=AZ1tY/fbYnbotdriO5S1rk84v9dQ1fc1bIXXi25ViSs=; b=r6TfBLnn32C0mNNxGgF9pgzGsrxfi22w3/0Olwoo+3XFrQOhQRqQKue5q9lDAsUuS0 mMCJzTkPM3eYYon1SA74Q8+qdvFM9ztKXA3JFg+j3ZVlC6LTJEBHqvmmfYlRB77zDF0O BJnT7j4FLyGqqyfCjPyO44AU6NypOKS4AgH5sTfp6aBdnKQ0vuO2UgA+0w7Yx6MC3EOP Q/7sBviHX+6611ZtYG4MRrN8263Xcz1BufQNyVSR9+eq7qhKC7VdnEDkbopJzmJIXiZp rXDc3wCnF6zPV39OU5DwE3A07BroYLOzkA4CwfyQhtt3rhzKSq+bXd837P3C9rbB6EPB VZqw== X-Gm-Message-State: AJIora+8t6ZfOAe5oWCizWMFngrKHJ4nX7cmwMzKuISJ1TCsgDu2Ndq6 xE0lYv0IPz0a0/KsRk9nXifHog== X-Received: by 2002:a17:907:8a25:b0:726:c9f2:2f5e with SMTP id sc37-20020a1709078a2500b00726c9f22f5emr4317430ejc.286.1656426067781; Tue, 28 Jun 2022 07:21:07 -0700 (PDT) Received: from myrica (cpc92880-cmbg19-2-0-cust679.5-4.cable.virginm.net. [82.27.106.168]) by smtp.gmail.com with ESMTPSA id w16-20020a1709061f1000b0071d3b6ed4eesm6518768ejj.160.2022.06.28.07.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 07:21:07 -0700 (PDT) Date: Tue, 28 Jun 2022 15:20:43 +0100 From: Jean-Philippe Brucker To: Baolu Lu Cc: Ethan Zhao , Joerg Roedel , Jason Gunthorpe , Christoph Hellwig , Kevin Tian , Ashok Raj , Will Deacon , Robin Murphy , Jean-Philippe Brucker , Dave Jiang , Vinod Koul , Eric Auger , Liu Yi L , Jacob jun Pan , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 10/11] iommu: Per-domain I/O page fault handling Message-ID: References: <20220621144353.17547-1-baolu.lu@linux.intel.com> <20220621144353.17547-11-baolu.lu@linux.intel.com> <693a3604-d70b-e08c-2621-7f0cb9bdb6ca@linux.intel.com> <75b17c70-1658-91ea-0992-1be769550943@linux.intel.com> <935ca9e3-28c9-99af-5609-41bb1500b2b3@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <935ca9e3-28c9-99af-5609-41bb1500b2b3@linux.intel.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2022 at 07:53:39PM +0800, Baolu Lu wrote: > > > > Once the iopf_handle_single() is removed, the name of > > > > iopf_handle_group() looks a little weired > > > > > > > > and confused, does this group mean the iommu group (domain) ? > > > > while I take some minutes to > > > > > > No. This is not the iommu group. It's page request group defined by the > > > PCI SIG spec. Multiple page requests could be put in a group with a > > > same group id. All page requests in a group could be responded to device > > > in one shot. > > > > Thanks your explaination, understand the concept of PCIe PRG.  I meant > > > > do we still have the necessity to mention the "group" here in the name > > > > iopf_handle_group(),  which one is better ? iopf_handle_prg() or > > > > iopf_handler(),  perhaps none of them ? :) > > Oh! Sorry for the misunderstanding. > > I have no strong feeling to change this naming. :-) All the names > express what the helper does. Jean is the author of this framework. If > he has the same idea as you, I don't mind renaming it in this patch. I'm not attached to the name, and I see how it could be confusing. Given that io-pgfault is not only for PCIe, 'prg' is not the best here either. iopf_handle_faults(), or just iopf_handler(), seem more suitable. Thanks, Jean