Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Jun 2022 10:24:59 -0400
From:   Paul Gortmaker <paul.gortmaker@windriver.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Masahiro Yamada <masahiroy@kernel.org>, mmarek@suse.cz,
        Mike Rapoport <rppt@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] kconfig: Add implicit CONFIG_ prefix to
 IS_ENABLED() and co
Message-ID: <20220628142459.GB1723@windriver.com>
References: <YrrQOifFIiISf/3g@hirez.programming.kicks-ass.net>
 <CAK8P3a2XfzQo6emT4pXXxAjWewdP2LiAe2fOskFf-0suSmBJQQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK8P3a2XfzQo6emT4pXXxAjWewdP2LiAe2fOskFf-0suSmBJQQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6CEtXPS94DajXgkpjyu2m+3RksRTvYz9po7PyyWfoSJRW+saL8V9B6rvtLMF?=
 =?us-ascii?Q?YDSZd0N0v6UiJMmoxw8xXLxvfdACSzsBOHmiOmSHF9n3DtXbxy3hyYT0J1LJ?=
 =?us-ascii?Q?kT60zIvIMFAOzGDhUrkOX8cHHbSWfrO9d6XfulCJgxcj/HBtBrmx7cM2qVNo?=
 =?us-ascii?Q?CEMQ2yI8nmzWpzdIyG0SEAewjDYLcS8nutog+Mwzq5M4d5Swdox/HcAg4sLR?=
 =?us-ascii?Q?V2IF+7IsTpCTzdZw7f5Jix2HeQ8EsDHo5TJkq2lNAL23i0G6YaFU6La3nKuS?=
 =?us-ascii?Q?3EL5rGKYqiIfZsxQS1E0l2TYiULH+NrJQpBIWHssDFerLdP8YAWZw/pe/hDf?=
 =?us-ascii?Q?FYTuXjgK/DfLfj5ZyQjOgBhmZWE3PLrTW8lCfbxVQhnJBBdB6LqxXLcTCcuP?=
 =?us-ascii?Q?/NsqYBmUn0Uah/VOiU8wT+M26cw89cfjQuLHqBa5jl15L6Eh4i0/pPTcggCY?=
 =?us-ascii?Q?151ON1Qc4m12Wv5z4VL+YT0wGfocBuhEt2hOC46Ddozewyoogi+sCKFp3u1r?=
 =?us-ascii?Q?+ACP6Hu9MKw+VwfXaRAhkDHIf82Kw8YLp9k7tgPtaDut2l0+kz76tdwYQLiN?=
 =?us-ascii?Q?bbyry6h8WD8rX5X73duk6wmmORhXEfcB2qL9k/iMc0Tzn8rrxPC1YtfHaxP8?=
 =?us-ascii?Q?6FNsOfys3vlcy0Xuxkdm/xdE6FplGzpSoL8Si+c4F4kX3z6GmMm+PhenYUY0?=
 =?us-ascii?Q?jZsN9Yjz/EiW7LV7yXb3rLb6vbjRhHLgU6TkOAvnkzFHjlvj7H9ikSOFfVBD?=
 =?us-ascii?Q?WQSJ8K7+jyeS8glQ1DWZ/nL7Ig3ROjvObT4fdA8oYDbzcCkmD9BsXtQr3lsE?=
 =?us-ascii?Q?tfi9WR61vdDv6Ay6l5Bs6gHCRxL5ODGfdwjFk9Yg/9L5e3276eKWf0QvfZP7?=
 =?us-ascii?Q?AwDUzGYoSVaAGyFBi21SVyYcufvLIYUAIR/9kJsJXA23d4Bl58BAaeFpX0NE?=
 =?us-ascii?Q?2xIZmJ+c2x/MVCLDqjF/eiVx14k+0WfsLEWD899KozWxlCMMP0JxnUEfZwty?=
 =?us-ascii?Q?uvsd7iMcv+QKsgMkdGwrq7DnVYAsvt5pgMfMuCyla7AQs2o6JL0XNTsWUC2n?=
 =?us-ascii?Q?MF+7GAjZKAqV0sCNyaNV1vn6f4pTklkCnarVH/LTLJc+KYpNBjC9DZw71AvG?=
 =?us-ascii?Q?V9XYK3Z4gbFDpLQvTuWnQU/YB3pEnUxpnSBO2WtQ9MPVGxP+70TDskpJq7LI?=
 =?us-ascii?Q?1Vj0nQEBbCH2XW4xqCY9aOFfRxvl9x6NTJAMVW5CCPhuxoDDlX19JaVu6zSP?=
 =?us-ascii?Q?peOqmyH2HGRxm10tSxD7tZZ/pKerMJrTqaKKhGooHb4RxeROQI8IR+ZhoJQw?=
 =?us-ascii?Q?Bcf51HbNBxECQ4Hw6vusMItQBu770ejTiK3sjAqdXq2ucXJZNotXuR6uvhej?=
 =?us-ascii?Q?cn0tFLGEK1/uirY2OdI5GzlUp+UyqIX3LJZPwdOb8RDMUGAmVRXDRgF1TI6G?=
 =?us-ascii?Q?G9mYdvj3UnmJy87w0+5p6NJjq4Wfca1zyVhybPSR5o1xS0Lm0m0O0ftWg2aJ?=
 =?us-ascii?Q?/PKH9NqJsQpoEHGJlsqZym5qRF/2rVbeqzz04AAkTfjq3zhJ7Jnlz2d1yRyk?=
 =?us-ascii?Q?VHqaMA0d85+9uRdUjWyk1sIKyTVUIGDG57mB77jvL+mXsmOB8B+8uJpRU7ny?=
 =?us-ascii?Q?rg=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a623e0e0-7b33-4147-7521-08da5911ffb4
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4545.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 14:25:06.7085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K4NOC3FZ5RhaBMHBQAM9Xo9LB+uL5kjyKHG9x/a0fbZwLekEVRvB1fTUUfo5OnobtOuwrHVYTUia2/aFTZ4cZydEwDE9Z7FhO5a132RGKZk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1633
X-Proofpoint-ORIG-GUID: Bjj88NWAf_LU7g0wdJTF6DR7oPGxtVmd
X-Proofpoint-GUID: Bjj88NWAf_LU7g0wdJTF6DR7oPGxtVmd
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-06-28_07,2022-06-28_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 lowpriorityscore=0 phishscore=0 adultscore=0 mlxscore=0 impostorscore=0
 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1011 mlxlogscore=999
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206280060
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[Re: [RFC][PATCH] kconfig: Add implicit CONFIG_ prefix to IS_ENABLED() and co] On 28/06/2022 (Tue 13:19) Arnd Bergmann wrote:

> On Tue, Jun 28, 2022 at 11:56 AM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > Since IS_ENABLED() (and friends) are clearly meant to be used on
> > CONFIG_foo symbols and IS_ENABLED(CONFIG_ is so long and almost an
> > tautology, allow the more compact usage of: IS_ENABLED(foo).
> >
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> 
> I'd prefer to keep the more verbose usage, mainly because it makes it easier
> to grep for a symbol. If today you do 'git grep CONFIG_PM_SLEEP', you find
> all instances in Makefile, in #ifdef and in IS_ENABLED(), though not the
> references in Kconfig language, which leave out the prefix.

TL;DR - me too.

I confess that I do the same thing - I grep for CONFIG_FOO to find the
consumers, and "config FOO" to find the provider.

So while I can appreciate the value of removing verbosity, this will
impact workflows of average people out there.

Doing a grep for "PCI" is practically worthless.  Having to grep for
both CONFIG_PCI and IS_ENABLED\(PCI will inevitably annoy people when
they realize they missed a code path needing an update because they only
searched for the former.

Paul.
--

> 
> If we remove the prefix for IS_ENABLED(), the same grep fails to get
> all the results, while searching for the substring without the CONFIG_
> prefix can end up finding false-positives by finding longer strings (e.g.
> CONFIG_DEBUG_STACKOVERFLOW vs
> CONFIG_HAVE_DEBUG_STACKOVERFLOW).
> 
>        Arnd