Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp4022157iog; Tue, 28 Jun 2022 07:32:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tJn8GmOKuLwVcp3DFkv8LtZfMvjhf1bLYhvYRs3dDtKFmwo50Gey1tN1fChEnHrxgHFIef X-Received: by 2002:a17:90b:1982:b0:1ec:988f:e133 with SMTP id mv2-20020a17090b198200b001ec988fe133mr28025073pjb.211.1656426723607; Tue, 28 Jun 2022 07:32:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656426723; cv=none; d=google.com; s=arc-20160816; b=zR/QmNjsyGmcLrLm5mVEocoJokb//LEAfRWk3TKoSDP0fDJiyvJ3b0jGiblsKeyQCg 5U+iPvrPCzwSmRHsiTEVSg9EQI8flQjzH32jeQPn6JL5dYN3/bDNJDlOQ29nAE8QjK9R 77pi9XIpnyY3pGNj3d7AZ6f/IPimO3Bj930EAmGVfCiMen1xzGC8oaqNed7v0qUY2qUr YNxonzv0lWUrGis+agaZNujJC5B1oLU61RolPn1BGt4ag1COsIvwjBOJRvlT8axy4VBB pPkpYZmjIkIbCzPoVnhDvNCpXtRpF5F37TqGsloUyzDuluNhJgrWgeuhhHvhBV2/RZN7 9i1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :dkim-signature; bh=JHFbXd+WNtNIJszeKeAq0pw48IrQ1dnM0j78sJ1LNLI=; b=b7JkXPxd0s6ZWeW0sX+EIn+bt3/tKkVkMz2J7fqg7HlpyyVMNtHt0/d/Tz4LZ4u3sP KT1flfHJyD03kxHDEnsGhxui3xKgqTxx/0XZx2WxkSF5p2vWqfXIIkpJMPEDIJq00Ruy ctAs99W6HYC5sJ2XC/gkczuK3SH/VBLMDatYpq9UFwGI9q+lXwdWORfpIXiCmRBbobz3 8BqnK6gxg9itp+V9d+gaThh+kzNhTKl6LfV8DzOJX28jnbBwBy0LbC0fvovIRPfj9iPp 85Hvn0fyr1d1q+LSCryO74DYw5iC5dmsNJqCG3QsceWljUJfafLuLVgV8Aig9VpAN1q/ OVxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=CT1XHrct; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n10-20020a056a00212a00b0050dfa520d25si16912306pfj.157.2022.06.28.07.31.47; Tue, 28 Jun 2022 07:32:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=CT1XHrct; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346594AbiF1O1f (ORCPT + 99 others); Tue, 28 Jun 2022 10:27:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346598AbiF1O13 (ORCPT ); Tue, 28 Jun 2022 10:27:29 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E04F2F03D for ; Tue, 28 Jun 2022 07:27:28 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 4498222246; Tue, 28 Jun 2022 16:27:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1656426446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JHFbXd+WNtNIJszeKeAq0pw48IrQ1dnM0j78sJ1LNLI=; b=CT1XHrctn/p9QrSCpS0yYSjSmCtZ/F8BJDs5EhDC57YFKCtnE0lH9vNzjaDEpHUM7sXzrI HiLecE56ocS4JE0BIx06jXp+yzJatOIsntln1TlfUqUzqizz1rMVzIlLn/if3Uq13lWVj6 N6iWnX086nc/79yXg2u4WAFqgky5EoA= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Jun 2022 16:27:23 +0200 From: Michael Walle To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, arnd@arndb.de, shawnguo@kernel.org Subject: Re: [PATCH -next 1/2] soc: fsl: guts: fix return value check in fsl_guts_init() In-Reply-To: <20220628140249.1073809-1-yangyingliang@huawei.com> References: <20220628140249.1073809-1-yangyingliang@huawei.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <42601e860097651547fb9baecd660b5c@walle.cc> X-Sender: michael@walle.cc X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-06-28 16:02, schrieb Yang Yingliang: > In case of error, of_iomap() returns NULL pointer not ERR_PTR(). > The IS_ERR() test in the return value check should be replaced > with NULL test and return -ENOMEM as error value. > > Fixes: ab4988d6a393 ("soc: fsl: guts: embed fsl_guts_get_svr() in > probe()") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Thanks! Reviewed-by: Michael Walle