Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1656409369.git.mchehab@kernel.org> <e0a1fd8942a0e13ecf391ccd5634759d2281e2c2.1656409369.git.mchehab@kernel.org>
In-Reply-To: <e0a1fd8942a0e13ecf391ccd5634759d2281e2c2.1656409369.git.mchehab@kernel.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 28 Jun 2022 10:42:05 -0400
Message-ID: <CADnq5_PAW_et564Sjt7HvQwnqcMyzukc3paeU-pWPMKRM55DMA@mail.gmail.com>
Subject: Re: [PATCH 13/22] drm: scheduler: add a missing kernel-doc parameter
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>, David Airlie <airlied@linux.ie>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 28, 2022 at 5:46 AM Mauro Carvalho Chehab
<mchehab@kernel.org> wrote:
>
> Add a description for struct device at drm_sched_init(), in order
> to solve this warning:
>
>         drivers/gpu/drm/scheduler/sched_main.c:999: warning: Function parameter or member 'dev' not described in 'drm_sched_init'
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Generally in the drm tree we use / rather than : in the patch titles.  E.g.,

drm/scheduler: add a missing kernel-doc parameter

With that fixed:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>


> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/22] at: https://lore.kernel.org/all/cover.1656409369.git.mchehab@kernel.org/
>
>  drivers/gpu/drm/scheduler/sched_main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 76fd2904c7c6..b45bd8473e9e 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -987,6 +987,7 @@ static int drm_sched_main(void *param)
>   *             used
>   * @score: optional score atomic shared with other schedulers
>   * @name: name used for debugging
> + * @dev: pointer to struct device
>   *
>   * Return 0 on success, otherwise error code.
>   */
> --
> 2.36.1
>