Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759662AbXE1AWW (ORCPT ); Sun, 27 May 2007 20:22:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752339AbXE1AWP (ORCPT ); Sun, 27 May 2007 20:22:15 -0400 Received: from daemonizer.de ([87.230.16.230]:53810 "EHLO daemonizer.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbXE1AWO (ORCPT ); Sun, 27 May 2007 20:22:14 -0400 From: Maximilian Engelhardt To: "Rafael J. Wysocki" Subject: Re: software suspend doesn't work with 2.6.22-rc3 Date: Mon, 28 May 2007 02:21:51 +0200 User-Agent: KMail/1.9.7 Cc: nigel@nigel.suspend2.net, Herbert Xu , linux-kernel References: <200705261128.57332.maxi@daemonizer.de> <200705272242.00309.maxi@daemonizer.de> <200705272327.23291.rjw@sisk.pl> In-Reply-To: <200705272327.23291.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1258894.7zDULp1dxY"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200705280222.02198.maxi@daemonizer.de> X-Spam-Score: -4.1 (----) X-Spam-Report: No, hits=-4.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.7-deb * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% * [score: 0.0000] * 0.3 AWL AWL: From: address is in the auto white-list Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5751 Lines: 157 --nextPart1258894.7zDULp1dxY Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 27 May 2007, Rafael J. Wysocki wrote: > On Sunday, 27 May 2007 22:41, Maximilian Engelhardt wrote: > > On Sunday 27 May 2007, Rafael J. Wysocki wrote: > > > On Sunday, 27 May 2007 18:01, Maximilian Engelhardt wrote: > > > > On Saturday 26 May 2007, Nigel Cunningham wrote: > > > > > Hi. > > > > > > > > > > On Sat, 2007-05-26 at 14:49 +0200, Maximilian Engelhardt wrote: > > > > > > On Saturday 26 May 2007, Nigel Cunningham wrote: > > > > > > > Hi. > > > > > > > > > > > > > > On Sat, 2007-05-26 at 11:28 +0200, Maximilian Engelhardt wrot= e: > > > > > > > > Hello, > > > > > > > > > > > > > > > > When I try software suspend on my laptop it always returns = to > > > > > > > > my running system after some time. > > > > > > > > This is what's logged by the kernel: > > > > > > > > > > > > > > > > swsusp: Basic memory bitmaps created > > > > > > > > Stopping tasks ... > > > > > > > > Stopping kernel threads timed out after 20 seconds (1 tasks > > > > > > > > refusing to freeze): > > > > > > > > cryptd > > > > > > > > Restarting tasks ... done. > > > > > > > > swsusp: Basic memory bitmaps freed > > > > > > > > > > > > > > > > I have no idea what's the problem, but if you tell me what I > > > > > > > > should do I can create debugging information and/or test > > > > > > > > patches. > > > > > > > > > > > > > > Could you try this patch, please? It should help. > > > > > > > > > > > > > > Herbert, is this right? If cryptd is going to be used for blo= ck > > > > > > > devs, the task should probably be PF_NOFREEZE (or whatever it > > > > > > > is today) instead. > > > > > > > > > > > > > > Regards, > > > > > > > > > > > > > > Nigel > > > > > > > > > > > > > > crypto/cryptd.c | 1 + > > > > > > > include/linux/freezer.h | 3 +++ > > > > > > > kernel/power/process.c | 2 +- > > > > > > > 3 files changed, 5 insertions(+), 1 deletion(-) > > > > > > > diff -ruNp 991-fix-cryptd.patch-old/crypto/cryptd.c > > > > > > > 991-fix-cryptd.patch-new/crypto/cryptd.c --- > > > > > > > 991-fix-cryptd.patch-old/crypto/cryptd.c 2007-05-19 > > > > > > > 18:16:47.000000000 +1000 +++ > > > > > > > 991-fix-cryptd.patch-new/crypto/cryptd.c 2007-05-26 > > > > > > > 19:45:42.000000000 +1000 @@ -341,6 +341,7 @@ static int > > > > > > > cryptd_thread(void *data) > > > > > > > > > > > > > > mutex_unlock(&state->mutex); > > > > > > > > > > > > > > + try_to_freeze(); > > > > > > > schedule(); > > > > > > > } while (!stop); > > > > > > > > > > > > I tried your patch, but when I apply it my kernel doesn't compi= le > > > > > > any more. I get these warnings/errors: > > > > > > > > > > > > [...] > > > > > > CC crypto/cryptd.o > > > > > > crypto/cryptd.c: In function =E2=80=98cryptd_thread=E2=80=99: > > > > > > crypto/cryptd.c:344: warning: implicit declaration of function > > > > > > =E2=80=98try_to_freeze=E2=80=99 [...] > > > > > > LD init/built-in.o > > > > > > LD .tmp_vmlinux1 > > > > > > crypto/built-in.o: In function `cryptd_thread': > > > > > > cryptd.c:(.text+0xd7f5): undefined reference to `try_to_freeze' > > > > > > make: *** [.tmp_vmlinux1] Error 1 > > > > > > > > > > Ah. You'll need to add #include near that start > > > > > of crypto/cryptd.c. Sorry for forgetting that. > > > > > > > > > > Nigel > > > > > > > > I added the include line and now I could compile the kernel, but > > > > suspending still doesn't work. > > > > > > > > swsusp: Basic memory bitmaps created > > > > Stopping tasks ... > > > > Stopping kernel threads timed out after 20 seconds (1 tasks refusing > > > > to freeze): > > > > cryptd > > > > Restarting tasks ... done. > > > > swsusp: Basic memory bitmaps freed > > > > > > OK, this means that cryptd doesn't execute the try_to_freeze() for so= me > > > reason. > > > > > > Please apply the appended patch on top of 2.6.22-rc3 and see if that > > > helps. > > > > > > Greetings, > > > Rafael > > > > > > --- > > > crypto/cryptd.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > Index: linux-2.6.22-rc3/crypto/cryptd.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > --- linux-2.6.22-rc3.orig/crypto/cryptd.c > > > +++ linux-2.6.22-rc3/crypto/cryptd.c > > > @@ -316,6 +316,7 @@ static int cryptd_thread(void *data) > > > struct cryptd_state *state =3D data; > > > int stop; > > > > > > + current->flags |=3D PF_NOFREEZE; > > > do { > > > struct crypto_async_request *req, *backlog; > > > > Even with this patch suspending doesn't work, dmesg shows the same error > > message. > > I also did build a kernel without cryptd and suspending does work there. > > Well, that's strange, because in that case the freezer shouldn't even wait > for cryptd. > > Can you please try the patch at http://lkml.org/lkml/2007/5/26/169 ? With this patch applied suspend does work fine. Maxi --nextPart1258894.7zDULp1dxY Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBGWiCqOimwv528XGERAgQfAKCN2G03qCfXIET30uLOV6ob7BRlbQCeOZ5Z 5OfFyns1NSyo2Fio7JXrqm8= =Fokp -----END PGP SIGNATURE----- --nextPart1258894.7zDULp1dxY-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/