Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Jun 2022 18:20:37 +0200
From:   =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Herve Codina <herve.codina@bootlin.com>,
        =?UTF-8?B?TWlxdcOobA==?= Raynal <miquel.raynal@bootlin.com>,
        Milan Stevanovic <milan.stevanovic@se.com>,
        Jimmy Lalande <jimmy.lalande@se.com>,
        Pascal Eberhard <pascal.eberhard@se.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v9 15/16] ARM: dts: r9a06g032-rzn1d400-db: add
 switch description
Message-ID: <20220628182037.55b21637@fixe.home>
In-Reply-To: <CAMuHMdXwe0YmZr+BjArnWWALAsC28_Q+zy3F0cHMZDxOxdnCLg@mail.gmail.com>
References: <20220624144001.95518-1-clement.leger@bootlin.com>
        <20220624144001.95518-16-clement.leger@bootlin.com>
        <CAMuHMdXwe0YmZr+BjArnWWALAsC28_Q+zy3F0cHMZDxOxdnCLg@mail.gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Le Tue, 28 Jun 2022 17:34:31 +0200,
Geert Uytterhoeven <geert@linux-m68k.org> a =C3=A9crit :

> > +&gmac2 { =20
>=20
> Please keep the nodes sorted (everywhere).

Arg sorry, again, the previous nodes seems not to be ordered.
I'll be more careful next time.

>=20
> > +&pinctrl{
> > +       pins_mdio1: pins_mdio1 {
> > +               pinmux =3D <
> > +                       RZN1_PINMUX(152, RZN1_FUNC_MDIO1_SWITCH)
> > +                       RZN1_PINMUX(153, RZN1_FUNC_MDIO1_SWITCH)
> > +               >; =20
>=20
> This is not a single value, but an array of 2 values.  Hence they
> should be grouped using angular brackets, to enable automatic
> validation.

Good to know, noted for next time.

>=20
> I will fix the above while applying, so no need to resend.

Thanks Geert,

Cl=C3=A9ment

>=20
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v5.20.
>=20
> Gr{oetje,eeting}s,
>=20
>                         Geert


--=20
Cl=C3=A9ment L=C3=A9ger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com