Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp4140083iog; Tue, 28 Jun 2022 09:47:18 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vj6LeaQt+Hc198oSbpQ/OFr8m+DCtWIgfhBaPUsIhDcNdloQpMdiKdNRA7deHbnDQBjo1a X-Received: by 2002:a63:6a85:0:b0:3fa:722a:fbdc with SMTP id f127-20020a636a85000000b003fa722afbdcmr18621497pgc.174.1656434838404; Tue, 28 Jun 2022 09:47:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656434838; cv=none; d=google.com; s=arc-20160816; b=XvvDhr66CDGgTFml/LKynWYrSggTe3MXm1zyQBd3wWSbwc3B7SghAs3Ljv+VDBuxiH EP3GMXvNZehdQw+xw0kZHVx8+npKqgrdVnt9yjc3d/kaX3WP9Pknwf+9rgZlXU+Csei3 vuEI+pPpGEsjFbHOsyWfIappJhONIXBayODTWOzvTH9wYUUwFqHgQmH7kmSP4sOdgpMM hZ5wlNmdCOM1i8g+yHlnjRykOgCH89hFAjliE945Aa/t8Fsg8fUlAP2TqMvz9dKO01Bv Nvp5LxmigJSFELM+n3/twbFDD2yiEoEKIyDj8mEAk0JIxOsQTlbWdPO/KfWWKw8kICO7 UJWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=OpbwiH8c6kHxSQyMJuDwcp20qDhv3Nvl6R1dqQ31uuY=; b=yIohRr1p6BxeSDTrKVViJaDmn1aO91TI2oz8QVL2yGvB9WRcm5K6cn4MPr1KXhr6WS x6+5XW6LKoLCOOf/v5YG4zjd/sqVS3ds+54NLrwHESNk72ZK5HU0taNQ2y9Dmb1f6KPT J8LB8t4MyhlzmmVi+OqpIQIdyW9Ee+TROHtDlvESSiDrSRbENEsxXCwhr2hifvLvq2VY CVGiFMgWdR+P7MTHqB7ygwM6cEAvvBUZEdOtUJoBfgzCE6DRv9MSa6ZNCkaNOtT+12SH YBiVfWdcNZzXiSbR6vfLZJ9BTCbpghe+THhIWaGGDMDB3FyQhB9af+GA1JTqeJrMfzmA DRww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mi11-20020a17090b4b4b00b001e3495408d6si99338pjb.123.2022.06.28.09.47.05; Tue, 28 Jun 2022 09:47:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233139AbiF1Qd2 (ORCPT + 99 others); Tue, 28 Jun 2022 12:33:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238142AbiF1Qc0 (ORCPT ); Tue, 28 Jun 2022 12:32:26 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86DD912A8D; Tue, 28 Jun 2022 09:24:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D0FE8CE217B; Tue, 28 Jun 2022 16:24:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3B86C3411D; Tue, 28 Jun 2022 16:24:43 +0000 (UTC) Date: Tue, 28 Jun 2022 12:24:42 -0400 From: Steven Rostedt To: Aaron Tomlin Cc: mcgrof@kernel.org, christophe.leroy@csgroup.eu, cl@linux.com, mbenes@suse.cz, akpm@linux-foundation.org, jeyu@kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, void@manifault.com, atomlin@atomlin.com, allen.lkml@gmail.com, joe@perches.com, msuchanek@suse.de, oleksandr@natalenko.name, jason.wessel@windriver.com, pmladek@suse.com, neelx@redhat.com, daniel.thompson@linaro.org, hch@infradead.org, Thomas Gleixner , linux-rt-users Subject: Re: [PATCH v11 10/14] module: kallsyms: Fix suspicious rcu usage Message-ID: <20220628122442.5e3af503@gandalf.local.home> In-Reply-To: <20220628162122.v7s3z24icwavur6y@ava.usersys.com> References: <20220310102413.3438665-1-atomlin@redhat.com> <20220310102413.3438665-11-atomlin@redhat.com> <20220627235612.4796c837@gandalf.local.home> <20220628162122.v7s3z24icwavur6y@ava.usersys.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jun 2022 17:21:22 +0100 Aaron Tomlin wrote: > If I understand correctly, there is absolutely no need to explicitly > disable preemption in this context. I will use: rcu_read_lock() and > rcu_read_unlock(), respectively, which will then be suitable for the > preemptible RCU implementation. Yes, thank you very much :-) -- Steve