Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Jun 2022 09:42:50 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Lukas Wunner <lukas@wunner.de>,
        Alison Schofield <alison.schofield@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V12 5/9] driver-core: Introduce BIN_ATTR_ADMIN_{RO,RW}
Message-ID: <Yrsvilq7/JILlGLA@iweiny-desk3>
References: <20220628041527.742333-1-ira.weiny@intel.com>
 <20220628041527.742333-6-ira.weiny@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220628041527.742333-6-ira.weiny@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KMKosWEtmjIaaonFfK+KVuFErbGI4ADQ0sCN+Dl7yWcJ5DbgH7tOdT8eD4yf?=
 =?us-ascii?Q?S7LWr1BD4o8SEG9CWaOJq//s8Z1rIMO2CPqmgmObLLZoJ53vSBiTA6UKqxh7?=
 =?us-ascii?Q?WEaM1Ox23u/Rcf81I6IOzK90P5oQHze9JQoIuoGMFhUg6Wj//mfrU4UObQuL?=
 =?us-ascii?Q?i6eoVMDCOwFiO6b3X5fNtrWNNqTOJuynTUfBGBsk69kHcFDPPgISSSKgBisj?=
 =?us-ascii?Q?cUI+usCMAfsjvmUkBd5ZTBrZQ4A3ZkyIxI2QUTczM1CWf8tXjrgk0r1VYf2g?=
 =?us-ascii?Q?Iy0y6Xey/erTlnrX9gviwpRycX8NydB5poC84Mbk83KSQ7sEDLKWqLTHFmdg?=
 =?us-ascii?Q?Z3+1TTBsHVZvnOSSwauA0kJephJUxJ7NSpEFIUPLIyqFZSeOkFE4VWH6M7Cq?=
 =?us-ascii?Q?Eh7pVvBDf7setJpgJNIco5jqiGShKX6POdvznF/k32KFpT4lTvEruP9uQd6D?=
 =?us-ascii?Q?XUK+1IqGyBDTX9px3wXmL7JOeO3nMlp7IPf7oo1mmj9LFS0gsatj36DmDqet?=
 =?us-ascii?Q?VF/TE2m611hJPDTtaWZqOkVffgUJhohbGABUo8Xjs9A/b3w5t6pacVytT9lH?=
 =?us-ascii?Q?f72B7KXslfrX/HjAsUNWNjpHaAyCtmdfr76u9tYdqn6lJDviPdX1ipR2B0yM?=
 =?us-ascii?Q?SztnFS/TWxNJC11w5W7riXSUsfH0m7NcxpllR8MLftdtSPFDOpSF6spmdhSl?=
 =?us-ascii?Q?g4aDd2WacflOOSimC0QNDs4DcTsTXb2pPeZgIyFxjPWeMiUko7DUlSRLPkMb?=
 =?us-ascii?Q?sgJULEVcfHtR/Mce+acUBQ4CDplR5MHLve6eXWNprXQtuuNWw8djrdWo5IMw?=
 =?us-ascii?Q?GxGf1Gq5vqS2Klx33hT4K3xc+ScB7Wf/DAMKdEuqHZk+WtiBCuLIzGeKMUrv?=
 =?us-ascii?Q?2b6QNoTkv7E75nifxfL5KN8U2RaDg43OKmmoMeORD8N85TjUBDvNX3tsU2QN?=
 =?us-ascii?Q?36fBlv6xqwxFJNFO/AaZg5uAYtDu9ktf1YkRS3dKWBwlAJmk3bVK91nLkRGl?=
 =?us-ascii?Q?dcetd2gy9Mfa54HAv/2e5Ys6Fe3EYhv4ybKFtbGucE5vPjtBWzn+dNKN3zBx?=
 =?us-ascii?Q?eCt/TwFMs+IsheQ4qWmERs4u3sGutU9yPoVsQJEW/rg747SzZ+VbRKjU7ELM?=
 =?us-ascii?Q?9wzNRoWCHNrLfm+sMiOtz47LGm1zKmplSfBeY8Xe47vS9ieOLJmG6ngv/bJo?=
 =?us-ascii?Q?GOc1hjai0OcEuPKousroEpJWUQRKzVgx4dLFYVxLRSmSt6nQ9v/f8j94bSnH?=
 =?us-ascii?Q?13OSPB1bAISiKU7VqFjlaKiFghwwAyyZhy7aeU3wRotfTVA7soj3JhGEQlNf?=
 =?us-ascii?Q?Dv/VLUOt8utWaxOR7RRRCsSCm/OWtaAZmnBAG5PBufo1+wKXnfpMuer8JRBQ?=
 =?us-ascii?Q?HQHNJH0jeerJum4IlxAjfmm+q3pKs/x1tLKMvlOSRCV3AjNEBX5ACygUPry+?=
 =?us-ascii?Q?ta/Wf/zRhdy+rfgeeBuiYscE1ftyuuem7RkNkV9PObFAqJqJfWklb7P6H1NJ?=
 =?us-ascii?Q?RxUB1A7JpoGR03QHAgaBe9Xy6uprPf2KYAVnTOzQw9SbrfzYEJ9wPB8fB7UR?=
 =?us-ascii?Q?+aPGk1cuin+b5+07eDMeFw8CrYHAzk6sBW5Tm0W6DoWYz/GXKMXSslngVhxV?=
 =?us-ascii?Q?MfjhPmerkbGzvr9FpURnujICk45SrNOnQW9tBQuzJIUA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 523c7070-38ee-4a57-be9b-08da5925429c
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 16:42:59.3514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xZj7Rz4wnIDz9vF4S/6lZjNroyrIhhU24ZDe1Nn4m5AxnHPWeDf8g+x2YpwSDHpTq3FLEsOemx578VK9DlB4/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3248
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 27, 2022 at 09:15:23PM -0700, Ira wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> Many binary attributes need to limit access to CAP_SYS_ADMIN only; ie
> many binary attributes specify is_visible with 0400 or 0600.
> 
> Make setting the permissions of such attributes more explicit by
> defining BIN_ATTR_ADMIN_{RO,RW}.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Bjorn Helgaas <bhelgaas@google.com>

This should have had a suggested by tag on it.  I'm hoping that Lore will pick
it up with this email.

Suggested-by: Dan Williams <dan.j.williams@intel.com>

My apologies to Dan.
Ira

> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> ---
> Changes from V11:
> 	New Patch
> ---
>  include/linux/sysfs.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> index e3f1e8ac1f85..fd3fe5c8c17f 100644
> --- a/include/linux/sysfs.h
> +++ b/include/linux/sysfs.h
> @@ -235,6 +235,22 @@ struct bin_attribute bin_attr_##_name = __BIN_ATTR_WO(_name, _size)
>  #define BIN_ATTR_RW(_name, _size)					\
>  struct bin_attribute bin_attr_##_name = __BIN_ATTR_RW(_name, _size)
>  
> +
> +#define __BIN_ATTR_ADMIN_RO(_name, _size) {					\
> +	.attr	= { .name = __stringify(_name), .mode = 0400 },		\
> +	.read	= _name##_read,						\
> +	.size	= _size,						\
> +}
> +
> +#define __BIN_ATTR_ADMIN_RW(_name, _size)					\
> +	__BIN_ATTR(_name, 0600, _name##_read, _name##_write, _size)
> +
> +#define BIN_ATTR_ADMIN_RO(_name, _size)					\
> +struct bin_attribute bin_attr_##_name = __BIN_ATTR_ADMIN_RO(_name, _size)
> +
> +#define BIN_ATTR_ADMIN_RW(_name, _size)					\
> +struct bin_attribute bin_attr_##_name = __BIN_ATTR_ADMIN_RW(_name, _size)
> +
>  struct sysfs_ops {
>  	ssize_t	(*show)(struct kobject *, struct attribute *, char *);
>  	ssize_t	(*store)(struct kobject *, struct attribute *, const char *, size_t);
> -- 
> 2.35.3
>