Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Jun 2022 11:25:35 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Terry Bowman <terry.bowman@amd.com>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v11 net-next 3/9] pinctrl: ocelot: allow pinctrl-ocelot
 to be loaded as a module
Message-ID: <20220628182535.GC855398@euler>
References: <20220628081709.829811-1-colin.foster@in-advantage.com>
 <20220628081709.829811-4-colin.foster@in-advantage.com>
 <CAHp75Vcm=Zopv2CZZFWwqgxQ_g8XqNRZB6zEcX3F4BhmcPGxFA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vcm=Zopv2CZZFWwqgxQ_g8XqNRZB6zEcX3F4BhmcPGxFA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OA8d5YqKpnVxWs1W5DBSBDyeV5oVffMjg0i7DOMYY0EhUeNzZ/YeEpZ+peiU?=
 =?us-ascii?Q?Ga7H2UEdaXhuUnlbD+YG7ufK0Bm3lnvXhKc0fnql5OG4G8L3FgE6iYNDBsSY?=
 =?us-ascii?Q?Z2GKJyXCjujbGim2Tv/nZQ7KlBD2Y+XFd535Z8LWXAT+SU2maXwI1KEk1dFk?=
 =?us-ascii?Q?8+MDNHIyaaUvAHl4k6xG1MCjNEMX36mC9Xu+ZpG6+0YU+Pt1Gn95Z+YrnYk3?=
 =?us-ascii?Q?UPkUgKqTnZ7BDYKoFFcTd3k5Rb520aXk+herIWlU+A3gcI5TU8H4FAInvm+K?=
 =?us-ascii?Q?gl4e0oPURszpwAJ79zbsV5bJZ1r7Nb72sXLMWvyFjY+UK/Q15EtxtA/9Tv5t?=
 =?us-ascii?Q?DnfwldIlXvqQ9I51i6oYURt/HU+RvloiF3/E0bV0sPjQqP3Qf44QD2DoKax1?=
 =?us-ascii?Q?YpyE85ZgvWONZWFXe5FdzpRd3QUo+c+tpo3j/F0OQguhokrs45azwWjicdPH?=
 =?us-ascii?Q?AhkvJj6lYKLHoKEytckXa8NiFTBmj/xmg6n1MpnmpDlzMnFlpOotIqsvJavv?=
 =?us-ascii?Q?8+cJmxclBeqBkqV+5bb+3MCKtVn3tMftJsgclAdxTtjgUxe6UfbYkGfAxCEa?=
 =?us-ascii?Q?Jz8RZUWn6NGCvW7M6KGcpYbkNroRL/OmD+/aKpgaxi4bfDjReXWUJG4iig4M?=
 =?us-ascii?Q?MdGHSUAXMGopb73dxPqcIUdO2kY79UxrF41fGMnl1ezFfQ7/CvRYkIw/bf56?=
 =?us-ascii?Q?0w0ArGW28mKDAyjLqh0+2xQT9fRNp3vCE9g8g7aBysk+4jnFmspQOVDPUlaX?=
 =?us-ascii?Q?BDznQOWE5U1yFKhJpBJtDgOd/lnvN8a7A5ZlllOV6p5+LUhjpRVjJ6B/HROk?=
 =?us-ascii?Q?5u82ySkX7oActCfAc0VsnbN7gRe1MOhJ/gfxXIzIpV+aURCWj81cjrOPpe67?=
 =?us-ascii?Q?/qtn15AXq1+ypzqBcLagaJbIILoG99Umwqu9Cb2mubW54RoDcyTOSg97oL2e?=
 =?us-ascii?Q?MEsYHNw+vx8LipUaoc5ZYdMShfwT1FC5yjIUOHXBOfhCwvOkXRxTE0O3shoT?=
 =?us-ascii?Q?Y5qth8ib8qnS5LcAygL81S3ePhzmjCLEY43rA0c81IK1BpTkH6nUQEi1JC2C?=
 =?us-ascii?Q?iyrSj1UG/eCOC2YjvRg8b5JV8oFYEw5hX3TioL9ovySYjsfD9o5Ny9AhWIko?=
 =?us-ascii?Q?E4seVglK7N2ucIMpl9+wCiLaFnBoZEvlKa6BL9jnVfHk54u0hrprg01mZvnV?=
 =?us-ascii?Q?IMIQ6PmUVi1LLhUwUQmSZYs8wHr57kAOPLvQL6lYONetzpsFudAyvmv0ylvX?=
 =?us-ascii?Q?/WSg8BCLWw03l8mfTMtucJ2MA23JoIZkK5gpOLpbql7qpTTh+YRJotSSkP3H?=
 =?us-ascii?Q?boQWBWMKlBtMJqj/aAJZ+KcgiznYSkLerem/CcaK+Lm2NPdTzp59A9NL8Sxw?=
 =?us-ascii?Q?7ihe81pJSI7IlJyEbQK8zF3ETm2TZo3zxSQHAF690RpSsEZJZuwL94lXUKEt?=
 =?us-ascii?Q?A1SJyIzIHKpvL8Cm/Cqt/9/ogMsyOSV0+PHihTStiqjY3PVwkcHZonOZUs9d?=
 =?us-ascii?Q?QAMkpjMZRwNYJbR8bAoHOvsuVUFDkWF9bEe/MekMkwYxMBJ3L3L5l4f/ukg7?=
 =?us-ascii?Q?XgQfgTEE5EOq/vYfdjqzauoXdRqEh6qzJMQRYb5QLaVjsKugFrTzmdFxSR49?=
 =?us-ascii?Q?bq1sowWT0TRRHJzBUfKEBfI=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 828fb0f3-1a82-4a9e-64e5-08da59339945
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 18:25:37.8199
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Or4Wzx3GA/WlLFbi/i2bWS7hwFarxfuiWs53EmXw5YUdY2Z3StopjtfMsmq31WEEwiXUdrGp2FT23ckuPeOmPgR3W9YjBrNRAYqP1WeVH5w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2258
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,

On Tue, Jun 28, 2022 at 02:53:49PM +0200, Andy Shevchenko wrote:
> On Tue, Jun 28, 2022 at 10:17 AM Colin Foster
> <colin.foster@in-advantage.com> wrote:
> >
> > Work is being done to allow external control of Ocelot chips. When pinctrl
> > drivers are used internally, it wouldn't make much sense to allow them to
> > be loaded as modules. In the case where the Ocelot chip is controlled
> > externally, this scenario becomes practical.
> 
> ...
> 
> >  builtin_platform_driver(ocelot_pinctrl_driver);
> 
> This contradicts the logic behind this change. Perhaps you need to
> move to module_platform_driver(). (Yes, I think functionally it won't
> be any changes if ->remove() is not needed, but for the sake of
> logical correctness...)

I'll do this. Thanks.

Process question: If I make this change is it typical to remove all
Reviewed-By tags? I assume "yes"

> 
> -- 
> With Best Regards,
> Andy Shevchenko