Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Jun 2022 11:31:16 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Terry Bowman <terry.bowman@amd.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v11 net-next 2/9] net: mdio: mscc-miim: add ability to be
 used in a non-mmio configuration
Message-ID: <20220628183116.GD855398@euler>
References: <20220628081709.829811-1-colin.foster@in-advantage.com>
 <20220628081709.829811-3-colin.foster@in-advantage.com>
 <20220628162604.fxhbcaimv2ioovrk@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220628162604.fxhbcaimv2ioovrk@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SkKrOuOxorsSRFvrce8ZeGkeu67mjg0WGHrVVUq7NuKyiH9plq0T9+GyY/DM?=
 =?us-ascii?Q?TNSCN0a+agoH1TkivVkj3fkZuYaI13SaLREV0XCnGt8Jgdb2g+UgKNrqBJqk?=
 =?us-ascii?Q?mZohtZ/93sLQQNsYnLxM5ICykLYhx/wXbZ14Hm3sTbjhJW6hE58NENFFhwEQ?=
 =?us-ascii?Q?WcrQEhdTKXbWrcBmRanYQJrwjAKulQkrwpYxU7WTaxmI3a9ggEuXqYMvsK97?=
 =?us-ascii?Q?x+UO1lBj8YwrncqocJ0+ulF4WFe1fHkWovKs0gQYBexGX3A9QipwQaqWj0iZ?=
 =?us-ascii?Q?rTvxj+sfMX7YzWwXl1K0yBbjEILlSCpVXxksyLvhcvagIG1YHckJGcSlRNPy?=
 =?us-ascii?Q?8TSYeUjyRazatQNYRV8a1++TnlximkJuU+xm1pruykWJSgj1MUiMr88zLXUL?=
 =?us-ascii?Q?5FAGSCSH8kV5zAPW2na3qiyXw0kVWuUJIlN39XVxNhg9BVupU1d9ogkNgdl+?=
 =?us-ascii?Q?zqwuRDfLdjk2c07OEww7n019w+VA7uwhlb815jVbts5sB3pCaH9RwoAxIHa4?=
 =?us-ascii?Q?acGkU29GxWysqjgVel5Ebilttdk4NrBSU2wv1VxfA8jlrROgF3CsZvNy1z5x?=
 =?us-ascii?Q?LXBnReCV2j/bEsHOkH9yFl40cFL2EH3YKOeXAQQjspxNT56Os3nbx8yiAxnh?=
 =?us-ascii?Q?hXPOGhM4Mh7DbUYu9Lanv4R1KMDyzx+DjHQzXQe3ZMto08sYqxXU9BnbZvN2?=
 =?us-ascii?Q?06qKegjlADNBBet2PafiSltB1jvQdRyWTV19K2+NL62TBLyrcRAtEF0HasPs?=
 =?us-ascii?Q?n+/Sk/D8fX+XXxa5OqmP8a9Yq1Y6HOVmN1dQ6omf3WQWBtijHCpwHtKi5weN?=
 =?us-ascii?Q?uNz5xZo3srEOYX96V9eshAfe67HgQvqIiG2rD4OA5eXKgN4wK4RqwP4Husb4?=
 =?us-ascii?Q?c3PaXL90NuSxPGUta8yunQ1W24S94mT/HhDosuk5rJnRcH7/4u/0vwYEm5CY?=
 =?us-ascii?Q?izhgI6QWeLd6dwPvs6ocE0rIxDQ8yrRynE0jAEb1H2HrUiEX5GVyworjucs1?=
 =?us-ascii?Q?QRQLA/YJ8HyMwpIv0SHMQKYEFBUJtHpohYnhv19iH/pwOdUM/0HPzi78pRaa?=
 =?us-ascii?Q?379KcohqW55pdt6y63Iuj3NIcHQ96rguqSCe4dDw745l0bJ5Egl6nhNAd8UN?=
 =?us-ascii?Q?O4QilAsHYbN4n8JiLhmJ3g96dt4mT+WSlI3brPGfxda2xHmoQBsC67lGMah4?=
 =?us-ascii?Q?tAHQINcRgfs2A5/nu9JgzldGAFIVpbtJPf8HxXcXr8RxOpqc0wyV920wo9U2?=
 =?us-ascii?Q?AfkVVjVFec0uwFaZAbWL87otaoICCUsRm8VU/7kxHjgXoB5+R4PIwOU6ktPN?=
 =?us-ascii?Q?pFb5N4NZeZ98+Ry79IgZEQ/2vBJrp0tNpycevTBzo0MvKrCXllPLOX5PW+UC?=
 =?us-ascii?Q?hON7IMXh4eWegnH2l3ZYVnudXTbVj643UfjwiStWBF7HlPIMCY9oskEedWyN?=
 =?us-ascii?Q?OYbjbLbIIG/aeiirCsp97kTQ2NoQF/hASeDEqKCdRARVUgH3PmDh25prV2F9?=
 =?us-ascii?Q?DLiGxa04aycKNMxW06/fCSoDEvzKKhsLTdbFP4q8ogfEArvIOEmMIOoz0x4r?=
 =?us-ascii?Q?gxdhUirkCwkZTAL35ipsV0yT677sST+/1OfZW9gdUiWMiRloqpKhP4HijQ/y?=
 =?us-ascii?Q?hRlpAF3e8cLOHvK9xji5BFg=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1a71c19-58c9-4561-dd38-08da593464fb
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 18:31:19.5620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KB9OnIr+cFS7ya8ovB+hlYVRD8mT+bAlSjwF9gwz4JRRW3+rgWUSEcAL7T0t4+MorKAvOo6aP9NxKvzqYO0IiNtW/GY8UJTbWyynxmYz6CI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1685
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vladimir,

On Tue, Jun 28, 2022 at 04:26:05PM +0000, Vladimir Oltean wrote:
> On Tue, Jun 28, 2022 at 01:17:02AM -0700, Colin Foster wrote:
> > There are a few Ocelot chips that contain the logic for this bus, but are
> > controlled externally. Specifically the VSC7511, 7512, 7513, and 7514. In
> > the externally controlled configurations these registers are not
> > memory-mapped.
> > 
> > Add support for these non-memory-mapped configurations.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> 
> These "add ability to be used in a non-MMIO configuration" commit
> messages are very confusing when you are only adding support for
> non-MMIO in ocelot_platform_init_regmap_from_resource() in patch 9/9.
> May I suggest a reorder?

Initially my plan was to get the MFD base functionality (SPI protocol,
chip reset, etc.) in and roll in each peripheral one at a time. That was
changed in v6 I believe...

Maybe a commit reword to suggest "utilize a helper function"?