Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Jun 2022 15:05:06 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
Cc:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Jonathan Corbet <corbet@lwn.net>,
        Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Will Deacon <will@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Marco Elver <elver@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Gabriele Paoloni <gpaoloni@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH V4 11/20] rv/monitor: wwnr instrumentation and
 Makefile/Kconfig entries
Message-ID: <20220628150506.291d093a@gandalf.local.home>
In-Reply-To: <944694879f67c0e635815ac57154be477a1b9108.1655368610.git.bristot@kernel.org>
References: <cover.1655368610.git.bristot@kernel.org>
        <944694879f67c0e635815ac57154be477a1b9108.1655368610.git.bristot@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 16 Jun 2022 10:44:53 +0200
Daniel Bristot de Oliveira <bristot@kernel.org> wrote:

> diff --git a/kernel/trace/rv/monitors/wwnr/wwnr.c b/kernel/trace/rv/monitors/wwnr/wwnr.c
> index 8ba01f0f0df8..3fe1ad9125d3 100644
> --- a/kernel/trace/rv/monitors/wwnr/wwnr.c
> +++ b/kernel/trace/rv/monitors/wwnr/wwnr.c
> @@ -10,11 +10,8 @@
>  
>  #define MODULE_NAME "wwnr"
>  
> -/*
> - * XXX: include required tracepoint headers, e.g.,
> - * #include <linux/trace/events/sched.h>
> - */
>  #include <trace/events/rv.h>
> +#include <trace/events/sched.h>
>  
>  /*
>   * This is the self-generated part of the monitor. Generally, there is no need
> @@ -37,21 +34,20 @@ DECLARE_DA_MON_PER_TASK(wwnr, char);
>   * are translated into model's event.
>   *
>   */
> -static void handle_switch_in(void *data, /* XXX: fill header */)
> +static void handle_switch(void *data, bool preempt, struct task_struct *p,
> +			  struct task_struct *n, unsigned int prev_state)
>  {


Patch 8 was the "educational" patch. There's no reason to split 10 and 11
up too.

-- Steve


> -	struct task_struct *p = /* XXX: how do I get p? */;
> -	da_handle_event_wwnr(p, switch_in_wwnr);
> -}
> +	/* start monitoring only after the first suspension */
> +	if (prev_state == TASK_INTERRUPTIBLE)
> +		da_handle_init_event_wwnr(p, switch_out_wwnr);
> +	else
> +		da_handle_event_wwnr(p, switch_out_wwnr);
>  
> -static void handle_switch_out(void *data, /* XXX: fill header */)
> -{
> -	struct task_struct *p = /* XXX: how do I get p? */;
> -	da_handle_event_wwnr(p, switch_out_wwnr);
> +	da_handle_event_wwnr(n, switch_in_wwnr);
>  }
>  
> -static void handle_wakeup(void *data, /* XXX: fill header */)
> +static void handle_wakeup(void *data, struct task_struct *p)
>  {
> -	struct task_struct *p = /* XXX: how do I get p? */;
>  	da_handle_event_wwnr(p, wakeup_wwnr);
>  }