Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33d1edc7-0846-5ff4-7311-06ceed353972@oracle.com>
Date:   Tue, 28 Jun 2022 14:11:41 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v1 08/14] mm/mshare: Add basic page table sharing using
 mshare
Content-Language: en-US
To:     Barry Song <21cnbao@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        Aneesh Kumar <aneesh.kumar@linux.ibm.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Jonathan Corbet <corbet@lwn.net>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        David Hildenbrand <david@redhat.com>, ebiederm@xmission.com,
        hagen@jauu.net, jack@suse.cz, Kees Cook <keescook@chromium.org>,
        kirill@shutemov.name, kucharsk@gmail.com, linkinjeon@kernel.org,
        linux-fsdevel@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>, longpeng2@huawei.com,
        Andy Lutomirski <luto@kernel.org>, markhemm@googlemail.com,
        pcc@google.com, Mike Rapoport <rppt@kernel.org>,
        sieberf@amazon.com, sjpark@amazon.de,
        Suren Baghdasaryan <surenb@google.com>, tst@schoebel-theuer.de,
        Iurii Zaikin <yzaikin@google.com>
References: <cover.1649370874.git.khalid.aziz@oracle.com>
 <5c96dd165d7ec3da14306b8fd857c7eb95a8c3e6.1649370874.git.khalid.aziz@oracle.com>
 <CAGsJ_4xPFu5FCQtNE6cJxbV7kMQXNtzotBFQKC3OkXUOtweyYQ@mail.gmail.com>
From:   Khalid Aziz <khalid.aziz@oracle.com>
In-Reply-To: <CAGsJ_4xPFu5FCQtNE6cJxbV7kMQXNtzotBFQKC3OkXUOtweyYQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVJYNU82cU82SFRyYi83MEhXOGhuSDZBd0Zjc1hKZnNiR0hHL1ZxVjMrc2pq?=
 =?utf-8?B?djZqK0lsV0ExQVVlOWo5aHpqVkxIRkFmYzN5VjJHZzRCR2FOMHBnOHVVd01X?=
 =?utf-8?B?QS8vUWxBTmJndHFCeWRHNUpKUG5HaElWelFnNHAySHdmbzM5djZCbjFtSUFF?=
 =?utf-8?B?Y3dOWm1pWUFuWmozM1lRNDE3Q21hRWs0Qjc5dE5aWGkyeEpIcE40eTNCUWFG?=
 =?utf-8?B?N0syL3YwNTNCQWc2UWdWb2dPYWpuQ3c0RVZJL2EzdzVsek04YVBmZE1zNUVM?=
 =?utf-8?B?L3F5L3VUbnBNWCt0SXgvNWJFVmVYVldWMExNNndFM1ZaWE1mUkRKOXNoR3N0?=
 =?utf-8?B?SGJNbHpmU0xGT3ROeTVFUlU5Wkx3R0F3MEJ1Y01LSzV6SXV2ekgzRzk2VUc4?=
 =?utf-8?B?MXZ6VFY3WFh1ZnM1VGZVVXhnaUdjNVdXZVFmcTg2UjcxZXRVMXF2TzI5aE5M?=
 =?utf-8?B?OHJrM3FFcThRUW9JcTdkRVF4MU1QTWJqUmNIdXl6cXVMa1hObVVQUVJ6ME9k?=
 =?utf-8?B?elRCT0wwUjZkSFQzSlI2REZPRUtTeUc5YldOU2VscjhtdUdQSzNGYXh1dHVF?=
 =?utf-8?B?MUVxRmpQVFM1WjlMMW9NaVI2Mjgxc01GVFcvajlCQTIrRHdxdHJGUUZEcGJj?=
 =?utf-8?B?alY2WnRCdU05Z1pUNlhVd0JudEt4ZUdYVmNKblhXVy9wV1g2eHBtalpLeVFt?=
 =?utf-8?B?TXpRcSt3M0pzM3lwUTBJMEFhUTRtNHdUSmR4NGtZNUxxemRwMHdpVVVtaElh?=
 =?utf-8?B?MXc0K2Joa1Z6OFgxVlBzcGN0UlFQSDdrWkZwSXQ0bStqM3l1WUV4aVU5UTNO?=
 =?utf-8?B?ODZwNGd4dWhudGRBcHcvbk9aVGtTYk9hZllHa3FCOW12S0xrSWZCSFNHcTNB?=
 =?utf-8?B?aHM0K0NYUllGVFl5SS92cS9uSnVHQi9Fa0wwN2NZSDNEU2FVeUw2a20rTXlK?=
 =?utf-8?B?VXVvZXQrS1N5UkxFR2FoN0FGTFJkR1pNQ1pvNXRmVG1RWDNRbDB2RlNKUkUy?=
 =?utf-8?B?QnE2NCs2c2VJYnBLUlYzcHJtRm1TaU1yN3crV0VHSXZaM3hJUFRjb1FzT0tV?=
 =?utf-8?B?aWxQOVFOa1B2ZkthSlFRcFNLT1h5NlBEVncrS2U5cnRkcGRFaXlPVDhVVU5Q?=
 =?utf-8?B?d1hKSlR1MklhOHlqeEFiaFZIYmFHYSs2SFVqMHUzUnp4cGdScUF4TzJ4VHFn?=
 =?utf-8?B?N25nS0VWMU82Um1JY2Q5Tm82TlpWbHBzWTVCWk95Y1FZVXhZVlkyQnFYRytH?=
 =?utf-8?B?dVNRYUZ0aXBnYkVmSnAvL2grbnZWd3A4NlRyaTd3QTFmZ01RV1diTDFhbXh1?=
 =?utf-8?B?bVFnWEZLRVduaXpRdFN1UzdXQXV3NGQ1T3lwekl3MzhLMThLbEthdTFyQzB6?=
 =?utf-8?B?RmRhTmYvMlVUNjFzWUQvZG01QVlLYVZGeHdoNnB2K1FYSDVTTTkwUVNvVWJr?=
 =?utf-8?B?eVZqbTh4RW8zaTlxcHN4WjFsWGxUemFqUmUzVFVVUmtnWDczYmlxcGZDd2Jl?=
 =?utf-8?B?dE5CL2dZUzJIYkZPSnNUTm1YVzFnNkdVQ0M1U0d6UTcyNWVUMjQrOWpJSEw4?=
 =?utf-8?B?NGxaZFRQYUNycnkrMXlEY3BoNTdvRWUzUmZwYW10ZEwvSmRwRkJUdFJrcHFM?=
 =?utf-8?B?L2tGNXNtR1lyZEYrRmd2T296M3V4a3dZdlJxWGJ0eFZzVmxjYkxIeFc0UGNp?=
 =?utf-8?B?NWhqYWNRNWtsTzRUbnRDMkwrTS9OWEFoWTFHeUdlNzJFb2h0c3pRU3UxMEhi?=
 =?utf-8?B?Vk5IK0d0bm0wcVRpMXdHVFBabmxQUkx4a3BKUEFFQk5ENGFLZU1uSWh4Kzgr?=
 =?utf-8?B?QUtFbUR6RkVzSmg2cWJpdTFrNUE1VEd0OGYyalNiWFFTRkFsaUV4MzJYYkpB?=
 =?utf-8?B?dzQ0ZVVhU3BFbWNPWVR3cWNkM2s1R3RaNHpHTm9BTXA0ZEc2by9VbGs0ak1t?=
 =?utf-8?B?bnFrVDVkUkxVUmlSNHlCMmlaWldSSWpod2x2U21pUitGeWMyYnY5eWc0NThL?=
 =?utf-8?B?QWJ2cDNldVNZOWcxalpaaDJyaWluWE04U0NmcDhzczNLeElDNXBrcGxmVktD?=
 =?utf-8?B?SHZiUUprT1NVZmF6VFRLRmhjWXUvL2NWTE84bXdWbWpGamN6dGwvbDdvdHh6?=
 =?utf-8?B?U0dhci9FeXpPblE3cHB3OFZkejhicnRqbVNWclVId2RDd3dWVlhYaTJ5MG5k?=
 =?utf-8?Q?ZMEwXX1ZyQqh7stkaIvDwO7eQmzHHawmtvOiaKyJDkpt?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2658b815-9007-42ac-cdf3-08da59426d05
X-MS-Exchange-CrossTenant-AuthSource: BN8PR10MB3220.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 20:11:46.3937
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P7qqOkU0MgflKXaik4bS4mWANAypnckD7P8p4pHYUqw3G7IylWErb5FIYaroGApfIQGfI9w8zjewyCbwnVr7zA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5573
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-28_11:2022-06-28,2022-06-28 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206280080
X-Proofpoint-GUID: SEEit6Ngxu9OPMlO5tYetnNcgXwxLEJq
X-Proofpoint-ORIG-GUID: SEEit6Ngxu9OPMlO5tYetnNcgXwxLEJq
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/30/22 05:11, Barry Song wrote:
> On Tue, Apr 12, 2022 at 4:07 AM Khalid Aziz <khalid.aziz@oracle.com> wrote:
>>
>>
>> @@ -193,6 +226,8 @@ SYSCALL_DEFINE5(mshare, const char __user *, name, unsigned long, addr,
>>          if (IS_ERR(fname))
>>                  goto err_out;
>>
>> +       end = addr + len;
>> +
>>          /*
>>           * Does this mshare entry exist already? If it does, calling
>>           * mshare with O_EXCL|O_CREAT is an error
>> @@ -205,49 +240,165 @@ SYSCALL_DEFINE5(mshare, const char __user *, name, unsigned long, addr,
>>          inode_lock(d_inode(msharefs_sb->s_root));
>>          dentry = d_lookup(msharefs_sb->s_root, &namestr);
>>          if (dentry && (oflag & (O_EXCL|O_CREAT))) {
>> +               inode = d_inode(dentry);
>>                  err = -EEXIST;
>>                  dput(dentry);
>>                  goto err_unlock_inode;
>>          }
>>
>>          if (dentry) {
>> +               unsigned long mapaddr, prot = PROT_NONE;
>> +
>>                  inode = d_inode(dentry);
>>                  if (inode == NULL) {
>> +                       mmap_write_unlock(current->mm);
>>                          err = -EINVAL;
>>                          goto err_out;
>>                  }
>>                  info = inode->i_private;
>> -               refcount_inc(&info->refcnt);
>>                  dput(dentry);
>> +
>> +               /*
>> +                * Map in the address range as anonymous mappings
>> +                */
>> +               oflag &= (O_RDONLY | O_WRONLY | O_RDWR);
>> +               if (oflag & O_RDONLY)
>> +                       prot |= PROT_READ;
>> +               else if (oflag & O_WRONLY)
>> +                       prot |= PROT_WRITE;
>> +               else if (oflag & O_RDWR)
>> +                       prot |= (PROT_READ | PROT_WRITE);
>> +               mapaddr = vm_mmap(NULL, addr, len, prot,
>> +                               MAP_FIXED | MAP_SHARED | MAP_ANONYMOUS, 0);
> 
>  From the perspective of hardware, do we have to use MAP_FIXED to make
> sure those processes sharing PTE
> use the same virtual address for the shared area? or actually we don't
> necessarily need it? as long as the
> upper level pgtable entries point to the same lower level pgtable?

Hi Barry,

Sorry, I didn't mean to ignore this. I was out of commission for the last few weeks.

All processes sharing an mshare region must use the same virtual address otherwise page table entry for those processes 
won't be identical and hence can not be shared. Upper bits of virtual address provide index into various level 
directories. It may be possible to manipulate the various page directories to allow for different virtual addresses 
across processes and get hardware page table walk to work correctly, but that would be complex and potentially error prone.

Thanks,
Khalid