Received: by 2002:a6b:cdcf:0:0:0:0:0 with SMTP id d198csp4123474iog; Tue, 28 Jun 2022 13:24:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uIid5prJXr8uVeV5P8jn6azKJCqLavfLkaPF3J1hHHhOXyu58hC3kpn3k++jKY02vD7ft6 X-Received: by 2002:a17:90a:fd17:b0:1ec:92c0:575 with SMTP id cv23-20020a17090afd1700b001ec92c00575mr1559449pjb.55.1656447860645; Tue, 28 Jun 2022 13:24:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656447860; cv=none; d=google.com; s=arc-20160816; b=zrLnaIAGhySSL5xH5Gg2Pqdhe88VqrSMc9Sqyn0CoMw5nk40a8mIzYOAJWI5eIMJrg VsOHNNB/BQJtaBiK/eNb5ZHYRQo7Am84pqsy2R+IGmUWV+tup2pp2fD7nt+/y5TQ6h2A FxtOLNMQCHjRR/pZZuOMRdMjdXI/ILv5jRZajU59EpntJTQD1EYrCF9JCxHgJoDwXYgp qnQN5N+Ax6AmZBtjhjzlKhgw+Qe62ePMhHRyt0IEtaQT8Y8bB/ZeCC22ckTpTqAmpXfp Es0gZNDFZyx/cJ4qikh76X+9puw/sJfccIF6dUxHU3OToLAqLbiBdQJFVV8QuCBJOzT/ B1TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=s4j/VUuwpqAhpSmewB4QnlDQdKmoLMZa5xK7xdwSdiY=; b=leb4NDHouX6Pt+OnaMTjIavGFPvfDzjAnoCrdH/r9A2TPqwbpIELSdXfOpv6PgAK0n 6MliHhOzEvTy4aH39aF7QFSLNt+D1DWiDYBZOKXWTdKwWgB33zOxGExn0UPZi6J/3qvS SMQha5le7gBK6Q4bZwur9flndv7z1c23nz+1Koi0wxTCxvq09FgTDYhS8+SsoX58eK0+ 6zDBZH0Lr2hX2Yp/PoHK9mfxrW6oqEy/BAsVLF4qzSb8WmuEGk46m7yiOPZOLMMKxrxw HrSULi7X2Rw0KrnC5bZhBNx2jgQNNP1MVxt8yNR3Yh2dRHQLEAZMdKspBvjA54ssXHTy LJVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fCceC5v0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bd10-20020a170902830a00b0016228c736afsi18105759plb.511.2022.06.28.13.23.44; Tue, 28 Jun 2022 13:24:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fCceC5v0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232725AbiF1UWM (ORCPT + 99 others); Tue, 28 Jun 2022 16:22:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231515AbiF1UVa (ORCPT ); Tue, 28 Jun 2022 16:21:30 -0400 Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [IPv6:2001:4860:4864:20::32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 251643CFDA for ; Tue, 28 Jun 2022 13:19:20 -0700 (PDT) Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-101ab23ff3fso18615327fac.1 for ; Tue, 28 Jun 2022 13:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s4j/VUuwpqAhpSmewB4QnlDQdKmoLMZa5xK7xdwSdiY=; b=fCceC5v0ighl7q4Q/LNtvixvAyZkLH98vCNJu7JsIt/odnS5zfkGFKbJQASWEXeraY W93TV/DY1qqNvu8mDFQlUkSauPmKLrC641yKZK3ybpEEWHfSRYX5n6rqn0G/JdFqUYZq PrwOsP1reyTu7JJVlKYMVsr7uDK1Qi2oW+/JnM/iOjxKd4KHqsoGdM1wWZE5ZAcR9rq/ VGWL9Tli5HAO6vxgi6awDnwtyLF4uDFBdCUmzAMrJ6CFPp0cNDP97Iroxog/2rNBKIC3 wAttVtcWIKpmvgAfc1AXeO+/MPtpDI3UOmAszgeMWdcz0dS0SpkxTzX6c3dMrPinRv5J 13Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s4j/VUuwpqAhpSmewB4QnlDQdKmoLMZa5xK7xdwSdiY=; b=3h9XhG1Sx/zNtzDrOrIqQEKo8Lf++mPMX3xrl8Es21dAiLpt9x291ZDyMKI/0FVMzi f7dovZBaOAZXihbSdaMtMwFLMMiTJJXHHSYdoJdlUl9mANaOOlm6soNpGeV5o/1BlWrF AVU+Um/5v55+BDzEQUx/jLnxUc03ciQjTFxYzwIj8hk96gGpHZ4VcwECFEbh1Y2bJ4wL b1XFUEh4NuxN9e0XeXbsTQgYJIUHaRy7vUSgXJ40IFvjeTLBJFSykf46b30pAoOTZQl2 7gPB3p3gkV0X7AMXKzxyTWhdCeYZWxJAyX+YJ5rPBfb2w5vgeNHBFk2/0NrQ6sAc/0sg j1tg== X-Gm-Message-State: AJIora8M3YRJFnGTSdi0PIUqGUGOWreMKGDm8wdOwXWAJU6YVI9lVmew Jle+KIJ+dk2+TVfVtMtnXHV8Og== X-Received: by 2002:a05:6870:3920:b0:101:d628:b053 with SMTP id b32-20020a056870392000b00101d628b053mr851287oap.111.1656447559505; Tue, 28 Jun 2022 13:19:19 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id a12-20020a056870d60c00b000f30837129esm9536923oaq.55.2022.06.28.13.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 13:19:18 -0700 (PDT) From: Bjorn Andersson To: Douglas Anderson Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Stephen Boyd , Matthias Kaehlcke , Krzysztof Kozlowski , Konrad Dybcio Subject: Re: (subset) [PATCH v3] soc: qcom: cmd-db: replace strscpy_pad() with strncpy() Date: Tue, 28 Jun 2022 15:18:54 -0500 Message-Id: <165644753308.10525.5322214498477940111.b4-ty@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220628064301.v3.1.Ie7b480cd99e2c13319220cbc108caf2bcd41286b@changeid> References: <20220628064301.v3.1.Ie7b480cd99e2c13319220cbc108caf2bcd41286b@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jun 2022 06:43:13 -0700, Douglas Anderson wrote: > Commit ac0126a01735 ("soc: qcom: cmd-db: replace strncpy() with > strscpy_pad()") breaks booting on my sc7280-herobrine-herobrine > device. From printouts I see that at bootup the function is called > with an id of "lnbclka2" which is 8 bytes big. > > Previously all 8 bytes of this string were copied to the > destination. Now only 7 bytes will be copied since strscpy_pad() saves > a byte for '\0' termination. > > [...] Applied, thanks! [1/1] soc: qcom: cmd-db: replace strscpy_pad() with strncpy() commit: fe72f9bce137055fb744d4f8a91baa234ec07baa Best regards, -- Bjorn Andersson