Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sean Anderson <sean.anderson@seco.com>
To:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>, netdev@vger.kernel.org
Cc:     Russell King <linux@armlinux.org.uk>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-arm-kernel@lists.infradead.org,
        Eric Dumazet <edumazet@google.com>,
        linux-kernel@vger.kernel.org,
        Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH net-next v2 22/35] net: fman: Specify type of mac_dev for exception_cb
Date:   Tue, 28 Jun 2022 18:13:51 -0400
Message-Id: <20220628221404.1444200-23-sean.anderson@seco.com>
In-Reply-To: <20220628221404.1444200-1-sean.anderson@seco.com>
References: <20220628221404.1444200-1-sean.anderson@seco.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cTA2YzKMvdkAARbTryN1OOfFGpPmZKty2rFnfRGZbXp0wD8sXdjwIZsBz5vm?=
 =?us-ascii?Q?gm/2/banswrp2IOAZURf+yYCK3+NCK6LKyH4fEFcEBQRbNjoHS635aDuIl0+?=
 =?us-ascii?Q?/xJ5gbDXHb39Yc1wTJZdTuwgHFIGbOyhMXy5orfTUB8caV/cWMzopruuekpY?=
 =?us-ascii?Q?mhTITQO0PR67o7+89pZg4zzBgTQIvdEAesoniX6PfBxB0rrWmeus1jN6x/HT?=
 =?us-ascii?Q?ws1mBqRqPaQ6aF4H0sZ3OR3PKv+KCRKBc3SFZawltuxu0GDG51zAGNPB3AUc?=
 =?us-ascii?Q?jU98wL7C6KIaBubkMQebF6Ehgrb56yxGfDOsFoEMVrtamfjTGJId31+mKsRV?=
 =?us-ascii?Q?Y1SO7GSkXcTY/DkMIbkYLPaw/tDB9tIiGskHsgOqqOwOFLTDoX+ftGJOp1qq?=
 =?us-ascii?Q?KIDJKb2RYrwM7n09RUVj68rcHj+z8fOgQxZGGHK+9OVFwtgihpfQcecsaWqn?=
 =?us-ascii?Q?ledEm0ZGinPxFMS9w38aXAkpaC4MERSJl6Re6NvCz3zxLHpewNHTw/jPFyh2?=
 =?us-ascii?Q?Lqx2Naw6ND4JyQE/62EngBAUZz8aZuM9HvMwmeTuLs7iQuIrhDlNtYtCB61W?=
 =?us-ascii?Q?jNjYcDLcled7ybaYwz2WybG9MutO9H2k2jXgzPMOgp4NlEzQFDPJu3nLsVRK?=
 =?us-ascii?Q?+W8bjbPwA6PC5biW40RZllvcypYswnZK68xV2rSyHtcr+kIbo7BjI4Owt36W?=
 =?us-ascii?Q?z6Xi4s/NWgm8if5JFb6eYZ9dZJfQUQeSGNbOnPx602mGzLOOxVDOH7k7056s?=
 =?us-ascii?Q?kvDfkTPquHITM1/MbUTX4D48uVBfWSrdw5yv6Ct/MbI1T4jJYZnw9aZcm5HW?=
 =?us-ascii?Q?3+xG3vM12PvzJUshAT9NTVQxy4I49ut4F+k0saeKUof6JatdUSxQGhdjrg2r?=
 =?us-ascii?Q?ymh+OK7tmWPW2QYJbQLzD3oKWc4j8E9RYbNzmPYp1CtorFtkE1n7qdYnx+zK?=
 =?us-ascii?Q?Xo9TIBklxQO4cK0qtbksSO6Jw0OwmqBZJ8PGNCUuu0fEuiMYTS/w8HnkUA+C?=
 =?us-ascii?Q?wR4gwA7UUoVlOP5LM23qSoPVgylQHnLQ2r9npCMg1zaGqwGXpM+mH/OdQa4z?=
 =?us-ascii?Q?ayKdBl9eJjucNvGBt9c3w1xT7yFd+RmXOEkWxOZfi4O8i9hXSyQ/OLF1hIoe?=
 =?us-ascii?Q?hFHrZFTm22AXWud0atNJKs3pmTsLmPyvSvzdfcUG72kyfjidXhKXzAX1ghpl?=
 =?us-ascii?Q?EQ+IkDJBEAda78cwAdoqbt2dpGV7nHllcs96/5QK3lVhHICK98FrU4Pk869w?=
 =?us-ascii?Q?pSgqlFh4W4klPbITO0BU1dGDKZD/a0aeI8h4b/jv1vpY8gpQglSb5upEbDBD?=
 =?us-ascii?Q?iSJoOHNdvqi4bR99UKDjTRlodzfQPjTUa8i9N73MCGdvki6zRTQJ7dHQqm4J?=
 =?us-ascii?Q?QDNUdJ+v4ZEfHjA8eScvcizz1xM/bI6+DzabRUWLCR4XhlmdFM6Zf/FQ6TB7?=
 =?us-ascii?Q?HVjP+z20/e7M+J0VY/ruQ2UMdxqvF0UGXywMB1qu4qF0bksPfQwGJUFOJ2ag?=
 =?us-ascii?Q?iFONqIjEB6+GXhN474zcruaYDDYB/XACG3R9zccnVnJWUBJz2m7b9BFKzWWk?=
 =?us-ascii?Q?15wi4giK8bE8a4qMWuCde1BYDl+/OX0Zu/TMuvsEiRFG3a5TQLOHS20mDyyl?=
 =?us-ascii?Q?lw=3D=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 234d29c7-080d-4a21-0803-08da5953a061
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 22:14:53.5155
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KF8YXc0T4IXLXVSJzvFaZzQ29mGSRFOnYqsf2xqp/UORboKVfn/194BvvVRP0kWvlsPXymuzNJi1q+nbZdOJKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR03MB3013
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Instead of using a void pointer for mac_dev, specify its type
explicitly.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

Changes in v2:
- New

 drivers/net/ethernet/freescale/fman/fman_dtsec.c | 2 +-
 drivers/net/ethernet/freescale/fman/fman_mac.h   | 5 +++--
 drivers/net/ethernet/freescale/fman/fman_memac.c | 2 +-
 drivers/net/ethernet/freescale/fman/fman_tgec.c  | 2 +-
 drivers/net/ethernet/freescale/fman/mac.c        | 5 ++---
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fman/fman_dtsec.c b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
index 09ad1117005a..7acd57424034 100644
--- a/drivers/net/ethernet/freescale/fman/fman_dtsec.c
+++ b/drivers/net/ethernet/freescale/fman/fman_dtsec.c
@@ -301,7 +301,7 @@ struct fman_mac {
 	/* Ethernet physical interface */
 	phy_interface_t phy_if;
 	u16 max_speed;
-	void *dev_id; /* device cookie used by the exception cbs */
+	struct mac_device *dev_id; /* device cookie used by the exception cbs */
 	fman_mac_exception_cb *exception_cb;
 	fman_mac_exception_cb *event_cb;
 	/* Number of individual addresses in registers for this station */
diff --git a/drivers/net/ethernet/freescale/fman/fman_mac.h b/drivers/net/ethernet/freescale/fman/fman_mac.h
index 730aae7fed13..65887a3160d7 100644
--- a/drivers/net/ethernet/freescale/fman/fman_mac.h
+++ b/drivers/net/ethernet/freescale/fman/fman_mac.h
@@ -41,6 +41,7 @@
 #include <linux/if_ether.h>
 
 struct fman_mac;
+struct mac_device;
 
 /* Ethernet Address */
 typedef u8 enet_addr_t[ETH_ALEN];
@@ -158,8 +159,8 @@ struct eth_hash_entry {
 	struct list_head node;
 };
 
-typedef void (fman_mac_exception_cb)(void *dev_id,
-				    enum fman_mac_exceptions exceptions);
+typedef void (fman_mac_exception_cb)(struct mac_device *dev_id,
+				     enum fman_mac_exceptions exceptions);
 
 /* FMan MAC config input */
 struct fman_mac_params {
diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
index 2f3050df5ab9..19619af99f9c 100644
--- a/drivers/net/ethernet/freescale/fman/fman_memac.c
+++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
@@ -311,7 +311,7 @@ struct fman_mac {
 	/* Ethernet physical interface */
 	phy_interface_t phy_if;
 	u16 max_speed;
-	void *dev_id; /* device cookie used by the exception cbs */
+	struct mac_device *dev_id; /* device cookie used by the exception cbs */
 	fman_mac_exception_cb *exception_cb;
 	fman_mac_exception_cb *event_cb;
 	/* Pointer to driver's global address hash table  */
diff --git a/drivers/net/ethernet/freescale/fman/fman_tgec.c b/drivers/net/ethernet/freescale/fman/fman_tgec.c
index 2642a4c27292..010c0e0b57d7 100644
--- a/drivers/net/ethernet/freescale/fman/fman_tgec.c
+++ b/drivers/net/ethernet/freescale/fman/fman_tgec.c
@@ -180,7 +180,7 @@ struct fman_mac {
 	/* MAC address of device; */
 	u64 addr;
 	u16 max_speed;
-	void *dev_id; /* device cookie used by the exception cbs */
+	struct mac_device *dev_id; /* device cookie used by the exception cbs */
 	fman_mac_exception_cb *exception_cb;
 	fman_mac_exception_cb *event_cb;
 	/* pointer to driver's global address hash table  */
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
index 0f9e3e9e60c6..66a3742a862b 100644
--- a/drivers/net/ethernet/freescale/fman/mac.c
+++ b/drivers/net/ethernet/freescale/fman/mac.c
@@ -41,10 +41,9 @@ struct mac_address {
 	struct list_head list;
 };
 
-static void mac_exception(void *handle, enum fman_mac_exceptions ex)
+static void mac_exception(struct mac_device *mac_dev,
+			  enum fman_mac_exceptions ex)
 {
-	struct mac_device *mac_dev = handle;
-
 	if (ex == FM_MAC_EX_10G_RX_FIFO_OVFL) {
 		/* don't flag RX FIFO after the first */
 		mac_dev->set_exception(mac_dev->fman_mac,
-- 
2.35.1.1320.gc452695387.dirty