Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c4f7d5cb-5b23-3384-722f-cc8c517cb123@nvidia.com>
Date:   Tue, 28 Jun 2022 15:55:22 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 2/4] kvm: Merge "atomic" and "write" in
 __gfn_to_pfn_memslot()
Content-Language: en-US
To:     Peter Xu <peterx@redhat.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Linux MM Mailing List <linux-mm@kvack.org>,
        Sean Christopherson <seanjc@google.com>
References: <20220622213656.81546-1-peterx@redhat.com>
 <20220622213656.81546-3-peterx@redhat.com>
 <c047c213-252b-4a0b-9720-070307962d23@nvidia.com>
 <Yrtar+i2X0YjmD/F@xz-m1.local>
 <02831f10-3077-8836-34d0-bb853516099f@nvidia.com>
 <YruFm8vJMPxVUJTO@xz-m1.local>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <YruFm8vJMPxVUJTO@xz-m1.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OU52b2xGUmFFU1dxS3pIQ0s1VGRmL3A0L3ZnOFluTjBraWo5ZGZDVUJjRUU2?=
 =?utf-8?B?aGVibWwzaWJxbUFsV0Y3czhrNyswOU04VGdncy9pMEdhRGErYlZ4YlJYR1h6?=
 =?utf-8?B?bi90am1DZ0F3a21KWTAra0IwRW43ekxzdDJwSzRWUXIvbys2bi9wdmk1UnVI?=
 =?utf-8?B?UnVXSm8wc0Q4UlFiT2JTaXhBWHdMUmtGMXc3dWJTMWE2dmRqRnp3L3l5RnBG?=
 =?utf-8?B?WnJnNFFNL05vY3VqTmRPYS92L3ZGdWp1UUdhck94WUUyZ0JTbHphYXl6aDl4?=
 =?utf-8?B?K3pNMDVCNkJOYTJ2TCtueEFrV2N6V2U3NXVyZmlUQWIxMHhiVUg2bHpXdGE3?=
 =?utf-8?B?N1V0czQwRjJCalBnWDJlRW1YL2t6MTJneC9HSlkyRTFLUXlBajhaUm1uL1FD?=
 =?utf-8?B?OC9NcHVIQnBCQUtab3k5MWZBQWcrNkQ5bVJOdGNySlJzamVUelpOQ1BVZFpF?=
 =?utf-8?B?RFMvbXhhN2V6cUU2bnRuQUUyMzZpWFpOSmNrWjJxSE9BOXJ0QkZLek1lcGl2?=
 =?utf-8?B?OGZGYVpCclNSaGNCOWFrTDl0elFqRU9VNDVzK2NKTlMzMkRSWUk3a3dPUFZY?=
 =?utf-8?B?QmN1WEZqY2hjYyt6dmZrclZENmgyS1ZPMWhtQWJKN2k0Y1MrKzlqaTQ0TS91?=
 =?utf-8?B?QUdEYVZxSGtXMkhVbUJhVnNkOTF0MUlZUjZTeURUV3JqQ1lyL2J1eDYvVHNF?=
 =?utf-8?B?SGdaVU0yT2h4ZFdZQ0MwSGNNWWRiZ1dtbnVoVUNWYU1JdFM4d0kxYjRRZXNx?=
 =?utf-8?B?aDVDYXZtd2U4ZDZsZTJIRDlvdjFLRTlqZ0V0b3FDZFBYSXl4YVhYSXFPZUZO?=
 =?utf-8?B?TjUzUFFTRG1iV1gybGdDUnVNeHd1Wk8wTGFWaXFPcG1MT3ZiRDZiRHlrSVdv?=
 =?utf-8?B?dGpCRDUyR2sxVUlpMGFrMDV2NXpXWVFYT3VWQUR2NzUwemVoV0kyem1HMmV3?=
 =?utf-8?B?SjJtZWJkbnVFVm1PaHFFTjhvdHNnREk4WE9Tc2ZyNldtaTQxbmR1QkJLb0xP?=
 =?utf-8?B?SUZXcHpWN2FWYUxoVmg2cVJ4dW9SVEhNbmpxSUhIU1YwbGo4djFzUGpuWWk3?=
 =?utf-8?B?QWtYaXBnTG1JN2pxVVR6ZnZFdVRGUnY1bVBYa1JPWGdhTmx0OFhROXhLeG5m?=
 =?utf-8?B?OVZZTW5sR1dzL21xSnRGM0FmYUQ1dHM2RXphaW13R0M3V1JxUDl0ZHppb2h3?=
 =?utf-8?B?ZzRPempxcEc0dTM2SjUwVEx0U1RIYnhqQWpmbUgxcUpMWG4rWFZaYUU5YmFr?=
 =?utf-8?B?b1ZpdTlaTmtSNWJCWWtpNmpjN01pVEJUb3lObFkycGpRc1U1M0dpWFdNMlEz?=
 =?utf-8?B?ek16RTJ0OUNJczFkdjAxWTdZVFJ0bzV5OFJpWVR3d0wvUFQ5cmZnSDdEU01h?=
 =?utf-8?B?dDBQZllCbFZMWlVqY3RNUHh1dUlTM211NVo0Q2JaVkVlUk9LOGdwZEgveTdG?=
 =?utf-8?B?bU9nMnExeU9aWUVST21JaFF0UjJ6NTNqY1BYajRPcEdpY3MvNGVPYkVqQzJM?=
 =?utf-8?B?NkJwQlFiRlRtMG1LTmt3d2hZVmtWYW5hZmdQYzhsOGxHVFl5bmMrdUtOTm9a?=
 =?utf-8?B?OGtOZytYN0FnOWtabi95aGNkNHFjRmNCZ2U0Q3lpdkNFamF3NGl0TmpyRTF3?=
 =?utf-8?B?Z2NZRkQzUnZmYlVMcncxQUEyVTJvYVptM0toMDFHTDBOd2x1djJHZ3FRUTRl?=
 =?utf-8?B?VWJZNTIrZkxYZkMyTm5qWkh4dTI1YTZSOUh6L2puODJNTzZxVDg4TlhoUUxs?=
 =?utf-8?B?eitML1I1QWhOSjlWWXNUdVZQS2xsdUZUcEJBSk9BMzFoRUtYNGNNK3VRalJ4?=
 =?utf-8?B?M0tZSjlpS0xmSU1kakpxcndOYXVMWE5UREpjbFQ0MUptOCtMbXc4NGtFVm01?=
 =?utf-8?B?RlZodllJSW4yS0RqazhGRk9Yc2xtcTJacWZmbERjYml5RXNPN09oaTJuc1hY?=
 =?utf-8?B?cjRYNGlGc3k3Q1BQMkZrRFNpYUpvMzJnUG1PWks0cmc3eHgrS1BJSWFtUStB?=
 =?utf-8?B?R1BEcFM2TU93Tzc5OWVnaXM2MHpERmR3RjRTR1dZcDJPcEJObjUzTk5PYjdE?=
 =?utf-8?B?bGU2VVhMQW55YWN3ZFhERnVkOU94blE4ZVAyTHpXUlhLcTBTcXArQTVJczVE?=
 =?utf-8?Q?Tw5gC7MRvRRTHOAD3M/68JF4B?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86a27550-5502-43ab-83e1-08da595949fd
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4140.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 22:55:25.5908
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LJvQtlWCsJlW+OJBtlCnw/6Lb1DXgKfa3nVT5Ix1jt3N5i36ODQMzhsku/WMgKJoE/SK2WqkaExVsbOdUR51Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6482
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/28/22 15:50, Peter Xu wrote:
> And if you see the patch I actually did something similar (in kvm_host.h):
> 
>   /* gfn_to_pfn (gtp) flags */
>   ...
> 
> I'd still go for GTP, but let me know if you think any of the above is
> better, I can switch.
> 

Yeah, I'll leave that call up to you. I don't have anything better. :)

thanks,
-- 
John Hubbard
NVIDIA