Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: j3CXdZLrCBLS9ICP40rBNtfRjhdL8HhwqBnLForRWQXHb+AbIIVb5u1QfdRSLOwWIBtVTeGmmq
 LpsBETUudFivZmIwixnU3q4rAC1t4U1GETXJUoTBn4qcLJ1LtANuP2/m6lzvCAROfwdXl1oyM7
 FPL/v53HSJbWTjM78fHbtt96a07mCrsqSJQ7ZoNMJQFmgpClyNtUy47nir4wALeNf6zp/3xF3Y
 C54IsTMPjORG+UoCi80nquUcTuV5batKstAQSV36pChPY4VtMgyHUcVMjztNbQ7ZXpEqRW2PWN
 hBuaA95uMbrUryn9HuERa78x
IronPort-SDR: sjE6FRkllAT5bsZH6LBrxsCRBNPjB4ujitYNXnObmF3khzrBToBbzjKF7LDK6H/zsUSG883414
 xthAtKKYlCLbvUD35eQb0n9CiOiGgTuSsszUZkJNJg55yt/J1OrMJTuRjSs0YFsLDzWMqLkwV7
 4ZAsFRjbqUSS1iMRQTouJL9LgMjWcgrxK64QPfQKNz6LAz2d9iRCJdtOm8aIP+Rsk08njfzhtI
 TgS5slc8P0SyYge/mF1MRwq7NN65984XQ5TCI/wHYstcDREM3lM+sSo/BcTvYpyxuQFOgHdhgw
 jHE=
WDCIronportException: Internal
Message-ID: <9fd807fd-f019-4ad2-7f4f-6746e05098bf@opensource.wdc.com>
Date:   Wed, 29 Jun 2022 10:14:52 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings
Content-Language: en-US
To:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        John Garry <john.garry@huawei.com>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1656335540-50293-1-git-send-email-john.garry@huawei.com>
 <16f727b8-c3b0-c828-0c5b-6728a6e7934f@opensource.wdc.com>
 <9044b81f-76db-75de-db74-f45d6e5ea71e@omp.ru>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <9044b81f-76db-75de-db74-f45d6e5ea71e@omp.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 6/28/22 19:05, Sergey Shtylyov wrote:
> Hello!
>=20
> On 6/28/22 11:59 AM, Damien Le Moal wrote:
> [...]
>>> x86_64 allmodconfig build with W=3D1 gives these warnings:
>>>
>>> drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_piomode=E2=
=80=99:
>>> drivers/ata/pata_cs5535.c:93:11: error: variable =E2=80=98dummy=E2=80=
=99 set but not used [-Werror=3Dunused-but-set-variable]
>>>   u32 reg, dummy;
>>>            ^~~~~
>>> drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_dmamode=E2=
=80=99:
>>> drivers/ata/pata_cs5535.c:132:11: error: variable =E2=80=98dummy=E2=80=
=99 set but not used [-Werror=3Dunused-but-set-variable]
>>>   u32 reg, dummy;
>>>            ^~~~~
>>> cc1: all warnings being treated as errors
>>>
>>> Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is
>>> stubbed, which is the same as what we already do in pata_cs5536.c .
>>>
>>> Signed-off-by: John Garry <john.garry@huawei.com>
>=20
>=20
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>=20
>> Looks good, but I wonder why I am not getting this warning. I always d=
o
>> W=3D1 and C=3D1 builds. I tried allmodconfig now and I am not getting =
the
>> warning...
>=20
>    I can confirm the (fatal) warnings with RedHat gcc 10.3.1... but som=
ehow they only
> occur on x86_64 with allmodconfig indeed (which is strange)...

Compiling on x86_64 with allmodconfig with gcc 12 and sparse-0.6.4-2
(Fedora 36) does not give the warning... Weird.

>=20
> [...]
>=20
> MBR, Sergey
>=20


--=20
Damien Le Moal
Western Digital Research