Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp270273iog; Tue, 28 Jun 2022 22:56:54 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sVTXONab9WIFykpF1Z9r4dAZOrh7UrdA76EO24XxU/YzpOE5VLB/WwkFwSfpRzSWp4bIWY X-Received: by 2002:a63:4a41:0:b0:3fc:a671:f379 with SMTP id j1-20020a634a41000000b003fca671f379mr1615472pgl.594.1656482214164; Tue, 28 Jun 2022 22:56:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656482214; cv=none; d=google.com; s=arc-20160816; b=SED8skrZ5b0z0RWXevQTWE6Ilekenw8HMoOTlTb1F+6s1suBFTs/IP34tJO87xaLAL xHkXoVyJpN6l5IcXe+0RhSQBIac5ZX9Kp1l9QM8as07ruDKxnec6DkINQTCUjwjw+Exv L/RvNDIwwkcbok3pMPnoD5K1qd1Zb5xS+Ab1CPQmFRYoSClsohzHTbtDH7crtrSDCU+O TnMMF5Ikydrlt0fo90D1S1kz7KfsUnA8eE0KDIvnIetHJsqDeQfgFIYFpnNpWmeWEYn/ zsZEcItIUkzoM8fRTOxFBhdaylboX9GS8SfGgkWFmsXoYPWZ9d6593VWz7d3rMSfftaZ MVtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1YBqdukEjmcQv4229s2jn5G+rP7f7kYpmmkX2BQayFQ=; b=ZtMx262dpqkv+v4c/MnYdyR1fkz8XekliWcQL+h80Sqxc/J+3M1skjSwvFcvMuskSv gCBunGJ0Hb/CTSIvN6S3LHg7o0lcQpuKbmguAu2Pq2FkNB/ntASYw1rR3eNNeWPi8hYp j5Bf7iU8GVUC/E2nZVkVDLIipbgKV5bTehth3NM4MePHnkn2cEKEDmE9WxYKLo1+gHzF pSBqmcOVDGGA12821UKm/uVTuzyaGlQMQUmA+wh4BZW9U2i9Li1US+ZE8BY0+zu2Bgnm MamZWLrNcQx4PLpDm7WApFpxXTkXoMuiHMn19yxR9n3urKxM8qLlDThY+BqBitR43WjE 708w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Cm2qlKkc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p3-20020a17090ab90300b001df5e0b50d9si1924241pjr.151.2022.06.28.22.56.42; Tue, 28 Jun 2022 22:56:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Cm2qlKkc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230342AbiF2FrL (ORCPT + 99 others); Wed, 29 Jun 2022 01:47:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbiF2FrK (ORCPT ); Wed, 29 Jun 2022 01:47:10 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7A8B2A433; Tue, 28 Jun 2022 22:47:09 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id g10-20020a17090a708a00b001ea8aadd42bso14991268pjk.0; Tue, 28 Jun 2022 22:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1YBqdukEjmcQv4229s2jn5G+rP7f7kYpmmkX2BQayFQ=; b=Cm2qlKkcPAX17uChMiGkNj5GD8pHjiFoJp6wwR46AcK6mvymGFg5IGht7iK/xtDBod Dv8YDNo5V6s/IkXxQw9mGC8ZpmCVvoIX+c7hKaea1NJJOpevNvOd41l+N21y+g95pilf YIKKON+cLz5JAZT697UhSfArvWloBHo5B1pW0B9FNl16dEYgEZSDE6BsRieGp4Tfiz6w aqLAXgUrBJ6dBvQ/1HEnnamBy842bXFUcaK+qHEgURz6/Tznitbmn4EiVnf5bGsckZ3+ XqLoMVEvRygLvocKxBFj8OdC7oVteOxOl94Nq5MGSBOokNf6mI8dWvcM9hxEWVdQZrF0 QCUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1YBqdukEjmcQv4229s2jn5G+rP7f7kYpmmkX2BQayFQ=; b=7SxL7eHL54mJDQxI6m0CjTyzRjVniv1ko2Vqok8RXxw3jh/AXmMqCruvB1aCHKMc+S snvuQfqj7/ha4iH2X93v5vLQAj/718WcfPb4NA7Ms19y7VZ+oiIb6Lb4ZruBpLSHdwx3 4Vl1qoEi3Qj00CoWReGsoByI16e46XiocO5aIZWhj1xQlJvHdAtz7faBwYXmdT+DOSsU dpAhRc/A7VPn35SL8BbKMp6JCugKFgHWe27Hvth1iD4FezZRlXGqccZ+IJ/EX72hPiBP cltQ2cVplyjP7H4+W+HCOlfGcD85S+2H1u6RyP3XRIhfZbxEdjS967PZdqlPq1BDKxeB JjWg== X-Gm-Message-State: AJIora9J2pxIh8rozR7SgqkM6UeRKL54bIK2YOtlUgGGhA/b/GYO1rzl HB5sWJ4RR6ygZ6IrigdASgpfXXNRy9Q= X-Received: by 2002:a17:90b:2251:b0:1ed:29d2:e013 with SMTP id hk17-20020a17090b225100b001ed29d2e013mr3687819pjb.223.1656481628908; Tue, 28 Jun 2022 22:47:08 -0700 (PDT) Received: from google.com ([2620:15c:202:201:ff79:92cc:7905:3272]) by smtp.gmail.com with ESMTPSA id iz19-20020a170902ef9300b0016378bfeb90sm10382853plb.227.2022.06.28.22.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 22:47:07 -0700 (PDT) Date: Tue, 28 Jun 2022 22:47:05 -0700 From: Dmitry Torokhov To: Miaoqian Lin Cc: Lucas Stach , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: exc3000 - Fix return value check of wait_for_completion_timeout Message-ID: References: <20220411105828.22140-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220411105828.22140-1-linmq006@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 11, 2022 at 10:58:23AM +0000, Miaoqian Lin wrote: > wait_for_completion_timeout() returns unsigned long not int. > It returns 0 if timed out, and positive if completed. > The check for <= 0 is ambiguous and should be == 0 here > indicating timeout which is the only error case. > > Fixes: 102feb1ddfd0 ("Input: exc3000 - factor out vendor data request") > Signed-off-by: Miaoqian Lin Applied, thank you. -- Dmitry