Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0c6e33b7-9af1-842e-d1e6-38d685112848@amd.com>
Date:   Wed, 29 Jun 2022 08:57:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] drm/i915: Remove __dma_fence_is_chain()
Content-Language: en-US
To:     Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc:     intel-gfx@lists.freedesktop.org,
        Rob Clark <robdclark@chromium.org>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Matthew Auld <matthew.auld@intel.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= 
        <thomas.hellstrom@linux.intel.com>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:DMA BUFFER SHARING FRAMEWORK" 
        <linux-media@vger.kernel.org>,
        "moderated list:DMA BUFFER SHARING FRAMEWORK" 
        <linaro-mm-sig@lists.linaro.org>
References: <20220628233512.439555-1-robdclark@gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220628233512.439555-1-robdclark@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTJLTlVqZDJ1ZFRLa0hKcFFKbHFXZDNnbVF2TlJ4Q2ZOZEpRNUxvc0IzUG9z?=
 =?utf-8?B?TnpBa1NRREV1NElFMVlkV1dFdHR1WGpBQTF5d01vV2daK0ZBd3JlT21VUVhD?=
 =?utf-8?B?YXQ5YS9ISlBhNC8waThFS0VSNFQrNG9sTDAxYldxSk5UaUsvck9Da29IUWxy?=
 =?utf-8?B?Y21YWDRvT1VRdVVvL2pkS2lRVkJqcjRLKzBzUjR0dXgzUVVKd2pNcXFOL2J5?=
 =?utf-8?B?cEdGb2RzbGEzSFl5bERGTCtXaVVJSDludURaT2Z5Zm5FYnlQWnVoSmFxSzNr?=
 =?utf-8?B?SldsK2JSa251OTB6UUpuODdXM1NRVTRldVE2M2MrS2hPSUF1cWhHNGZpaC9z?=
 =?utf-8?B?dGtZRXREWGx3b1EyL3E0RnBrQ0o2bWFHa05lY09RdmxiMm9lVW5JZnVteWJq?=
 =?utf-8?B?MzJSUWRqRTFIUFN5L1RUS2E0QkY1c0pmeHVENEtmYkZ1QkxHemhYZEJNaWhk?=
 =?utf-8?B?d2t6MjNRMlB5TWJFN2poMTUvbmVsRHhTV1FPaEcxb0c4MXRuTktUOFZBT2F5?=
 =?utf-8?B?ZGgxTjR6Q0lQNE9HUHI0L3FkSFh2TGpvamN2dnlwM1NEd0hHTi9KZ2NicTJl?=
 =?utf-8?B?RkJHYzZqMDJMeTh1bnJPZ05YODM0WWFOQ3VIMXlYZkkzL2ZZdm5RS0ZNNkRt?=
 =?utf-8?B?aXZuYStlVjY1WGpadDRGUGpqOE9FR2ZORlhaejd3ZnhvdlozWDdQT3kxVnVH?=
 =?utf-8?B?YXlJUnFrTExlY3VGQjJnSklSbEJDS2h2ZnA0UXIrRVJHL29TZGc3WWQybi9v?=
 =?utf-8?B?U2locS9GUkY1cWN6bkVmQUsyUXVVOFBhMlNyRDdkMGxrRWlhdTF2V0ZvK0cy?=
 =?utf-8?B?QXVjM1E5bloyVk5JTnF3VUkyQmwyQjJZc1ZqMnRsU21PRU5zYllPVkdkR3hH?=
 =?utf-8?B?Q0lYWTZuNzg3bENhZk9EUFNjdFQyeVhvUUJhL1RPejd5aUlDaWVFek56aFpY?=
 =?utf-8?B?aXpDRWdYQTJXQUZwdzF3M2hGOElyTVY0eG1CK0hBb3RKUlArQVhubGkxb2xZ?=
 =?utf-8?B?RVRlN2loRkxabTNsLzFEQkxGL256Z0tISVBtMk9WNnc1eGQvUkRIaFVuc0JJ?=
 =?utf-8?B?OTBhQ1VUZjhyWjMyTnhkVFZuaVZLR3UrWmY0WTlqanc1MjhXRGN2VVU4eGo5?=
 =?utf-8?B?QkhaNUhYc2RDNXRuTFE4cHRqb3NhRkZiMStpZ0tXb3hiOU5NdTZnWXpoNmMr?=
 =?utf-8?B?cHo1MHBWajRnOW1HUUo5a0JPRkpKb2J2NGtnRUpKMEdVNkIxRDAydmFNcGNQ?=
 =?utf-8?B?UEl2ZFdVOG45OWhoNlduR3djeFdQbmU2SGlMSnJZZ3I5RlVwZnAvai9hT3Na?=
 =?utf-8?B?SEFQYUo0cnpSSjB4bFVSUXNNTTVBcG1qQnV5b1N3NWxqZ0hLMkFmV2pxZno3?=
 =?utf-8?B?K1NXR0QxNVdGbVJwa0hVMUUyMWp3M21FaVpJS0h2Mm5lSzBJNjFITkhPL3hq?=
 =?utf-8?B?WXo0MWJCME50WDcvSFcvY2xnbUgrdFJnRncyUEVoQWt4TFdpQkFuM3E2VHpN?=
 =?utf-8?B?MXRTbWtNdWg1Ui95cG5tblQ3aU9zWVdIWTlsRncrWGVVczJORUoydlp3a2lG?=
 =?utf-8?B?Y3lKaWFvR0ZLSG9yWGl2ZVRSeGo0NVpYdlUvMEZKNG1EV2tOVmNndG9YVnNZ?=
 =?utf-8?B?cFlXR3ppVTVvV3BGblpiT3lOcmR5RG1RQmtNMFhuREdVaTZha2F6bTdDTTk2?=
 =?utf-8?B?MzlFUmFhWFp2TjZMT1M5bVUzMHhCK21ldStzUUQrSEdRUFdreEdPcEhza1BB?=
 =?utf-8?B?MDdWV0gySStKZyt6TVUwQmJHMjdnWHBFd3JycEhUaWhQWmZPTEJESVY1NTdN?=
 =?utf-8?B?N0x0STZjNmZ5b09LckJwRmFzeU1PQm03MjBZTGIvZk1TZ3J2ZU41bndDbzBu?=
 =?utf-8?B?amlDRVprTmYxUW5Ma255bGVaVUFkbDZlalBRSlkvZ01UbGdIeENQdWJGRkxq?=
 =?utf-8?B?TGREcXF3TmVWdGp4aHNraFlaQU82N05oaDJCMVV5clFnL1VJVWV2RVpKNU5Z?=
 =?utf-8?B?YVhRYVVWRXZFejVpZWJBQjN3VlhZRjRVVis5YVNNeEFEcXdYQWN1Tzl3NzRR?=
 =?utf-8?B?NDdNamtwUkl4ZHVoNGtDbUwwK094b1AyZnhZZ0ViL1hyaGc3VzV4SXJsMFY2?=
 =?utf-8?B?UWROaUNocjhhaDcvUzM4UTU0R0RkdzN1UmQvbFNzbGRPcTJlV0RSc2JsUGhF?=
 =?utf-8?Q?6CbNFdNffL4NXJXksDhSawaJ2YY8QhPRpSvsZmdBvBFL?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bfb5701-068f-44a6-b0f5-08da599caba1
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2022 06:57:45.8585
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6GJuX+CSrhu45rn/M2MLDBeLwN/MbDwTSSJvhZ+EDlKaivUgPxqDNUsoKhH1haJ4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5840
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 29.06.22 um 01:35 schrieb Rob Clark:
> From: Rob Clark <robdclark@chromium.org>
>
> drive-by cleanup
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>

We should probably completely remove that dependency and rather use 
dma_fence_unwrap instead.

But that's probably for another patch Reviewed-by: Christian König 
<christian.koenig@amd.com>.

Christian.


> ---
>   drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> index 319936f91ac5..667841780514 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence,
>   	rcu_read_unlock();
>   }
>   
> -static inline bool __dma_fence_is_chain(const struct dma_fence *fence)
> -{
> -	return fence->ops == &dma_fence_chain_ops;
> -}
> -
>   void i915_gem_fence_wait_priority(struct dma_fence *fence,
>   				  const struct i915_sched_attr *attr)
>   {
> @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence,
>   
>   		for (i = 0; i < array->num_fences; i++)
>   			fence_set_priority(array->fences[i], attr);
> -	} else if (__dma_fence_is_chain(fence)) {
> +	} else if (dma_fence_is_chain(fence)) {
>   		struct dma_fence *iter;
>   
>   		/* The chain is ordered; if we boost the last, we boost all */