Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy
Reply-To: wangseok.lee@samsung.com
Sender: Wangseok Lee <wangseok.lee@samsung.com>
From:   Wangseok Lee <wangseok.lee@samsung.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzk+dt@kernel.org" <krzk+dt@kernel.org>,
        "kishon@ti.com" <kishon@ti.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jesper.nilsson@axis.com" <jesper.nilsson@axis.com>,
        "lars.persson@axis.com" <lars.persson@axis.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "kw@linux.com" <kw@linux.com>,
        "linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>,
        "kernel@axis.com" <kernel@axis.com>
CC:     Moon-Ki Jun <moonki.jun@samsung.com>,
        Sang Min Kim <hypmean.kim@samsung.com>,
        Dongjin Yang <dj76.yang@samsung.com>,
        Yeeun Kim <yeeun119.kim@samsung.com>
In-Reply-To: <20220620083821epcms2p57a65984523a0f2a3815e4873e8bfc6df@epcms2p5>
Message-ID: <20220629071829epcms2p65eab75702495a939f3f6e4ea020181de@epcms2p6>
Date:   Wed, 29 Jun 2022 16:18:29 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <20220620083821epcms2p57a65984523a0f2a3815e4873e8bfc6df@epcms2p5>
        <4b4b08af-887b-89e9-b4a5-93e7d8a03222@kernel.org>
        <20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p7>
        <20220614012916epcms2p5cf8d55e7420dea10bb4a05d91aaf99dd@epcms2p5>
        <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p6>
Precedence: bulk

Just a gentle ping for this patch, if any concern on this patch please let =
me know.


On=C2=A020/06/2022=C2=A017:38,=C2=A0Wangseok=C2=A0Lee=C2=A0wrote:=0D=0A>=20=
On=C2=A017/06/2022=C2=A007:59,=C2=A0Krzysztof=C2=A0Kozlowski=C2=A0wrote:=0D=
=0A>>=C2=A0On=C2=A013/06/2022=C2=A018:29,=C2=A0Wangseok=C2=A0Lee=C2=A0wrote=
:=0D=0A>>>=C2=A0Signed-off-by:=C2=A0Wangseok=C2=A0Lee=C2=A0<wangseok.lee=40=
samsung.com>=0D=0A>>>=C2=A0---=0D=0A>>>=C2=A0v2->v3=C2=A0:=0D=0A>>>=C2=A0-m=
odify=C2=A0version=C2=A0history=C2=A0to=C2=A0fit=C2=A0the=C2=A0linux=C2=A0c=
ommit=C2=A0rule=0D=0A>>>=C2=A0-remove=C2=A0'Device=C2=A0Tree=C2=A0Bindings'=
=C2=A0on=C2=A0title=0D=0A>>>=C2=A0-remove=C2=A0clock-names=C2=A0entries=0D=
=0A>>>=C2=A0-change=C2=A0node=C2=A0name=C2=A0to=C2=A0soc=C2=A0from=C2=A0art=
pec8=C2=A0on=C2=A0excamples=0D=0A>>>=C2=A0=0D=0A>>>=C2=A0v1->v2=C2=A0:=0D=
=0A>>>=C2=A0-'make=C2=A0dt_binding_check'=C2=A0result=C2=A0improvement=0D=
=0A>>>=C2=A0-Add=C2=A0the=C2=A0missing=C2=A0property=C2=A0list=0D=0A>>>=C2=
=A0-Align=C2=A0the=C2=A0indentation=C2=A0of=C2=A0continued=C2=A0lines/entri=
es=0D=0A>>>=C2=A0---=0D=0A>>>=C2=A0=C2=A0.../bindings/phy/axis,artpec8-pcie=
-phy.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=7C=C2=A073=C2=A0+=
+++++++++++++++++++++=0D=0A>>>=C2=A0=C2=A01=C2=A0file=C2=A0changed,=C2=A073=
=C2=A0insertions(+)=0D=0A>>>=C2=A0=C2=A0create=C2=A0mode=C2=A0100644=C2=A0D=
ocumentation/devicetree/bindings/phy/axis,artpec8-pcie-phy.yaml=0D=0A>>>=C2=
=A0=0D=0A>>>=C2=A0diff=C2=A0--git=C2=A0a/Documentation/devicetree/bindings/=
phy/axis,artpec8-pcie-phy.yaml=C2=A0b/Documentation/devicetree/bindings/phy=
/axis,artpec8-pcie-phy.yaml=0D=0A>>>=C2=A0new=C2=A0file=C2=A0mode=C2=A01006=
44=0D=0A>>>=C2=A0index=C2=A00000000..316b774=0D=0A>>>=C2=A0---=C2=A0/dev/nu=
ll=0D=0A>>>=C2=A0+++=C2=A0b/Documentation/devicetree/bindings/phy/axis,artp=
ec8-pcie-phy.yaml=0D=0A>>>=C2=A0=40=40=C2=A0-0,0=C2=A0+1,73=C2=A0=40=40=0D=
=0A>>>=C2=A0+=23=C2=A0SPDX-License-Identifier:=C2=A0GPL-2.0-only=C2=A0OR=C2=
=A0BSD-2-Clause=0D=0A>>>=C2=A0+%YAML=C2=A01.2=0D=0A>>>=C2=A0+---=0D=0A>>>=
=C2=A0+=24id:=C2=A0https://protect2.fireeye.com/v1/url?k=3D84f6a8c0-e57dbdd=
9-84f7238f-74fe485cbfec-e81bd79bfd1ff442&q=3D1&e=3D6739af06-730c-48db-aef8-=
026a9aaee1b4&u=3Dhttp%3A%2F%2Fdevicetree.org%2Fschemas%2Fphy%2Faxis%2Cartpe=
c8-pcie-phy.yaml%23=0D=0A>>>=C2=A0+=24schema:=C2=A0https://protect2.fireeye=
.com/v1/url?k=3Db4f1a4ba-d57ab1a3-b4f02ff5-74fe485cbfec-7f885cbe82dc7860&q=
=3D1&e=3D6739af06-730c-48db-aef8-026a9aaee1b4&u=3Dhttp%3A%2F%2Fdevicetree.o=
rg%2Fmeta-schemas%2Fcore.yaml%23=0D=0A>>>=C2=A0+=0D=0A>>>=C2=A0+title:=C2=
=A0ARTPEC-8=C2=A0SoC=C2=A0PCIe=C2=A0PHY=0D=0A>>>=C2=A0+=0D=0A>>>=C2=A0+main=
tainers:=0D=0A>>>=C2=A0+=C2=A0=C2=A0-=C2=A0Jesper=C2=A0Nilsson=C2=A0<jesper=
.nilsson=40axis.com>=0D=0A>>>=C2=A0+=0D=0A>>>=C2=A0+properties:=0D=0A>>>=C2=
=A0+=C2=A0=C2=A0compatible:=0D=0A>>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0const:=
=C2=A0axis,artpec8-pcie-phy=0D=0A>>>=C2=A0+=0D=0A>>>=C2=A0+=C2=A0=C2=A0reg:=
=0D=0A>>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0items:=0D=0A>>>=C2=A0+=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0-=C2=A0description:=C2=A0PHY=C2=A0registers.=0D=0A>=
>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-=C2=A0description:=C2=A0PHY=
=C2=A0coding=C2=A0sublayer=C2=A0registers.=0D=0A>>>=C2=A0+=0D=0A>>>=C2=A0+=
=C2=A0=C2=A0reg-names:=0D=0A>>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0items:=0D=0A>=
>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-=C2=A0const:=C2=A0phy=0D=0A>>=
>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-=C2=A0const:=C2=A0pcs=0D=0A>>>=
=C2=A0+=0D=0A>>>=C2=A0+=C2=A0=C2=A0=22=23phy-cells=22:=0D=0A>>>=C2=A0+=C2=
=A0=C2=A0=C2=A0=C2=A0const:=C2=A00=0D=0A>>>=C2=A0+=0D=0A>>>=C2=A0+=C2=A0=C2=
=A0clocks:=0D=0A>>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0items:=0D=0A>>>=C2=A0+=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-=C2=A0description:=C2=A0PCIe=C2=A0PHY=C2=
=A0reference=C2=A0clock=0D=0A>=20=0D=0A>=20refer=C2=A0to=C2=A0sample-schema=
.yaml,=C2=A0even=C2=A0if=C2=A0the=C2=A0clock=C2=A0item=C2=A0is=C2=A0single,=
=0D=0A>=20it=C2=A0seems=C2=A0to=C2=A0be=C2=A0used=C2=A0as=C2=A0follows.=0D=
=0A>=20=0D=0A>=20clocks:=0D=0A>=20=C2=A0=C2=A0maxItems:=C2=A01=0D=0A>=20=0D=
=0A>=20clock-names:=0D=0A>=20=C2=A0=C2=A0items:=0D=0A>=20=C2=A0=C2=A0=C2=A0=
=C2=A0-=C2=A0const:=C2=A0ref=0D=0A>=20=0D=0A>=20If=C2=A0only=C2=A0=22clocks=
:=22=C2=A0are=C2=A0define=C2=A0and=C2=A0clock-names=C2=A0are=C2=A0not=C2=A0=
define,=0D=0A>=20the=C2=A0following=C2=A0warning=C2=A0occurs.=0D=0A>=20=22'=
clock-names'=C2=A0does=C2=A0not=C2=A0match=C2=A0any=C2=A0of=C2=A0the=C2=A0r=
egexes=22=0D=0A>=20=0D=0A>>>=C2=A0+=0D=0A>>>=C2=A0+=C2=A0=C2=A0num-lanes:=
=0D=0A>>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0const:=C2=A02=0D=0A>>>=C2=A0+=0D=0A=
>>>=C2=A0+=C2=A0=C2=A0lcpll-ref-clk:=0D=0A>>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=
=A0const:=C2=A01=0D=0A>>=C2=A0=0D=0A>>=C2=A0Unknown=C2=A0field...=C2=A0cust=
om=C2=A0properties=C2=A0need=C2=A0vendor=C2=A0(axis,),=C2=A0type=C2=A0(bool=
ean)=0D=0A>>=C2=A0and=C2=A0description.=0D=0A>>=C2=A0=0D=0A>=20=0D=0A>=20=
=22lcpl-ref-clk=22=C2=A0has=C2=A0an=C2=A0enum=C2=A0type=C2=A0value,=C2=A0so=
=C2=A0i=C2=A0will=C2=A0modify=C2=A0it=C2=A0as=C2=A0below.=0D=0A>=20=0D=0A>=
=20=0D=0A>=20axis,lcpll-ref-clk:=0D=0A>=20=C2=A0=C2=A0description:=0D=0A>=
=20=C2=A0=C2=A0=C2=A0=C2=A0select=C2=A0the=C2=A0reference=C2=A0clock=C2=A0o=
f=C2=A0phy=C2=A0and=C2=A0initialization=C2=A0is=C2=A0performed=0D=0A>=20=C2=
=A0=C2=A0=C2=A0=C2=A0with=C2=A0the=C2=A0reference=C2=A0clock=C2=A0according=
=C2=A0to=C2=A0the=C2=A0selected=C2=A0value.=0D=0A>=20=C2=A0=C2=A0=24ref:=C2=
=A0/schemas/types.yaml=23/definitions/uint32=0D=0A>=20=C2=A0=C2=A0enum:=C2=
=A0=5B=C2=A00,=C2=A01,=C2=A02,=C2=A03,=C2=A04=C2=A0=5D=0D=0A>=20=0D=0A>>>=
=C2=A0+=0D=0A>>>=C2=A0+required:=0D=0A>>>=C2=A0+=C2=A0=C2=A0-=C2=A0compatib=
le=0D=0A>>>=C2=A0+=C2=A0=C2=A0-=C2=A0reg=0D=0A>>>=C2=A0+=C2=A0=C2=A0-=C2=A0=
reg-names=0D=0A>>>=C2=A0+=C2=A0=C2=A0-=C2=A0=22=23phy-cells=22=0D=0A>>>=C2=
=A0+=C2=A0=C2=A0-=C2=A0clocks=0D=0A>>>=C2=A0+=C2=A0=C2=A0-=C2=A0clock-names=
=0D=0A>>>=C2=A0+=C2=A0=C2=A0-=C2=A0samsung,fsys-sysreg=0D=0A>>=C2=A0=0D=0A>=
>=C2=A0Same=C2=A0problem=C2=A0as=C2=A0in=C2=A0patch=C2=A0=231.=0D=0A>>=C2=
=A0=0D=0A>=20=0D=0A>=20I=C2=A0will=C2=A0add=C2=A0the=C2=A0following=C2=A0it=
ems=C2=A0to=C2=A0the=C2=A0property.=0D=0A>=20=0D=0A>=20samsung,fsys-sysreg:=
=0D=0A>=20=C2=A0=C2=A0description:=0D=0A>=20=C2=A0=C2=A0=C2=A0=C2=A0Phandle=
=C2=A0to=C2=A0system=C2=A0register=C2=A0of=C2=A0fsys=C2=A0block.=0D=0A>=20=
=C2=A0=C2=A0=24ref:=C2=A0/schemas/types.yaml=23/definitions/phandle=0D=0A>=
=20=0D=0A>>>=C2=A0+=C2=A0=C2=A0-=C2=A0num-lanes=0D=0A>>>=C2=A0+=C2=A0=C2=A0=
-=C2=A0lcpll-ref-clk=0D=0A>>>=C2=A0+=0D=0A>>>=C2=A0+additionalProperties:=
=C2=A0true=0D=0A>>=C2=A0=0D=0A>>=C2=A0No,=C2=A0this=C2=A0must=C2=A0be=C2=A0=
false.=0D=0A>>=C2=A0=0D=0A>=20=0D=0A>=20yes,=C2=A0i=C2=A0miss=C2=A0it.=C2=
=A0I=C2=A0will=C2=A0fix=C2=A0this.=0D=0A>=20=0D=0A>>=C2=A0Best=C2=A0regards=
,=0D=0A>>=C2=A0Krzysztof=0D=0A>=20=0D=0A>=20Thank=C2=A0you=C2=A0for=C2=A0ki=
ndness=C2=A0reivew.=0D=0A>=20=0D=0A>=20Best=C2=A0regards,=0D=0A>=20Wangseok=
=C2=A0Lee