Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7a78b7d0-fe02-4efe-cfbb-5a4a1b5b2f91@huawei.com>
Date:   Wed, 29 Jun 2022 08:41:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings
To:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>
CC:     <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1656335540-50293-1-git-send-email-john.garry@huawei.com>
 <16f727b8-c3b0-c828-0c5b-6728a6e7934f@opensource.wdc.com>
 <9044b81f-76db-75de-db74-f45d6e5ea71e@omp.ru>
 <d26b8345-02e9-e461-c506-b429c44f74df@omp.ru>
From:   John Garry <john.garry@huawei.com>
In-Reply-To: <d26b8345-02e9-e461-c506-b429c44f74df@omp.ru>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 28/06/2022 19:39, Sergey Shtylyov wrote:
> On 6/28/22 1:05 PM, Sergey Shtylyov wrote:
> [...]
>>>> x86_64 allmodconfig build with W=1 gives these warnings:
>>>>
>>>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_piomode’:
>>>> drivers/ata/pata_cs5535.c:93:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>>>>    u32 reg, dummy;
>>>>             ^~~~~
>>>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_dmamode’:
>>>> drivers/ata/pata_cs5535.c:132:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>>>>    u32 reg, dummy;
>>>>             ^~~~~
>>>> cc1: all warnings being treated as errors
>>>>
>>>> Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is
>>>> stubbed, which is the same as what we already do in pata_cs5536.c .
> 
>     Wait, what do you mean by "stubbed", the version in <asm/paravirt.h>?

Ah, this mentioning of stubbed is wrong on my part. I was distracted by 
the stub in pata_cs5536.c - that's what my text editor showed me for the 
defintion of rdmsr()

Hi Damien,

I see that you applied this patch. If it has not been pushed can we hand 
edit the commit message or I can send a v2? Or maybe we can live with it...

Thanks,
John

> 
>>>>
>>>> Signed-off-by: John Garry <john.garry@huawei.com>
>>
>> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> 
> [...]
> 
> MBR, Sergey
> .