Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220625130637.223180f2@jic23-huawei>
References: <20220625103853.2470346-1-marcus.folkesson@gmail.com> <20220625103853.2470346-4-marcus.folkesson@gmail.com> <20220625125652.2f988964@jic23-huawei> <20220625130637.223180f2@jic23-huawei>
Subject: Re: [PATCH v2 04/10] iio: adc: mcp3911: add support for interrupts
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Kent Gustavsson <kent@minoris.se>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
To:     Jonathan Cameron <jic23@kernel.org>,
        Marcus Folkesson <marcus.folkesson@gmail.com>
Date:   Wed, 29 Jun 2022 00:44:09 -0700
User-Agent: alot/0.10
Message-Id: <20220629074411.BB82EC3411E@smtp.kernel.org>
Precedence: bulk

Quoting Jonathan Cameron (2022-06-25 05:06:37)
> > > @@ -362,6 +401,32 @@ static int mcp3911_probe(struct spi_device *spi)
> > > =20
> > >     mutex_init(&adc->lock);
> > > =20
> > > +   if (spi->irq > 0) {
> > > +           adc->trig =3D devm_iio_trigger_alloc(&spi->dev, "%s-dev%d=
",
> > > +                           indio_dev->name,
> > > +                           iio_device_id(indio_dev));
> > > +           if (!adc->trig)
> > > +                   goto clk_disable; =20
> > You definitely want to use devm managed cleanup for these.
> >=20
> > There is a patch set that adds these as standard functions, but I haven=
't
> > yet seen it being picked up for this cycle (reviews have been slow comi=
ng).
> >=20
> > https://lore.kernel.org/all/20220520075737.758761-1-u.kleine-koenig@pen=
gutronix.de/
>=20
> Ah, elsewhere in my unread email was a thread that says it's in clk-next =
so
> will be in the next merge window.  I haven't confirmed, but looks like St=
ephen
> put up an immutable branch so I could pull it into the IIO togreg branch =
if you
> want to transition directly to that new code. @Stephen, would you be fine
> with me pulling your clk-devm-enable branch into IIO (with the fix which
> got posted earlier in the week presumably also going on that branch when
> you push out?)

Yes that's fine. Thanks for the heads up.