Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: fNSacY3jdiDZVwwrKppnERU5tSZWv214LAbLxg9DPSLu8CmhqqDxfqmiV0/t2pLVm0apUW8NiY
 kMktBdJSuTiD5qkzAiZwWqgmIyBbW7ZQBAHKd2LCuc4ya3uMLLcWLcrRHFJeqGwvhRcG9408SZ
 51MNBWiWH5NrsyEp3IBCu8vySTswQn3JGRGJLOXtJuGGRfhunNMH/VF+ZlHOaADXYt2s0y5Qwi
 P1fiMaGlwIrPpaGhvGdappeCVxS2W0iFJTDcRKv0PUefMetM0gWPjUiNLd416Ta3l7x9nsQGZH
 Ppq+y4GtKw6k7xqxpARAlaP7
IronPort-SDR: bjb8iKd4yNj6QL7k/51QvzoTEcgVfX5uhu1iuhJO46UGZO43JGqIeyFW341XPaeafoGkZ6T87P
 QXBElGU7y9pWw/oAgS6/AVgeWePW9bBn4psdFPU+ag4w9G3aLK6gSKgLgkiq7hS3OhuWsdrn/H
 +dLV1RAo3MQ2tOWP1/l6JFsLGKBpZOeeHGcmTtR57MTphcLf/Pa/LsKGgxDxVYGviYk/dDQnie
 7MUpvJmpH3JdvzG0WgeanKaoPPF/rntRRQp/DcgoLBDpgKIZuYKNq5T4IQJ93duxI6hG5ujVQ3
 VFU=
WDCIronportException: Internal
Message-ID: <eb3bc00d-f0c7-57eb-cd7b-cf4243999c31@opensource.wdc.com>
Date:   Wed, 29 Jun 2022 17:24:14 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>,
        Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1656335540-50293-1-git-send-email-john.garry@huawei.com>
 <16f727b8-c3b0-c828-0c5b-6728a6e7934f@opensource.wdc.com>
 <9044b81f-76db-75de-db74-f45d6e5ea71e@omp.ru>
 <d26b8345-02e9-e461-c506-b429c44f74df@omp.ru>
 <7a78b7d0-fe02-4efe-cfbb-5a4a1b5b2f91@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <7a78b7d0-fe02-4efe-cfbb-5a4a1b5b2f91@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 6/29/22 16:41, John Garry wrote:
> On 28/06/2022 19:39, Sergey Shtylyov wrote:
>> On 6/28/22 1:05 PM, Sergey Shtylyov wrote:
>> [...]
>>>>> x86_64 allmodconfig build with W=3D1 gives these warnings:
>>>>>
>>>>> drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_piomode=E2=
=80=99:
>>>>> drivers/ata/pata_cs5535.c:93:11: error: variable =E2=80=98dummy=E2=80=
=99 set but not used [-Werror=3Dunused-but-set-variable]
>>>>>    u32 reg, dummy;
>>>>>             ^~~~~
>>>>> drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_dmamode=E2=
=80=99:
>>>>> drivers/ata/pata_cs5535.c:132:11: error: variable =E2=80=98dummy=E2=
=80=99 set but not used [-Werror=3Dunused-but-set-variable]
>>>>>    u32 reg, dummy;
>>>>>             ^~~~~
>>>>> cc1: all warnings being treated as errors
>>>>>
>>>>> Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is
>>>>> stubbed, which is the same as what we already do in pata_cs5536.c .
>>
>>     Wait, what do you mean by "stubbed", the version in <asm/paravirt.=
h>?
>=20
> Ah, this mentioning of stubbed is wrong on my part. I was distracted by=
=20
> the stub in pata_cs5536.c - that's what my text editor showed me for th=
e=20
> defintion of rdmsr()
>=20
> Hi Damien,
>=20
> I see that you applied this patch. If it has not been pushed can we han=
d=20
> edit the commit message or I can send a v2? Or maybe we can live with i=
t...

Send me an updated commit message and I will amend.

>=20
> Thanks,
> John
>=20
>>
>>>>>
>>>>> Signed-off-by: John Garry <john.garry@huawei.com>
>>>
>>> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>
>> [...]
>>
>> MBR, Sergey
>> .
>=20


--=20
Damien Le Moal
Western Digital Research