Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1656466861-7737-1-git-send-email-u0084500@gmail.com> <618f0794-429c-705d-ab4c-84aace6aaaaa@collabora.com>
In-Reply-To: <618f0794-429c-705d-ab4c-84aace6aaaaa@collabora.com>
From:   ChiYuan Huang <u0084500@gmail.com>
Date:   Wed, 29 Jun 2022 17:02:57 +0800
Message-ID: <CADiBU3-DO0tQhEC9f+p06kDFZsk8vDVu_H74PWKSLrBaW5zB5g@mail.gmail.com>
Subject: Re: [PATCH 1/2] regulator: mt6370: Use 'fwnode_gpiod_get_index' to
 fix gpio parsing
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        chiaen_wu@richtek.com, alice_chen@richtek.com,
        lkml <linux-kernel@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        ChiYuan Huang <cy_huang@richtek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> =E6=96=
=BC
2022=E5=B9=B46=E6=9C=8829=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=884:2=
3=E5=AF=AB=E9=81=93=EF=BC=9A
>
> Il 29/06/22 03:41, cy_huang ha scritto:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > From the common binding, 'enable-gpio' or 'enable-gpios' are all well
> > for external 'enable' gpio.
> >
> > 'gpiod_get_from_of_node' only parse the 'enable' property, it need to
> > add the gpio suffix. It's more convenient to use fwnode_gpiod_get_index=
.
> > Although fwnode parsing is not preferred, but 'of_parse_cb' already can
> > guarantee the callback will only be used by regulator of_node parsing.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> >   drivers/regulator/mt6370-regulator.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/regulator/mt6370-regulator.c b/drivers/regulator/m=
t6370-regulator.c
> > index bc356b4..949b2c7 100644
> > --- a/drivers/regulator/mt6370-regulator.c
> > +++ b/drivers/regulator/mt6370-regulator.c
> > @@ -153,7 +153,8 @@ static int mt6370_of_parse_cb(struct device_node *n=
p,
> >       struct gpio_desc *enable_gpio;
> >       int ret;
> >
> > -     enable_gpio =3D gpiod_get_from_of_node(np, "enable", 0, GPIOD_OUT=
_HIGH |
> > +     enable_gpio =3D fwnode_gpiod_get_index(of_fwnode_handle(np), "ena=
ble", 0,
>
> Since this driver is never calling gpiod_put(), you can even fix that in =
one shot.
>
> Just use devm_fwnode_gpiod_get() here, as it's guaranteed that priv->dev =
is
> initialized at this time.
>
Refer to the regulator framework,it will take over the gpio_desc.
You cannot use devm version for 'gpiod_get'.
> Cheers,
> Angelo
>
>