Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <321d069a-0db3-6abd-c25e-4da46f361bd7@gmail.com>
Date:   Wed, 29 Jun 2022 15:44:29 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v2] Documentation: kunit: Cleanup run_wrapper, fix x-ref
Content-Language: en-US
To:     David Gow <davidgow@google.com>,
        Daniel Latypov <dlatypov@google.com>,
        Brendan Higgins <brendanhiggins@google.com>,
        Shuah Khan <skhan@linuxfoundation.org>
Cc:     kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>
References: <20220626101553.1885428-1-davidgow@google.com>
 <20220629040605.2395481-1-davidgow@google.com>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <20220629040605.2395481-1-davidgow@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/29/22 11:06, David Gow wrote:
> +This means that for most architectures, running under qemu is as simple as:
> +
> +.. code-block:: bash
> +
> +	./tools/testing/kunit/kunit.py run --arch=x86_64
> +
> +When cross-compiling, we'll likely need to specify a different toolchain, for
> +example:
> +
> +.. code-block:: bash
> +
> +	./tools/testing/kunit/kunit.py run \
> +		--arch=s390 \
> +		--cross_compile=s390x-linux-gnu-
> +

nit: s/we'll/you'll/

Otherwise looks OK.

-- 
An old man doll... just what I always wanted! - Clara