Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4b2b3a2b-fdc0-a684-d4b1-9725e5b87ccb@gmx.de>
Date:   Wed, 29 Jun 2022 11:20:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v6 5/9] tpm, tpm_tis: Only handle supported interrupts
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
Cc:     peterhuewe@gmx.de, jgg@ziepe.ca, stefanb@linux.vnet.ibm.com,
        linux@mniewoehner.de, linux-integrity@vger.kernel.org,
        linux-kernel@vger.kernel.org, l.sanfilippo@kunbus.com,
        lukas@wunner.de, p.rosenberger@kunbus.com
References: <20220621132447.16281-1-LinoSanfilippo@gmx.de>
 <20220621132447.16281-6-LinoSanfilippo@gmx.de> <Yrf/azvJlzWfOE9y@kernel.org>
 <6b950660-6a78-f329-39b4-11d585e4959c@gmx.de> <Yro4tl7g1IqkEszT@kernel.org>
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
In-Reply-To: <Yro4tl7g1IqkEszT@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 28.06.22 01:09, Jarkko Sakkinen wrote:
> On Sun, Jun 26, 2022 at 02:18:17PM +0200, Lino Sanfilippo wrote:
>> On 26.06.22 at 08:40, Jarkko Sakkinen wrote:
>>>
>>> I would instead mask out bits and write a helper function
>>> taking care of this:
>>>
>>> static u8 tpm_tis_filter_sts_mask(u8 int_mask, u8 sts_mask)
>>> {
>>>         struct tpm_tis_data *priv =3D dev_get_drvdata(&chip->dev);
>>>
>>>         if (!(int_mask & TPM_INTF_STS_VALID_INT))
>>>                 sts_mask &=3D ~TPM_STS_VALID;
>>>
>>>         if (!(int_mask & TPM_INTF_DATA_AVAIL_INT))
>>>                 sts_mask &=3D ~TPM_STS_DATA_AVAIL;
>>>
>>>         if (!(int_mask & TPM_INTF_CMD_READY_INT))
>>> 		sts_mask &=3D ~TPM_STS_COMMAND_READY;
>>>
>>>         return sts_mask;
>>> }
>>>
>>> Less operations and imho somewhat cleaner structure.
>>>
>>> Add suggested-by if you want.
>>
>> I thought of a helper like this before but then decided to
>> not introduce another function to keep the code changes minimal. But ye=
s,
>> it is indeed cleaner. I will do the change and resubmit the series.
>>
>> Thanks for the review!
>>
>> Regards,
>> Lino
>
> Yeah, please don't add suggested-by, it's such a minor detail
> in the overall patch :-)

I already created a separate patch which only contains moving the bit chec=
ks into the
helper function. For that patch the Suggested-by is fully justified IMHO.


Thanks for taking time to fix these
> glitches and also taking all the feedback into account (and
> also being patient).
>

No problem. Its always good to have some feedback from people that have a =
deeper insight
into the code. Especially when it is as complex as the TPM subsystem and d=
rivers.

Best regards,
Lino