Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220628193906.36350-1-andriy.shevchenko@linux.intel.com>
 <20220628193906.36350-3-andriy.shevchenko@linux.intel.com> <SJ0PR03MB6253C3D92FFF37717D48C7618EBB9@SJ0PR03MB6253.namprd03.prod.outlook.com>
In-Reply-To: <SJ0PR03MB6253C3D92FFF37717D48C7618EBB9@SJ0PR03MB6253.namprd03.prod.outlook.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 29 Jun 2022 11:59:31 +0200
Message-ID: <CAHp75VfR6XwW1HZDKoxhxs0i9R6s=uim1-dTtwJeXrA9AGWGQA@mail.gmail.com>
Subject: Re: [PATCH v1 3/3] gpio: adp5588: sort header inclusion alphabetically
To:     "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Sa, Nuno" <Nuno.Sa@analog.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jun 29, 2022 at 10:50 AM Hennerich, Michael
<Michael.Hennerich@analog.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Dienstag, 28. Juni 2022 21:39
> > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux-
> > gpio@vger.kernel.org; linux-kernel@vger.kernel.org
> > Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Linus Walleij
> > <linus.walleij@linaro.org>; Bartosz Golaszewski <brgl@bgdev.pl>
> > Subject: [PATCH v1 3/3] gpio: adp5588: sort header inclusion alphabetically
> >
> > Sort header inclusion alphabetically.
>
> Thanks for the patches, they look good.
> However, Nuno is currently working on getting the irqchip support into the
> adp5588 input driver. In his patch series this driver is going away.
>
> https://lore.kernel.org/linux-input/YpMCh1Xje+jsny8j@google.com/

While that work is ongoing, and most likely won't make v5.20-rc1, for
the v5.20-rc1 I think my patches are good to go to avoid a bad (or
rather very old) example on how to do GPIO drivers. What do you think?

-- 
With Best Regards,
Andy Shevchenko