Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: rgj8N5KJHh5t2dLf18UqO56/fiHCLj6R+A1ePOPSYVJWnJacsDrBZGwwrQfy38Ar+hgd9iKEVb
 umBjJ2psRaco9eA+maqaGxft+pjhnUyHhwweJymgeS43n8uu0vnvARfHEkBk2TJ9iSjVZEaSlj
 RBijUXGSpBX/ynH77JRZEZ+I7TLfAfO3CDLwmsygcPIUgAM+vBDz4EkkvnnRsePcu3vKbSW4Ir
 4bi8ECzJWj8/E/trxkJPC2QMwVSv4B6Q9+AaoaGdWCDva8/TGEWShJysi2Wd2/d0RmEFCXXJiH
 k4NcCZek2kpWBYFBYniur5Jn
IronPort-SDR: ZulOvm7cYqhqkdCfznEaEXHg1YCidxdP1CGmQLVgp/sfB4AwD4a4unfTZGz/sv3OZFlWFqw5K/
 Fu1xQWA5e36bHM/4QfKyG+XJjuY6s+40aZWPkVYHMW1HQvvpopvkdl5iVRY9Jg5SQP5GUfmm9n
 G3N1c23hFaJ+2xyuVGT+Mr0XCEbZP5Y8Iq/YFa7lbp4TSPwNk/IfDDTovjBaaU/pfNX7XyBYxO
 /bHd9dw2tmISXcMrf7Nf5tFJ19+FeIpppUI1LyTlKKEvSP2oM79PLv5uQq3YSDafD0f9TATTxK
 kqQ=
WDCIronportException: Internal
Message-ID: <8227ef6a-665f-d16c-e5e4-6e04e2e6ee45@opensource.wdc.com>
Date:   Wed, 29 Jun 2022 20:18:40 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v2] ata: pata_cs5535: Fix W=1 warnings
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, s.shtylyov@omp.ru
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1656494324-101603-1-git-send-email-john.garry@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1656494324-101603-1-git-send-email-john.garry@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 6/29/22 18:18, John Garry wrote:
> x86_64 allmodconfig build with W=3D1 gives these warnings:
>=20
> drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_piomode=E2=80=
=99:
> drivers/ata/pata_cs5535.c:93:11: error: variable =E2=80=98dummy=E2=80=99=
 set but not used [-Werror=3Dunused-but-set-variable]
>   u32 reg, dummy;
>            ^~~~~
> drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_dmamode=E2=80=
=99:
> drivers/ata/pata_cs5535.c:132:11: error: variable =E2=80=98dummy=E2=80=99=
 set but not used [-Werror=3Dunused-but-set-variable]
>   u32 reg, dummy;
>            ^~~~~
> cc1: all warnings being treated as errors
>=20
> Mark variables 'dummy' as "maybe unused" as they are only ever written =
in
> rdmsr() calls.
>=20
> Signed-off-by: John Garry <john.garry@huawei.com>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

Updated for-5.20. Thanks !

> ---
> Differences to v1:
> - Add RB tag (thanks!)
> - Fix commit message
>=20
> diff --git a/drivers/ata/pata_cs5535.c b/drivers/ata/pata_cs5535.c
> index 6725931f3c35..c2c3238ff84b 100644
> --- a/drivers/ata/pata_cs5535.c
> +++ b/drivers/ata/pata_cs5535.c
> @@ -90,7 +90,7 @@ static void cs5535_set_piomode(struct ata_port *ap, s=
truct ata_device *adev)
>  	static const u16 pio_cmd_timings[5] =3D {
>  		0xF7F4, 0x53F3, 0x13F1, 0x5131, 0x1131
>  	};
> -	u32 reg, dummy;
> +	u32 reg, __maybe_unused dummy;
>  	struct ata_device *pair =3D ata_dev_pair(adev);
> =20
>  	int mode =3D adev->pio_mode - XFER_PIO_0;
> @@ -129,7 +129,7 @@ static void cs5535_set_dmamode(struct ata_port *ap,=
 struct ata_device *adev)
>  	static const u32 mwdma_timings[3] =3D {
>  		0x7F0FFFF3, 0x7F035352, 0x7F024241
>  	};
> -	u32 reg, dummy;
> +	u32 reg, __maybe_unused dummy;
>  	int mode =3D adev->dma_mode;
> =20
>  	rdmsr(ATAC_CH0D0_DMA + 2 * adev->devno, reg, dummy);


--=20
Damien Le Moal
Western Digital Research