Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad7626bd-bcbb-48fc-5e32-bc95fafcb917@nokia.com>
Date:   Wed, 29 Jun 2022 14:47:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v2 03/10] i2c: xiic: Switch to Xiic standard mode for
 i2c-read
Content-Language: en-US
To:     Raviteja Narayanam <raviteja.narayanam@xilinx.com>,
        linux-i2c@vger.kernel.org, michal.simek@xilinx.com
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        git@xilinx.com, marex@denx.de, joe@perches.com
References: <20210626102806.15402-1-raviteja.narayanam@xilinx.com>
 <20210626102806.15402-4-raviteja.narayanam@xilinx.com>
From:   Krzysztof Adamski <krzysztof.adamski@nokia.com>
In-Reply-To: <20210626102806.15402-4-raviteja.narayanam@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWlLNWlKMmFWcTRMUnRldEhYb2pPV0w1V3pEUTFvazhiTWlka2JPT3g1TSsw?=
 =?utf-8?B?SzlSUUJBTnRNM3JiODhLZFByVzRqWnpIaWNOSHAxQUJHNk5GS0lVWGtlaFJY?=
 =?utf-8?B?dEFqR1ZGM1I1aVJkNFM3b1hVanprbzU4aXpMd1BTVGllL2x5NFJGUVJOMWxt?=
 =?utf-8?B?U09TNm5hYnI4Y0tuenpQTU5RNkpONTdIRVM3eGFyR1BhZDRJQS9qTjNtTnE1?=
 =?utf-8?B?SzBJV2JUZnRDQklNQWRudEU1WDZZeVBUOElaS1NRajIrQUduMDBKSUhxYUZD?=
 =?utf-8?B?L01POEFKelFWUjhCYi9oQUtpRWx3WlFIMUtRZm1Na2g1bFNEcXBZSDZDNTdv?=
 =?utf-8?B?MGFqV3lNTnRSQzErL3hVam4zMWtwWlFLbEcwMVl3Skw5Qm90Q0lQYzBCeWo0?=
 =?utf-8?B?SHNkbXlSeFB0dEtqUFVlTUQyMWxQZUNIZTMvS2tURGV4cXc4ZlRSQ2lMVS9q?=
 =?utf-8?B?TkZsN0l5STJMeFpBQlRtUHQwRjZkaE1ldDhEcEd6RDBnQ01kN1RtblVzY2M4?=
 =?utf-8?B?S2tJOGxDbGRTRmhLOGVVcWFPOTVZY1k5NlhhTkJZeVU5aXFYV0dSdjh4eWZG?=
 =?utf-8?B?RmRuWXZiOEQzNk5YaVU4cVJLYktGSG1BNGpQSTFNSERnY2pWR1N0M3hraFov?=
 =?utf-8?B?RkkwejJUelFaYU5HVnU4UllqM0p2VnRsMmpCd2lmbDNpRW9lQXphdlc3Q3c3?=
 =?utf-8?B?SGovaEJxWHUxcyszMmgwdy96Q2JZQWk3UVRUSnNhbkFhQ2hXcVhFN20zTitz?=
 =?utf-8?B?SGs0cElrZlE3OG1VbitMNVlScjJlWlBXcXZvY3UrQmxhbVZnQnBrbUx2QzVJ?=
 =?utf-8?B?QUtOd0laU0E3eXFtS1pwYjh5TmFkZW5vMW9QdVp0RFFwNTBYZ1RzblhTdlRq?=
 =?utf-8?B?KzY1MnZWVWtXZmRxM3RaZHR0c0xIV2Q3RHBJSDhYc05LS3BTSUdzV1k4YzM0?=
 =?utf-8?B?YTBtclZVS09xZUNMOWpkMWhPRXIrYWt5alJ4QjlkUHBHaHhzc1diUVdSeURD?=
 =?utf-8?B?Y0dnSEY5OTRPbDFnN0R4RDl1cmRobk1RSXo1YWFyVG0wOVNOQm1iU3lrUGh1?=
 =?utf-8?B?ZUFFZmpRdlh3VmxYdlZ3VHkvTWRyUWpkaXlFbGlPQ2lJM0VKUEF3RDVWZjdq?=
 =?utf-8?B?UUxoY3JFSkZPNEl4Zlo1RER0S0JUWE9salZkWEpyMHBscmNScUZEWFo5cXlq?=
 =?utf-8?B?SUNqRUpHa2RmT3JuVDJKYk44ejlxSG03V1pYeDFWaU94Wk5KM2l5cFV0UGEy?=
 =?utf-8?B?c0tYOU1mcDd4QWFMUWdzbmlHUzAwU01OcGQxN2RXeW53LytxM0cwZ3ZKNkpH?=
 =?utf-8?B?ZUVVdEhKaGM0aThiMWpwTEtJTXRKZEt4UkIvVSt2Mk5EM0k5RHlYUkFUL1A2?=
 =?utf-8?B?Z0MxL1UyOEltRjJwK29rOU5udjY2ZVU0Z3BhSHViemd0c3JNbEVWSGJtckU0?=
 =?utf-8?B?ZkR3YlJqQy9YYjg2UE9GRTNOOFN0OElkVE5nQm5mTmxma1A3NzdlUnZnQ283?=
 =?utf-8?B?R09ucW55bUZoSXYyNHZLWGJ4VUNyeWFVMjQvRE5DWnpqbHFlRFZLSzJ0Y2ho?=
 =?utf-8?B?ZkpWVlVaTWxqZzFaWEJ1NG81MkY4c0d4U2Z0cEVLbktVNHRqbHZ2WTYvbU1L?=
 =?utf-8?B?V2RkNTd3d3p6SkhkNStLMFJlSXJSR0VnVS9hazdlNW9lbUNOVkJEdmtxVVZF?=
 =?utf-8?B?dXVhSTlBRUlTNkZqaWhXZWhTU1lsdDZBMTNoUjEvUC96eVFhRUpWM1FTYXBJ?=
 =?utf-8?B?YjBsbFFEMHJtU0VRNWs3T09jbm5lM3dkM0tNWEhLSjhJOXNjdlJvbXozKzNN?=
 =?utf-8?B?bStoUXhRcE45T3JGL2ZuZ2JVTUt4Q1N4c0t5blFlV2FCWE1zeVpCOU81WDNI?=
 =?utf-8?B?SG0xSHBTSmMyQ1V4QXdqWTBmRXAyWE1iKzFESWtVK1JYdFp3OUVpM05WVUhC?=
 =?utf-8?B?c0l2UUtyK3NHTkFmbndhbjR5d0JKbHpsV3ZZcThVOGpuUmJOYlZyU3d0S1Jt?=
 =?utf-8?B?VmtGaGxuK1V4VzZPcTZzb3p0eE16OE5obkFEemRhUjVGc3A2Y2Y1UzJ6T2RI?=
 =?utf-8?B?MzJsVXJFbVY5VzJWYklBY1ZvNGZzNmdJMHdqdy9pRVVXaUFYNDJUUWYwU2VB?=
 =?utf-8?B?UERBNE4vcHVoSGFoalhNM1lWR2xpSzFGS01DdXNUZVVRa2NFWGZUY1ZiUFNG?=
 =?utf-8?B?Q2c9PQ==?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0246c780-13f9-40ff-004b-08da59cd8dd8
X-MS-Exchange-CrossTenant-AuthSource: DU2PR07MB8110.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2022 12:47:41.1757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l4kka2TAWxTtsQRj980agKxzkUHXRb0pS8P9Gnylf4hAOsl87xMzn8F3lcSwa05CpkN0VCCh/xFGGG5hFgkBA1UqI9VWaeMym3iRwW6HqqY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB4532
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

W dniu 26.06.2021 o 12:27, Raviteja Narayanam pisze:
> Xilinx I2C IP has two modes of operation, both of which implement
> I2C transactions. The only difference from sw perspective is the
> programming sequence for these modes.
> Dynamic mode  -> Simple to program, less number of steps in sequence.
> Standard mode -> Gives flexibility, more number of steps in sequence.
>
> In dynamic mode, during the i2c-read transactions, if there is a
> delay(> 200us) between the register writes (address & byte count),
> read transaction fails. On a system with load, this scenario is
> occurring frequently.
> To avoid this, switch to standard mode if there is a read request.
>
> Added a quirk to identify the IP version effected by this and follow
> the standard mode.
>
> Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com>

[...]

If those two modes only differ in software complexity but we are not
able to support only the simpler one and we have support for the more
complicated (standard mode) anyways, we know that standard mode
can handle or the cases while dynamic mode cannot, we also know that
dynamic mode is broken on some versions of the core, why do we actually
keep support for dynamic mode?

Krzysztof