Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp622775iog; Wed, 29 Jun 2022 07:05:21 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s9SNi28YZuVeNljREfYssWflLfQvJE1/H8dd7YcUsRAkTlYS/piQSEWXDZm8lTmzG7e1Vw X-Received: by 2002:a05:6402:5001:b0:437:8918:8dbe with SMTP id p1-20020a056402500100b0043789188dbemr4424084eda.70.1656511521295; Wed, 29 Jun 2022 07:05:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656511521; cv=none; d=google.com; s=arc-20160816; b=nyJkX8Lq4cpIrDVeIJx8YnptSxd/z6mKlk0xlKOMlSAwQwlYCKqm+k2b/PY906nAtx pu6j45RVAMR8FbnAGQPiftvKeeXLFneWtlLaKmSCs+bnnqx/B9VQXuOiDbVEsRkmOddi KanJ3N6CFhHVnHP9EW61dy1vhURqXFBurtRJ5Ls15djvjR1rJzJ88W2FkdHJTBRflwmS LQCVteYqy+86oLUakUNSaf+6hiocLfXpHoFIw0vTDkVEFjmKWXcaUD5K1Ga0k3fF9OKs nFb6bgr31dCk9MnOwf5XmhYNOMOkMjdntMLdBkd1HCnVVi+ztsGkZ1/itUBvCcgnosKC kxaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1nfA4bd39uY9wmMuXeUB/WuKXARluBCBaMbOeIYcBnY=; b=DT0bRkYUflTWQrhHf5MZE9vS72MwadeGEijB6bDSEoSVhHfQQ9+3VG1ifecyx+ZtYo R5ht74PHg3e+jrF2gSV1liCDLNl4/RzGqOleXSbPd8O6869ZmCQKWBqwzGqhLddqQdSg F55WjqsMt3L6Qlf5HNdEbxz9HYMvMHJ0EXze44bsRRC2wbJ7W6BrV7CDTB9/2vvJhYYt r6FAU9w+wYALLvwlPEtJIDlgUxh9xmcvM92FzjgWmkMIsqiyCxGzFidRtTy45QnVkAAi PnYUPUiYpzO6eXJ69X9eqSIE5hrg7n/FrMZE5R9f/6/KqOUveOCyV+0N+xSzQcelmhdV Ybeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=LRK5ezlY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y93-20020a50bb66000000b0043568e1bfe0si19722740ede.273.2022.06.29.07.04.53; Wed, 29 Jun 2022 07:05:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=LRK5ezlY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232730AbiF2OBc (ORCPT + 99 others); Wed, 29 Jun 2022 10:01:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbiF2OB3 (ORCPT ); Wed, 29 Jun 2022 10:01:29 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFB0B23141; Wed, 29 Jun 2022 07:01:25 -0700 (PDT) Received: from zn.tnic (p200300ea97156ae0329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9715:6ae0:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AF6A31EC04C2; Wed, 29 Jun 2022 16:01:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1656511279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=1nfA4bd39uY9wmMuXeUB/WuKXARluBCBaMbOeIYcBnY=; b=LRK5ezlYQtIou/WwjqaCHEkzUwF537MTzAq2lHavZu/AFBFt05GjuZvi60LPc/HaFKAxzq 8gWqVL7Mu26tnpybnyjQJEPDCModDkJIdXd2axk+QkTaTDn2Byx0on7m3eWcQgCLlHow8m WLyN6KMa6BsOQrx4FEIgjDu5NbaXcMM= Date: Wed, 29 Jun 2022 16:01:15 +0200 From: Borislav Petkov To: Jonathan McDowell Cc: kernel test robot , "llvm@lists.linux.dev" , "kbuild-all@lists.01.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , Mimi Zohar , Baoquan He , "devicetree@vger.kernel.org" , "linux-integrity@vger.kernel.org" , "kexec@lists.infradead.org" Subject: Re: [PATCH] of: Correctly annotate IMA kexec buffer functions Message-ID: References: <202206291039.yGgljGbx-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 29, 2022 at 09:52:50AM +0000, Jonathan McDowell wrote: > Below is on top of what was in tip; I can roll a v7 if preferred but > I think seeing the fix on its own is clearer. Yes, and you don't have to base it on top because, as I've said, I've zapped your other patch there. Once IMA folks are fine with that fix of yours I can take both, if they wish so. > ima_free_kexec_buffer() calls into memblock_phys_free() so must be > annotated __meminit. Why __meminit? The very sparse comment over it says: /* Used for MEMORY_HOTPLUG */ #define __meminit __section(".meminit.text") __cold notrace \ __latent_entropy so how does ima_free_kexec_buffer() have anything to do with MEMORY_HOTPLUG? It calls memblock_phys_free() which is __init_memblock. Now __init_memblock is defined as #define __init_memblock __meminit for some CONFIG_ARCH_KEEP_MEMBLOCK thing so I guess that is the connection. But then the couple other functions which call into memblock are all __init... IOW, I probably am missing something... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette