Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Jun 2022 14:13:53 +0100
Message-ID: <87tu831ujy.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Jianmin Lv <lvjianmin@loongson.cn>
Cc:     Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
        Hanjun Guo <guohanjun@huawei.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [PATCH V13 09/13] irqchip/loongson-liointc: Add ACPI init support
In-Reply-To: <1656329997-20524-10-git-send-email-lvjianmin@loongson.cn>
References: <1656329997-20524-1-git-send-email-lvjianmin@loongson.cn>
        <1656329997-20524-10-git-send-email-lvjianmin@loongson.cn>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 27 Jun 2022 12:39:53 +0100,
Jianmin Lv <lvjianmin@loongson.cn> wrote:
>=20
> From: Huacai Chen <chenhuacai@loongson.cn>
>=20
> We are preparing to add new Loongson (based on LoongArch, not compatible
> with old MIPS-based Loongson) support. LoongArch use ACPI other than DT
> as its boot protocol, so add ACPI init support.
>=20
> LIOINTC stands for "Legacy I/O Interrupts" that described in Section
> 11.1 of "Loongson 3A5000 Processor Reference Manual". For more
> information please refer Documentation/loongarch/irq-chip-model.rst.

This is what happens with this series while compiling for MIPS:

drivers/irqchip/irq-loongson-liointc.c: In function =E2=80=98liointc_domain=
_xlate=E2=80=99:
drivers/irqchip/irq-loongson-liointc.c:170:28: error: =E2=80=98GSI_MIN_CPU_=
IRQ=E2=80=99 undeclared (first use in this function)
  170 |  *out_hwirq =3D intspec[0] - GSI_MIN_CPU_IRQ;
      |                            ^~~~~~~~~~~~~~~

I haven't bothered reviewing more patches, as this is a waste of my
time.

	M.

--=20
Without deviation from the norm, progress is not possible.