Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762504AbXE1Kaj (ORCPT ); Mon, 28 May 2007 06:30:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753464AbXE1KaU (ORCPT ); Mon, 28 May 2007 06:30:20 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:58240 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751288AbXE1KaS (ORCPT ); Mon, 28 May 2007 06:30:18 -0400 Date: Mon, 28 May 2007 12:30:11 +0200 From: Pavel Machek To: "Rafael J. Wysocki" Cc: LKML , Andrew Morton , Gautham R Shenoy , Linus Torvalds , Nigel Cunningham , Oleg Nesterov , Maximilian Engelhardt , Herbert Xu Subject: Re: [RFC][PATCH][EXPERIMENTAL] Make kernel threads nonfreezable by default Message-ID: <20070528103011.GC18807@elf.ucw.cz> References: <200705270012.59177.rjw@sisk.pl> <200705281009.06685.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705281009.06685.rjw@sisk.pl> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1785 Lines: 36 Hi! > > This patch is on top of the "Freezer: Avoid freezing kernel threads prematurely" > > patch that I posted yestarday, available at http://lkml.org/lkml/2007/5/25/199 > > (updated version that applies cleanly on top of 2.6.22-rc3, is available at > > http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc3/patches/07-freezer-avoid-freezing-kernel-threads-prematurely.patch). > > It has been tested on a couple of machines and doesn't seem to break anything. > > > > [As you can see there are quite a lot of files affected, so I didn't add all > > maintainers of them to the CC list. In fact, I'm not sure how to handle > > notifying them of the change, so please advise.] > > Does the lack of comments mean that everyone on the CC list agrees with this > approach? ;-) > > In the meantime, it turns out that this patch fixes the hibernation/suspend > problem with cryptd discussed in the thread at > http://lkml.org/lkml/2007/5/26/24 . > > The problem is that cryptd doesn't call try_to_freeze() and doesn't set > PF_NOFREEZE for itself, so the freezer cannot handle it properly. In principle > we can add either try_to_freeze() or the setting of PF_NOFREEZE to it, but if > the approach in the $subject patch is acceptable, we'll need to remove that > soon. So, what should we do? I'd add PF_NONFREEZE. Changing the defaults in freezer is obviously not 2.6.22 material. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/