Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4768f72e-6c23-b2ac-d446-b69ded9c19a1@kernel.dk>
Date:   Wed, 29 Jun 2022 08:46:11 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] io_uring: fix a typo in comment
Content-Language: en-US
To:     korantwork@gmail.com, asml.silence@gmail.com
Cc:     io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xinghui Li <korantli@tencent.com>
References: <20220629144301.9308-1-korantwork@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20220629144301.9308-1-korantwork@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/29/22 8:43 AM, korantwork@gmail.com wrote:
> From: Xinghui Li <korantli@tencent.com>
> 
> fix a typo in comment in io_allocate_scq_urings.
> sane -> same.
> 
> Signed-off-by: Xinghui Li <korantli@tencent.com>
> ---
>  fs/io_uring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index d3ee4fc532fa..af17adf3fa79 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -12284,7 +12284,7 @@ static __cold int io_allocate_scq_urings(struct io_ring_ctx *ctx,
>  	struct io_rings *rings;
>  	size_t size, sq_array_offset;
>  
> -	/* make sure these are sane, as we already accounted them */
> +	/* make sure these are same, as we already accounted them */
>  	ctx->sq_entries = p->sq_entries;
>  	ctx->cq_entries = p->cq_entries;

That's not really a typo, though I can see why you'd think so. It's
trying to say that we need to ensure that the ctx entries are sane,
as they have already been accounted. This means that if we teardown
past this point, they need to be assigned (eg sane) so that we undo
that accounting appropriately.


-- 
Jens Axboe