Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Date:   Wed, 29 Jun 2022 10:35:35 -0500
From:   Michael Roth <michael.roth@amd.com>
To:     NOMURA =?utf-8?B?SlVOSUNISSjph47mnZHjgIDmt7PkuIAp?= 
        <junichi.nomura@nec.com>
CC:     Borislav Petkov <bp@alien8.de>,
        LKML <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [Regression v5.19-rc1] crash kexec fails to boot the 2nd kernel
 (Re: [PATCH v12 38/46] x86/sev: Add SEV-SNP feature detection/setup)
Message-ID: <20220629153535.ivrp2x6j74cnpsv7@amd.com>
References: <TYCPR01MB694815CD815E98945F63C99183B49@TYCPR01MB6948.jpnprd01.prod.outlook.com>
 <20220629004114.zn5rurrmqdkiceun@amd.com>
 <OSZPR01MB6953EEF3F8E63330547E031183BB9@OSZPR01MB6953.jpnprd01.prod.outlook.com>
 <YrwLS8qRDhjmeD5Z@zn.tnic>
 <TYCPR01MB6948029FAACBC313063EE49283BB9@TYCPR01MB6948.jpnprd01.prod.outlook.com>
 <20220629135254.cicvyp5clm4s4n35@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220629135254.cicvyp5clm4s4n35@amd.com>
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2022 15:35:52.1109
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 88c63ee9-b8e5-4a83-972a-08da59e50cb4
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4336
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 29, 2022 at 08:52:54AM -0500, Michael Roth wrote:
> 
> So the runtime kernel relies on boot/compressed for handling EFI, and
> simply uses boot_params to pass that on to runtime kernel.
> 
> But it has its own handling for cc_blob passed via setup_data entry,
> because that entry point is meant for boot loaders / VMMs that use stuff
> like CONFIG_PVH to jump directly into decompressed kernel: those are the
> cases where we'd expect cc blob via setup_data entry. But this is a
> critical thing to support right now, and if we can't find a proper fix
> we can simply disable this patch and not check for setup_data entry in
> runtime kernel.

Sorry for the confusing typos:

I meant to say that this (setup_data-based cc blob for decompressed kernel)
*isn't* a critical thing to support right now, and disabling that boot
path is certainly an option if that ends up being necessary.

But I do think the boot/compressed issue with how it doesn't map setup_data
entries into identity map should be fixed either way, as it seems like a
latent issue that snp_init() just happens to be the first to trigger.