Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp727394iog; Wed, 29 Jun 2022 09:01:22 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vAynMVDu1+Af23DnofaAC/XlOhKm3zYbBY3XhQBPpMPdVZODqnLdxAFc/IlxOW+A2sPVar X-Received: by 2002:a17:902:efc4:b0:16a:133a:b20d with SMTP id ja4-20020a170902efc400b0016a133ab20dmr10745439plb.45.1656518481681; Wed, 29 Jun 2022 09:01:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656518481; cv=none; d=google.com; s=arc-20160816; b=J+DnVyX/6/x60p1zOl7VoHjNNVUKAr3nlhe0bChd77dP4jvJ2iDlsq9tE9mic8V5zJ xy6Agn+yw4M9CtnrGkieaa22aJlsVLxv2AnZgrxl1QlYko6vQzr+Svo70GAKLO0nocl4 Ggzs0hGmO8IQ/mrX1Djii0KIw1/G361TCv6n1IX01g5EsbWNrT4xoz65q3t171kI8fKE J0ssFxZSBqVw04VP1lMIK2839Gz3NS+ZIXE5k3YfzW+hoFivDioBJGOqMrVDUv1n0xej g89o82JU9iujAlezDSWIAQ/K3x1M86f6abjipQFn63jTgzIh1LtDhED9YRYxlLpnaNM1 OZBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uSOri9mbcMgpIWkWuaM9zGldT1kq+1V/jX4MBhk9B5w=; b=gMGA74459EQjvrQCV7gSoawcVgRF4RQYj/LgYsc19b2z+dYrP9rLxWjCrCEco3C0Ol HojX24W/RXUPPrLdbD42bj1eM3NbaM2kLlqfP2OUKAWrGa2s00XFgjvVBbFu0fRPl9Y9 0a1cSJlQz2eMXls2jvBAUYhAxCb9hGrAVgBlPJwlGXYxlSntLbB8eMZvMqJlDi/opWqJ 3yYLQVx2ktjj+cMi7uqJEthj+9yeGLeTYH2ipuruoqQmo01EegUMaCOGjp3C7bBeAmM1 oTlC7g1saoUAF8oUkh8MiH0HyvaH8QpP+IMh9Nqj6WqaY5FNqCSmazTW7/NWTU5zc+2Z gB1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pv37R9NP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p8-20020a170902b08800b0016a57bbd34esi22063374plr.412.2022.06.29.09.01.05; Wed, 29 Jun 2022 09:01:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pv37R9NP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233701AbiF2PCd (ORCPT + 99 others); Wed, 29 Jun 2022 11:02:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231531AbiF2PCb (ORCPT ); Wed, 29 Jun 2022 11:02:31 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F31E1E3EC for ; Wed, 29 Jun 2022 08:02:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 154F3B824F6 for ; Wed, 29 Jun 2022 15:02:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DE84C341C8; Wed, 29 Jun 2022 15:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656514948; bh=YrW0MclUMyY6HcWXjSnuuUFbvlixqKQGRTLyrIyuaNw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pv37R9NP3xjH54c2qAdGqhH0HdmWOME93RcwiKVRzc5Fp9XVH7wL8ynWDb03uSjhz OTSpIzqZGIpqPRHSEqyv66o679VemE0pL06v/QS6jLnbua/06ux9/QArO7nAOa6W6H nQ+PThkNL2P6Y28zO5td1v+t4zqssiWFPqQowauXh1u28O9eiLj1hXtL71IhgmbtW4 /dr/7MpJbYA49tTmBqB+dD8uBrOo0Vfsz1l9hs0zcxn5swV9xkvs6rhNq5Dr61Q/zj FaYmXsLr/Ikz23Afr8paaprehEjSfytBYI4yD+xkEwpphAPnZM5xq50A/3dw8CY42y WyLeDh1+Iqglw== Date: Wed, 29 Jun 2022 16:02:24 +0100 From: Mark Brown To: Srinivas Kandagatla Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ASoC: codecs: wsa883x: add control, dapm widgets and map Message-ID: References: <20220629145831.77868-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CQe+J6NOIs3++col" Content-Disposition: inline In-Reply-To: <20220629145831.77868-1-srinivas.kandagatla@linaro.org> X-Cookie: Booths for two or more. X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CQe+J6NOIs3++col Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 29, 2022 at 03:58:31PM +0100, Srinivas Kandagatla wrote: > +static const char * const wsa_dev_mode_text[] = { > + "speaker", "receiver", "ultrasound" Idiomatically these would be capitalised ("Speaker" and so on). Sorry, didn't notice on v1. Otherwise this looks good. --CQe+J6NOIs3++col Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmK8aX8ACgkQJNaLcl1U h9B68Af+OSwqjG2mYULXNLPfUr5eNb4DI+Y6bHPZFcuyEnRugPAEnGTHmOSj1ysS q2GQrCsTJTm8dByTkopi1uIHgetJIy9vb7rItZqE2GK8BHb3Ne2KUxKL3XkX7g5C +OSchkZVjHjDuwJ4NPmTLWUrpFbQcMrCnrM3+pWhFNqLE69mg8DioAaer1wWjBEd E+6piqi8E1AyQlV+sOGe94sUXWVP/REM6wEKOKd90SMXSs87XYLbOb179k6YkSyy iO2qgO1aif6QYJcNm4NdprDvwnXEEcP6s/PAqsEfqoQ8mggt0EHfBRZ4ri0Cn8mz DETkg0CsWMM8gEHA16POeG5NImOVOw== =jykd -----END PGP SIGNATURE----- --CQe+J6NOIs3++col--