Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
        "claudiu.beznea@microchip.com" <claudiu.beznea@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "git (AMD-Xilinx)" <git@amd.com>,
        "Katakam, Harini" <harini.katakam@amd.com>
Subject: RE: [PATCH net-next] net: macb: In shared MDIO usecase make MDIO
 producer ethernet node to probe first
Thread-Topic: [PATCH net-next] net: macb: In shared MDIO usecase make MDIO
 producer ethernet node to probe first
Thread-Index: AQHYixosiAZkkNvB0EuYIDQYxYOPY61l1moAgACrUYA=
Date:   Wed, 29 Jun 2022 15:24:55 +0000
Message-ID: <MN0PR12MB5953872B976C38C430166DECB7BB9@MN0PR12MB5953.namprd12.prod.outlook.com>
References: <1656439734-632-1-git-send-email-radhey.shyam.pandey@amd.com>
 <20220628220846.25025a22@kernel.org>
In-Reply-To: <20220628220846.25025a22@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QVa3XNZvGKgFWFJjjENbQb2qeLMc61QLbFonAveTOTftfHu0z7+E7lavfF0E?=
 =?us-ascii?Q?2qKw/etr7v71FD1ZHnLgjUwPp46rAABJBJa54gPn39cRC9NnnmybC4/S93Lu?=
 =?us-ascii?Q?jtGpGLH210z+W3seAl4sR7symtYhWU8U4KMPHU+IxAzLtYEJngiHxfmwhZc/?=
 =?us-ascii?Q?d5VcbDhZ8SDhYWPe2kAyqbnnLfAmCERYDUYnfKAya9rluf5y4UqjLwvXSR1l?=
 =?us-ascii?Q?JfzDMyoUMN6uWsTsV04j6FWwo/6OgVvnMZpHASrY2qmoR59YtC757D8KePyM?=
 =?us-ascii?Q?pJX/h9agJR9pwoDDz0VHe/NehSc+1dgPj9HAw5UVasjWhWgIH55Y8tmS5cRJ?=
 =?us-ascii?Q?WNcGmWGTlIpBdkx17XGzsQrhfuBI2cHjIBgP3BibFDRVrljMHbqUSIR8rUb5?=
 =?us-ascii?Q?SrPcs0tmeHlmu/ErukuulRFx7QWhook7x6vnnmX42/5p9k644SmaqPg4dGRQ?=
 =?us-ascii?Q?D5QwAJQXGO1SwdYih3HpOisYQbwnmRZLw7TB2QWhDAza4xLeuwHw2DZ0aDRz?=
 =?us-ascii?Q?7QXUC+qnbYYDOB1P1d0yWuKr8c9PLlAzjMOCClV497b0F+eP7CwRXzBtmBiZ?=
 =?us-ascii?Q?ovdcVbbxUu3j3RngyLdxzuEpVCjiPhlDyAcCbEdUMWbRj0gWcZUHe8ZVxvwW?=
 =?us-ascii?Q?rz7NA52EOVGb+VWKjWcCeFgL1KddkIXKFA7NkvuLAHhsrXRY5tQccfx5meJp?=
 =?us-ascii?Q?T/U1WfehEBXtU81zkSwrTrZFmvKIahSxN/yJGASp9U6ymmImscTSU6O4lg6L?=
 =?us-ascii?Q?2E6tiel/kJU8ZW+MO2dTV6fJ4aSmrsn5uWKru+LjpBIOSY3Am8ljmD9kBRnT?=
 =?us-ascii?Q?7vJp/tzmF936EjQ2vqKLHdzCrXX+NysvHRakX+oktIT898KNpa6dnwTkzt8G?=
 =?us-ascii?Q?hne3YRB0cbZ8Ul9Ls2KIOPD9Qwi2/Bt1GKD1cWUlv572OicUneF1MVW+3ZwB?=
 =?us-ascii?Q?QDkxsu67Wrzxl29rVFoK2FVbyqyW7gOyiuO782ycBhb1TQl8U3CzUOxYvYg2?=
 =?us-ascii?Q?Zbte3d+bDgywOWk9LouF58TjcJBpbmDYqTxKw0y4AMfDjgq5RJrPZ5i5mpP9?=
 =?us-ascii?Q?VokfRU4ZUFXkjMBTv0k8WMKefEMI4AREjn6P3vpn1vUW18z0r8hqpDJAlxL5?=
 =?us-ascii?Q?RGcznZoRe/zvRNPUiLAtrKF5BHxNWd515wrZDm2QjhhsjSOjsSxaeRWwwWzy?=
 =?us-ascii?Q?X/Oxd5CCCSvwdFjwONdb8euzWq0wWwnwBNcjrOaF0pQbkCgcv/YLRk2AUWwa?=
 =?us-ascii?Q?sBBuBrzs0qJQF4LQk815FuAGhw+phSIpGwFNboHXi8uh9UiA7v6uR/UQqe39?=
 =?us-ascii?Q?Pg+QzZXBj1eknUZ8u/7lRLxBgjMi5fqTt3OuaRRAXcX6hQ5r8S3agFMoa4Ye?=
 =?us-ascii?Q?400ljwEGGeD1a4CF8Y4WFKzw0U/vTqoFqpDeCDvulgglmPGAyGSfX46mrlPN?=
 =?us-ascii?Q?ewQNxdtbqLwLRv9PioIA7Uq9FVzM+pD6NfzA4shw7xHCLvF5OWpf5rBkEmWn?=
 =?us-ascii?Q?diMfYW7k5XjIYzPV9vdcSmhWvdGYNzuEIKfsN6LyDhFz0jV7pbMmXvJg3IRI?=
 =?us-ascii?Q?tzKrCXFNOtLJPGLqlcI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5953.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 904880c8-35ff-45f7-85c3-08da59e38587
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2022 15:24:55.8889
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DOw/7LaYggrYCKnohFjlPjeCA3VeIYWsfWVKtdAosCKxBtzZrloktvLtblNK+Ivy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2857
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Wednesday, June 29, 2022 10:39 AM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> Cc: nicolas.ferre@microchip.com; claudiu.beznea@microchip.com;
> davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; git (AMD-Xilinx)
> <git@amd.com>; Katakam, Harini <harini.katakam@amd.com>
> Subject: Re: [PATCH net-next] net: macb: In shared MDIO usecase make MDIO
> producer ethernet node to probe first
>=20
> On Tue, 28 Jun 2022 23:38:54 +0530 Radhey Shyam Pandey wrote:
> > In shared MDIO suspend/resume usecase for ex. with MDIO producer
> > (0xff0c0000) eth1 and MDIO consumer(0xff0b0000) eth0 there is a
> > constraint that ethernet interface(ff0c0000) MDIO bus producer has to
> > be resumed before the consumer ethernet interface(ff0b0000).
>=20
> ERROR: modpost: "device_is_bound" [drivers/net/ethernet/cadence/macb.ko]
> undefined!
> make[2]: *** [../scripts/Makefile.modpost:128: modules-only.symvers] Erro=
r 1
> make[1]: *** [/home/nipa/net-next/Makefile:1757: modules] Error 2
> make: *** [Makefile:219: __sub-make] Error 2

Oh, I could also see this error when making it a module compilation.
I will fix it in v2. As an alternative to device_is_bound() i think we=20
can check the presence of drvdata. Similar approach i see it in ongoing
onboard_usb_hub driver series[1]. Does it look ok?/any other suggestions?

-       if (mdio_pdev && !device_is_bound(&mdio_pdev->dev))=20
+       if (mdio_pdev && !dev_get_drvdata(&mdio_pdev->dev))=20

[1]: https://lore.kernel.org/all/20220622144857.v23.2.I7c9a1f1d6ced41dd8310=
e8a03da666a32364e790@changeid/
Listed in v21 changes.

Please let me know if there is any other feedback on the
shared MDIO dependency implementation.

Thanks,
Radhey