Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220628104650.2239191-1-hsinyi@chromium.org>
In-Reply-To: <20220628104650.2239191-1-hsinyi@chromium.org>
From:   Hsin-Yi Wang <hsinyi@chromium.org>
Date:   Thu, 30 Jun 2022 00:08:51 +0800
Message-ID: <CAJMQK-j6VMBrt+31ozUw7V50SFn-PXQWtO1jq+b05TTCNToiAg@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge: anx7625: use pm_runtime_force_suspend(resume)
To:     Robert Foss <robert.foss@linaro.org>, Xin Ji <xji@analogixsemi.com>
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sam Ravnborg <sam@ravnborg.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Maxime Ripard <maxime@cerno.tech>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 28, 2022 at 6:46 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> There's no need to check for IRQ or disable it in suspend.
>
> Use pm_runtime_force_suspend(resume) to make sure anx7625 is powered off
> correctly. Make the system suspend/resume and pm runtime suspend/resume
> more consistant.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
The patch is re-sent again with other anx7625 patches in this series:
https://lore.kernel.org/lkml/20220629160550.433980-1-hsinyi@chromium.org/


>  drivers/gpu/drm/bridge/analogix/anx7625.c | 33 ++---------------------
>  1 file changed, 2 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 3710fa9ee0acd..09688a1076037 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2542,38 +2542,9 @@ static int __maybe_unused anx7625_runtime_pm_resume(struct device *dev)
>         return 0;
>  }
>
> -static int __maybe_unused anx7625_resume(struct device *dev)
> -{
> -       struct anx7625_data *ctx = dev_get_drvdata(dev);
> -
> -       if (!ctx->pdata.intp_irq)
> -               return 0;
> -
> -       if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) {
> -               enable_irq(ctx->pdata.intp_irq);
> -               anx7625_runtime_pm_resume(dev);
> -       }
> -
> -       return 0;
> -}
> -
> -static int __maybe_unused anx7625_suspend(struct device *dev)
> -{
> -       struct anx7625_data *ctx = dev_get_drvdata(dev);
> -
> -       if (!ctx->pdata.intp_irq)
> -               return 0;
> -
> -       if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) {
> -               anx7625_runtime_pm_suspend(dev);
> -               disable_irq(ctx->pdata.intp_irq);
> -       }
> -
> -       return 0;
> -}
> -
>  static const struct dev_pm_ops anx7625_pm_ops = {
> -       SET_SYSTEM_SLEEP_PM_OPS(anx7625_suspend, anx7625_resume)
> +       SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> +                               pm_runtime_force_resume)
>         SET_RUNTIME_PM_OPS(anx7625_runtime_pm_suspend,
>                            anx7625_runtime_pm_resume, NULL)
>  };
> --
> 2.37.0.rc0.161.g10f37bed90-goog
>