Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp767456iog; Wed, 29 Jun 2022 09:46:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vCCavA7Xm7QHvknzkC1rficwXfY7aMxXIIS6ogu4bOpS8CtsZ6KAIxo+Q8DuVPZhpbTtcy X-Received: by 2002:a17:90b:2316:b0:1ec:7b32:55bd with SMTP id mt22-20020a17090b231600b001ec7b3255bdmr6739518pjb.217.1656521167388; Wed, 29 Jun 2022 09:46:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656521167; cv=none; d=google.com; s=arc-20160816; b=A+O+T12j5r6+XCMkiXhZ2oqUfkU9PllsvkogkzUHM1AeZl35+uDnS5md8aVWD6s9j7 aujcSAAbDinFsOKl03CCfRZBmfy/UytmLfR9Ur5IJZ82GFTs0IwKcR40dA8FnYxAXtSP aAFYZxjZGD+LKGOOI+jwRL6Od5Bu8XKtOLbOFUfCCz83MBhEvoRjww6nJvaQcn1dwZKF JhwX41HECLsJJVEh8t+HLv9hPRv92cQfIttR6VG3MMPd07qo1rpmyjO2JnZrP1l+pJv4 P/jcSsWRArGYHEWH+S/vmYQznC/YAMrydQYgr1DRyz34kp35PibH2v4AGoepHz2NAW9h XK6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=+qRQoDDTV8BF8wEA9fqb2+RGr9qlZhA4mDUIzEc3aXI=; b=tYyONp5t+KzKo7kpBHDHcwfU0xS2ufo2uhdLlYmmoLOKhWYLG+3OrUDSbPnnd4SE/J sux8PKCu5pc4WJjXNEgYpWSyVqOjEUYcpu3ZqXYEobCKmgP7261NnRtiqHCMDQu5xG21 DnVcPyfg2T/xi+x3eRyT4CEEJumIQRD4Hl5q2ssandim2/Dkrg8/6qAlqPbfrWBKzzcH VlWUKyeH3q7bkDPKLc9tKiKnim9whpoBfsW7d5JzCEc4gcwEFq6Mpuzm/smwIHZYqVfs /YZZEutbWIt8UB58LPytTXMbeITHp/RiWBFVsoiJJ9rjqLLQ73jAQCnxGhoYXgPUBENa +vgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3-20020a170902e94300b0016b95376f4dsi5094259pll.243.2022.06.29.09.45.52; Wed, 29 Jun 2022 09:46:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229862AbiF2QhI (ORCPT + 99 others); Wed, 29 Jun 2022 12:37:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbiF2QhG (ORCPT ); Wed, 29 Jun 2022 12:37:06 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02C4031237; Wed, 29 Jun 2022 09:37:06 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 5B0DE68AA6; Wed, 29 Jun 2022 18:37:01 +0200 (CEST) Date: Wed, 29 Jun 2022 18:37:01 +0200 From: Christoph Hellwig To: "Paul E. McKenney" Cc: Christoph Hellwig , "Jason A. Donenfeld" , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Suren Baghdasaryan , Theodore Ts'o , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Alex Xu (Hello71)" , Paolo Abeni , Rob Herring , Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Shuah Khan , linux-kernel@vger.kernel.org, wireguard@lists.zx2c4.com, netdev@vger.kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] remove CONFIG_ANDROID Message-ID: <20220629163701.GA25519@lst.de> References: <20220629150102.1582425-1-hch@lst.de> <20220629150102.1582425-2-hch@lst.de> <20220629161020.GA24891@lst.de> <20220629161527.GA24978@lst.de> <20220629163444.GG1790663@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220629163444.GG1790663@paulmck-ThinkPad-P17-Gen-1> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 29, 2022 at 09:34:44AM -0700, Paul E. McKenney wrote: > So you are OK if your patch is accepted, and then CONFIG_ANDROID is > re-introduced but used only for building kernels intended to run on > Android systems? I don't think that is a good config. In general you want APIs to express behavior, and in that case that is goes to sleep and wakes all the time. So we need go figure out what causes this in Android systems - I don't think it can be the hardware, so it must be a policy set somewhere either in the kernel or fed into the kernel by userspace. Then we can key it off that, and I suspect it is probably going to be a runtime variable and not a config option.