Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9c71f751-2f5e-4d1f-5f94-942cf7ad6a8a@linaro.org>
Date:   Wed, 29 Jun 2022 17:10:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2] ASoC: codecs: wsa883x: add control, dapm widgets and
 map
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>
Cc:     alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
        tiwai@suse.com, linux-kernel@vger.kernel.org
References: <20220629145831.77868-1-srinivas.kandagatla@linaro.org>
 <YrxpgF2B5W7fyYVy@sirena.org.uk>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <YrxpgF2B5W7fyYVy@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 29/06/2022 16:02, Mark Brown wrote:
> On Wed, Jun 29, 2022 at 03:58:31PM +0100, Srinivas Kandagatla wrote:
> 
>> +static const char * const wsa_dev_mode_text[] = {
>> +	"speaker", "receiver", "ultrasound"
> 
> Idiomatically these would be capitalised ("Speaker" and so on).  Sorry,
> didn't notice on v1.  Otherwise this looks good.
Make sense, Will send v3.

--srini