Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Jun 2022 19:13:06 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Felix Schlepper <f3sch.git@outlook.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, wjsota@gmail.com
Subject: Re: [PATCH 3/7] Staging: rtl8192e: Avoid multiple assignments
Message-ID: <20220629071241.GW16517@kadam>
References: <cover.1656402464.git.f3sch.git@outlook.com>
 <046bce9ab52db0c5a37430fbb138870c05a48f61.1656402464.git.f3sch.git@outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <046bce9ab52db0c5a37430fbb138870c05a48f61.1656402464.git.f3sch.git@outlook.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MP514HCnLGAC5BlduWebF3sEbCF/qpGIN9fW/sVGstaH5BOfJ+Cwnm8zWBq8?=
 =?us-ascii?Q?1JyGoohMPkrcIXhUQWnoD7rLdpJa/4PCT8Qwa2tvFSG8fb91CwTYBsgT2e4u?=
 =?us-ascii?Q?DL2Jjg+uhp0mpUOqpmj9ZKc5MwVx0voYtYE2GBzz7vXESYnR3XVhYwEeWlHe?=
 =?us-ascii?Q?Y8d17XxtITOqdtsGeKQOzkFAczo7oBZxKn4AQONL2YbfUFWEiszU0omPIpAj?=
 =?us-ascii?Q?zp1byf3z4HUKDRLXg6TVDGZGZnMksqVIpNp5pN+JhOaWIl6XYTromAbMoTL8?=
 =?us-ascii?Q?TPmmg9tALXsdW8U3ZlccHzi2kuR2BI4K75h4nSJRtvw4Wd/VT4YYpUipn3MZ?=
 =?us-ascii?Q?iW6CthIw+MnlLIK6rqs0/p9dB0hc6C6NErX27s5J9vjpfN/TfkxjZweDZtDm?=
 =?us-ascii?Q?BTCZUgdoHCdaw1WQHGCDwr8DErOYxYWbn+zQZ0JXFFXBUd6BnXfnWSLxURHk?=
 =?us-ascii?Q?xWh22B4Mmz63Qu7awrFBEC1x5rdoX2bFQ1w6aZbR0yL0rhxiGq6XUDRlo8wB?=
 =?us-ascii?Q?SGLUntfRoK2S4yY7ngOpnLOnfOD3ITZUiuJ+g2rik4qWshPuz75gjZm7njGF?=
 =?us-ascii?Q?iGcfCmK77JER6vgK1kWRlVsq3uAvRRP5bobpYOZe0maF8/pfyJhWJtT7rX8h?=
 =?us-ascii?Q?5B4ujScCkN/n+mRpTOMG3JgYNsezZyRn01QYmTk7F8bV6s5t0wYYtWYFqehr?=
 =?us-ascii?Q?A8GBOarjVjMI9sxFJ59/vpC4Pd/L+cL6w+N5X89HKC+j8MHktut+T8j6Jzvq?=
 =?us-ascii?Q?m9gd68Y1M7kaIQ8W8VO+7RByDlLl/lVr0vIw9wUZ7wcF7zn+umYbi1stCyyG?=
 =?us-ascii?Q?CDBUTlN8xj6KU1V80/FJdn34EOFqMMzlFKrJpTjkcdXOriKHWmQhWVKIElJ4?=
 =?us-ascii?Q?7EpOPxepY5DQJs+BGR79B5IVDcYz2iXto+NrjTrjSYFjIqq4J0ZCZzvndN3P?=
 =?us-ascii?Q?wmMchRwzu1oopogydGayOfsP4HuUpRr31zIjppus4FhO0Ryqir5md/zaMw9f?=
 =?us-ascii?Q?piu8OzeJhgtWrJOvNPX1dEglQht7s595tOQdwqjXZQwF6YdC6KgYWm+IMHpJ?=
 =?us-ascii?Q?4MMdUStSkwmbj+XS8fp6oOWbKSBBwgUhzgpMDaR0krvkgdYKK/MpdKwza4aF?=
 =?us-ascii?Q?CpCMzdMjl0YBTvh43jPLwOlSX6P15+lWHyZlekbpN1PZF5WfdoNaAu+dRCAO?=
 =?us-ascii?Q?DJQbxJure5nflskRqoqJCsI9vqaHNW6NMdM2nUiuxXDEC2aGIEHFzG01mOm8?=
 =?us-ascii?Q?6cNB02m2SGzhmTy6wv1fJRecFN+Fxhj6R4Mkvldr7WArC9Z3ZOrdEaJV8HyP?=
 =?us-ascii?Q?O9Ol795GzNyfmdRbU7Y9HYWXjufcm3U18TcQmS1fAsIArSKMgfk3KuTCTfVt?=
 =?us-ascii?Q?o47RaQ+N1S/5fBM++GGKpFk8gNxw66RYY1tu95IrRDyE8GvlA/7QzQrax7NU?=
 =?us-ascii?Q?VURTFb/XmWnax9xd85HXcuUEFsxpdxbspUjnmKoh0owTUzsOnMQFlDAYKL1T?=
 =?us-ascii?Q?NSX6o60yaH+sWf2H2VBrMqjCrj0OKgAKr0WqdutZrkr/vgYkWfRiThpkIe1M?=
 =?us-ascii?Q?6Qb13AUVr1kV7shEQaYZ+C84vdG+xJAPNoRTlmmH6VJNNt6LGoAhD73y9L+k?=
 =?us-ascii?Q?zA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19c128f4-c858-4359-41d0-08da59ea48ed
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2022 16:13:21.2698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BaHWBbnhDJcZp/eTL6UxS+Cd7qgTJN1MCBITnhi1ZQqIGEaZygmg6wfEB7tn8lSfM+CuFOSgS17urVy5r1dS1FFmQz2ajwvv6vfdj8Hjaqw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1342
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-29_17:2022-06-28,2022-06-29 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=955 suspectscore=0
 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206290058
X-Proofpoint-ORIG-GUID: QOIpCblMvgGQBfx927nB61z7ZNr3uc-V
X-Proofpoint-GUID: QOIpCblMvgGQBfx927nB61z7ZNr3uc-V
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 28, 2022 at 10:30:52AM +0200, Felix Schlepper wrote:
> This addresses an issue raised by checkpatch.pl:
> 
>      $ ./scripts/checkpatch.pl --terse -f drivers/staging/rtl8192e/rtllib_wx.c
>      CHECK: multiple assignments should be avoided
> 
> This patch does not change the logical of the assignments.
> 
> Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
> ---
>  drivers/staging/rtl8192e/rtllib_wx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> index 7bd1e829ff7e..c8fc66113b41 100644
> --- a/drivers/staging/rtl8192e/rtllib_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_wx.c
> @@ -160,7 +160,8 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee,
>  			max_rate = rate;
>  	}
>  	iwe.cmd = SIOCGIWRATE;
> -	iwe.u.bitrate.fixed = iwe.u.bitrate.disabled = 0;
> +	iwe.u.bitrate.disabled = 0;
> +	iwe.u.bitrate.fixed = iwe.u.bitrate.disabled;
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This assignment makes no sense.  Why are we setting fixed = disabled?
If you're going to split it apart do:

	iwe.u.bitrate.disabled = 0;
	iwe.u.bitrate.fixed = 0;

regards,
dan carpenter