Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Jun 2022 09:53:32 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Li, Ming" <ming4.li@intel.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Lukas Wunner <lukas@wunner.de>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Dave Jiang" <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V12 3/9] PCI: Create PCIe library functions in support of
 DOE mailboxes.
Message-ID: <YryDjAO00R6sJy1d@iweiny-desk3>
References: <20220628041527.742333-1-ira.weiny@intel.com>
 <20220628041527.742333-4-ira.weiny@intel.com>
 <20220628151626.00001c0f@Huawei.com>
 <YrtGcNWcmzumj2gA@iweiny-desk3>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YrtGcNWcmzumj2gA@iweiny-desk3>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o4ZLgLsUwPPkGC6mDwVu1e3/WqDOYX5aFfE4g62zFuPSVnlbK2qVzAYn+cmZ?=
 =?us-ascii?Q?OldxCGZj46X7uhl+MSYiWUjEIXZrhS4k+etLtTOEJX5nbqVOgRR/yYBcAtTe?=
 =?us-ascii?Q?fZjIVf4xO7qQDLPrOTS91nQ9U1O97u1ieaIH3Jy6qzxVFHirS2Al92JX1pVw?=
 =?us-ascii?Q?sIsHa+obwGBiLQy/BqEcneCGdphJnju/n8rm0KkeRIVl9OA/Ftsm3QKPSLmE?=
 =?us-ascii?Q?VuUU7THzQMS28Y/yrDVKd85Dtl5w63qa5wt/7Uw4MdVS3/ily2Vhwi2yZ8oQ?=
 =?us-ascii?Q?sYS09b/lUGfHREQ7f7JW3MdB0I2LQQ/urfmY4EBrpV7QsulR/KJUKvvOD0OJ?=
 =?us-ascii?Q?n/ulolKT8Pv9Urhmg88dkGAxBbS8lN8BoSEtsDfMcHTR8v8yuG32+HL+VrWy?=
 =?us-ascii?Q?QWg8p8tXkVk1mwFwSW2PMcWX2Qw4A1gmvz4pWSWvyGY+F5CvhvTayBsRnWhy?=
 =?us-ascii?Q?reMCD5vQ0tfO2TSlhAKlArOU5W+x4SIrVFrnY/iENZUNh1ui8xfeRwjpBdeA?=
 =?us-ascii?Q?S12ItKiRrcroArmrIkRykaVrG1b+8PYHzFvHptClHGtzNu2i4/28EW4Z74eE?=
 =?us-ascii?Q?ialC65pV6j6vTSc3Gfzj4E5ovie8pMqYqO5Za3YDfDtTNkivGPs9udH/V9dt?=
 =?us-ascii?Q?5i+xg97RfOKv0CJlSiYEfKzyjU1cGWG8Q/evlD3tnC/vbDvQtH/JBXWcP0cB?=
 =?us-ascii?Q?X/M01WglLZ6PJdM7wbxxk8ViPMpZDOL4gX6psFntwqPJ2KbtUeqKflf21dgk?=
 =?us-ascii?Q?1/Kj6jEO/7eMKkfH/bs+yER4QyjqLDleXeRo52rBAKzonWa+U/ZO3efnh6w8?=
 =?us-ascii?Q?F6q53aMXpjzimRfooEy1KaURgM0qGsca0zAoiyxFt5DHPqnfOZRi4wMMl60J?=
 =?us-ascii?Q?gSsygIbysPJz0AWPJ/JkHpkw8WVpayqnAUvdg49zMFg0Fna06MyJtziOURMv?=
 =?us-ascii?Q?6MjSodfk0V8um3xxDu3TQqG7lSeVYigeG8q8CPh602jyMvb01hokx40XEaAE?=
 =?us-ascii?Q?4xO8nW0c/GoqlrY7Ph7MIYyrq3JmjBU0sl7chsXSLmuiYSMJ6lZy+TRjvUhK?=
 =?us-ascii?Q?lizW+dAM0VSqxwiy5QUuu4+SiaQxqbuY8SYmFXr+kC03kIksnKaGHerGvvyW?=
 =?us-ascii?Q?UUvTCE3iuJlTiCJPnsToaIljP2dt/FAK5BUzPsZCmWxjEiehmiuwqX/zE9L7?=
 =?us-ascii?Q?/gImqme0NDdql7t0F1S5d59YVXBMMef/jb/MArFi5oVe0Oz3Zdi36iqpY1Yk?=
 =?us-ascii?Q?YuuBI3dTX2ioHvv2riQP5wa0jhVJh8gOOIq/s3oRjIn99zuBTsmL7+Rtvl/M?=
 =?us-ascii?Q?yRz7OAha3cWIE2RTSUQRgiO6FG/RYgZ0T2dLMPvTNHJARsxlhHkLmziUj8CV?=
 =?us-ascii?Q?HEmjBKTDgA4uNsvTCAhkkbuy/DJh+WGYKnnAccTrtS4hrQsTk0OioyPXe1xg?=
 =?us-ascii?Q?gb9yhGPTOM7jI37NIdIYbjsqE/Z+Y31jl8HPqXVAMusvyzZ4ReWFRPsZTEog?=
 =?us-ascii?Q?jnQIxTWwyuMFKLuujJPBMpKDlaDv1DlUUGmEihiqaAvh/AltDriteFcop5Ho?=
 =?us-ascii?Q?UR1fDwd3gVVWDQcaKD/ORmLJxjHIMvAvR21+Q0fSnSH4o/Ah060sTSrtdgsF?=
 =?us-ascii?Q?5S5AMJnWH4J2ZQrpGqd2VFaFyu707yq6eNPYSksFUNft?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bd14edf-daa9-4081-df98-08da59efec87
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2022 16:53:42.8292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: skOlawNnwQAnWjLUJSWTMk0AjsdfvZoJ9yLz0GGn7ovHEwYBxJ+2FrqAuUiiyt5K88CMTB/9cMAG05gaLxwDyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6443
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 28, 2022 at 11:20:32AM -0700, Ira wrote:
> On Tue, Jun 28, 2022 at 03:16:26PM +0100, Jonathan Cameron wrote:
> > On Mon, 27 Jun 2022 21:15:21 -0700
> > ira.weiny@intel.com wrote:
> > 

[snip]

> > 
> > > +static void pci_doe_free_mb(struct pci_doe_mb *doe_mb)
> > > +{
> > > +	if (doe_mb->work_queue)
> > 
> > I'm not a great fan of free functions that check a bunch of conditions
> > because they may be called before things are set up.
> 
> I'll see what I can do.  I do kind of like this but I think it gets muddled and
> I'm not dead set on either way.

I've completely reworked pci_doe_create_mb() to use devm throughout.

It is much cleaner.  Thanks Jonathan!
Ira