Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220627025744.106527-1-irogers@google.com> <6f9649d7-8129-57cf-8ab5-03abacd9cb6e@huawei.com>
In-Reply-To: <6f9649d7-8129-57cf-8ab5-03abacd9cb6e@huawei.com>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 29 Jun 2022 09:47:21 -0700
Message-ID: <CAP-5=fVxc7H75mb=j23gTD-eMYD3vru5U9QFGQDmODb57aykPA@mail.gmail.com>
Subject: Re: [PATCH v6 0/4] Rewrite jevents program in python
To:     John Garry <john.garry@huawei.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Kan Liang <kan.liang@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Zhengjun Xing <zhengjun.xing@linux.intel.com>,
        Felix Fietkau <nbd@nbd.name>, Qi Liu <liuqi115@huawei.com>,
        Like Xu <likexu@tencent.com>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org,
        Nick Forrington <nick.forrington@arm.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        James Clark <james.clark@arm.com>,
        Andrew Kilroy <andrew.kilroy@arm.com>,
        "Paul A . Clarke" <pc@us.ibm.com>, Will Deacon <will@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        ananth.narayan@amd.com, ravi.bangoria@amd.com,
        santosh.shukla@amd.com, sandipan.das@amd.com,
        Caleb Biggers <caleb.biggers@intel.com>,
        Perry Taylor <perry.taylor@intel.com>,
        Kshipra Bopardikar <kshipra.bopardikar@intel.com>,
        Stephane Eranian <eranian@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jun 27, 2022 at 10:27 AM John Garry <john.garry@huawei.com> wrote:
>
> On 27/06/2022 03:57, Ian Rogers wrote:
> > A challenge with this code is in avoiding regressions. For this reason
> > the jevents.py produces identical output to jevents.c, validated with a
> > test script and build target.
> >
> > v6. Adds Tested-by from Zhengjun Xing<zhengjun.xing@linux.intel.com>
> >      and Thomas Richter<tmricht@linux.ibm.com>. Fixes issues spotted
> >      by Jiri Olsa<jolsa@kernel.org>, jsmn.c wasn't deleted and the
> >      empty pmu-events.c didn't pass the pmu-events test. It also adds a
> >      missing mkdir which is necessary before creating pmu-events.c and
> >      tweaks the quiet display code in the empty case to display a gen.
> > v5. Adds a 2>/dev/null as suggested by David Laight
>
>
> Hmmm... shouldn't this be v7? Anyway what I got with message-id
> 20220627025744.106527-1-irogers@google.com now seems to build and the
> output looks ok.
>
> Thanks,
> John

Thanks John, I think I've confused myself by working on greater than 1
machine wrt version numbers. I can re-send as v7, would it be okay to
put on a Tested-by: John Garry <john.garry@huawei.com> ?

Ian