Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Jun 2022 18:47:46 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Chen Zhongjin <chenzhongjin@huawei.com>
Cc:     linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org,
        live-patching@vger.kernel.org, jpoimboe@kernel.org,
        peterz@infradead.org, catalin.marinas@arm.com, will@kernel.org,
        masahiroy@kernel.org, michal.lkml@markovi.net,
        ndesaulniers@google.com, mark.rutland@arm.com,
        pasha.tatashin@soleen.com, rmk+kernel@armlinux.org.uk,
        madvenka@linux.microsoft.com, christophe.leroy@csgroup.eu,
        daniel.thompson@linaro.org
Subject: Re: [PATCH v6 18/33] arm64: Change symbol type annotations
Message-ID: <YryQQlQga2wtWqv9@sirena.org.uk>
References: <20220623014917.199563-1-chenzhongjin@huawei.com>
 <20220623014917.199563-19-chenzhongjin@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ZpDaJFJQME505rUf"
Content-Disposition: inline
In-Reply-To: <20220623014917.199563-19-chenzhongjin@huawei.com>
Precedence: bulk


--ZpDaJFJQME505rUf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 23, 2022 at 09:49:02AM +0800, Chen Zhongjin wrote:
> Code symbols not following the aarch64 procedure call convention should
> be annotated with SYM_CODE_* instead of SYM_FUNC_*
>=20
> Mark relevant symbols as generic code symbols.

> -SYM_CODE_START(tramp_exit_native)
> +SYM_CODE_START_LOCAL(tramp_exit_native)
>  	tramp_exit
>  SYM_CODE_END(tramp_exit_native)
> =20
> -SYM_CODE_START(tramp_exit_compat)
> +SYM_CODE_START_LOCAL(tramp_exit_compat)

The commit log says this is fixing things mistakenly lablelld SYM_FUNC
but this bit of the actual change is making some symbols local.

> -SYM_FUNC_START_LOCAL(__create_page_tables)
> +SYM_CODE_START_LOCAL(__create_page_tables)
>  	mov	x28, lr
> =20
>  	/*
> @@ -389,7 +389,7 @@ SYM_FUNC_START_LOCAL(__create_page_tables)
>  	bl	dcache_inval_poc
> =20
>  	ret	x28
> -SYM_FUNC_END(__create_page_tables)
> +SYM_CODE_END(__create_page_tables)

This is removed by Ard's recent refactoring, the others that are still
present look valid enough (for things that don't use the stack IIRC they
could be seen as conforming but equally this is all running in non
standard environments).

--ZpDaJFJQME505rUf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmK8kEEACgkQJNaLcl1U
h9AGMAf+JHAAJDfJo61ZFJglFeCtkipmbBLs8jW0KplnUBrU3Imx5m43AH8w8mWn
xbpZ5FoAVoIGkkpMrsi3V+FZ0CPLdoTWO+bsq9Un1N3VwjzjSSRjd8iuaMa0dEQ4
sqhM4VH9ZVYIDbt4RVw0z5dcwPNgIEO157D2sGMcPTG0shsbzHXnZtLgZ6Sr/EE1
35Y4kRTYprFpjfc0b7fPQKSaJ7HpqrjOSiaFLlD24EKKueEotB03suT67wVaGYOs
XVkFGA+XYW5l1FN+SDzobyVBQo+li/aLFgKbnjt4TSYmP3fEmqQ0FWaNpNncxqps
PZ7yT8RtfHUN8Qv5eNYa7G+v+O5Wkw==
=mASi
-----END PGP SIGNATURE-----

--ZpDaJFJQME505rUf--