Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Jun 2022 14:03:56 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     James Houghton <jthoughton@google.com>,
        Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Jue Wang <juew@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 04/26] hugetlb: make huge_pte_lockptr take an
 explicit shift argument.
Message-ID: <Yry+PPHSat2uN+aG@monkey>
References: <20220624173656.2033256-1-jthoughton@google.com>
 <20220624173656.2033256-5-jthoughton@google.com>
 <YroYaWVvNZJvtqsH@monkey>
 <Yrvsn66c+UI8ZQlO@FVFYT0MHHV2J.usts.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yrvsn66c+UI8ZQlO@FVFYT0MHHV2J.usts.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XG+nxsrRbawz+bEOzZwumModWwIQI4s+Cjz0wnpWTYH/kYJ+02dHyk6Ol4Ru?=
 =?us-ascii?Q?vxmqb7LvXUrQm+mspZNIY5khhmIaTY02mFtP3RrwEDXxCVD6w1RP4RUgd02o?=
 =?us-ascii?Q?No1k0FruXNb9u5LIweTa/EHk6NsvJ1zmgplQ88FnwkwbRVPAecKtoNGsEnl8?=
 =?us-ascii?Q?kSfupvh2VKOIXWKtaJgNg65MKxulVA27zB3ZzrbRNPZluN+vmrItA5Q3fI9D?=
 =?us-ascii?Q?JquV9j/o+w+eleM7bAM36zkDAFuIE3D93NYvG+PG8B+GV6eF/K0kBtZK1QXl?=
 =?us-ascii?Q?ZGmnbVADCS8+nSl+meWwsFJItARrxb7K/BLvqiTF4HDK+ivcveU8lTftWCYW?=
 =?us-ascii?Q?GooMcrvXq4dfYdI/KnvNudFFEY98W1kLFwSuz6flgzHtCU/a4L7FLnK9MaDA?=
 =?us-ascii?Q?QSkcyHPZDAuig67N+FnVtooa+sYBJ/rS2f8xm3+fMv9OAu/U3W0lQV+vv6r5?=
 =?us-ascii?Q?RB0ym5ZJOZBCXp+zB7SwC7SSeZWYYrPsrFactL04XVVP+KmbgT+9MrOqbe2S?=
 =?us-ascii?Q?pQOQqOU2hFKSvKWJmf8NzbumntDB5fdUlEPzLyWZVJjSYtNycjOOV/eemZHq?=
 =?us-ascii?Q?U08ihWaqd0NXSmk9sw4AMvigaqx+EjPOhCFpLaN8OUzWd9hRLBsitWLWBmjc?=
 =?us-ascii?Q?P9tl4980YJZsuT0efKKHrtm9isYXjFzULidAsSFMiTPuOz66dw+nshz+Qgfp?=
 =?us-ascii?Q?9kWeKiLWU6x/L60yGJsBr2EauAGXob4XaZr7E5nIhrDonfCe+EOLLd8DPwZE?=
 =?us-ascii?Q?Gu3trDXX4/rLOzIqdLSsEecbPSxT6/VqCqvfrUNsXewXrI8oxZXOihYKx++H?=
 =?us-ascii?Q?yd9MvKuQX84vgVgOKqGvRCZ/Cjl6WJwoYgTwfcquELAz+XmKBI/YyX04tayp?=
 =?us-ascii?Q?n6DoOBjLEq03HEfrc0QyM9g6Pme0VRtDtg47MSEObNiq47LRLW+B/epSkLvf?=
 =?us-ascii?Q?y0P/xNayE55h6Nwadc/fSiZu0g6WrMhFbixUnG80CU80iuqgIVxBnKw+g0uH?=
 =?us-ascii?Q?rNaf4tNZvcBx1SRPwOP31LBt/qKx8j2vwAKhm/BZav5ObsUuNCdwmeJuHxP4?=
 =?us-ascii?Q?ed2yxNthNE+4alMeqsixmmM7pSJxyMmO8g1A1syixXNGwmldEbO7FQ6PaWLd?=
 =?us-ascii?Q?nOWe95WvU/A72qgwT5dHxjsli2N+1TNxVdzGCYuvCXnRlENRRcsWPT2I8sqB?=
 =?us-ascii?Q?JUDjIr4XL3rl9dempsqtCoE2Q/q90vQBVTdT8FzxuPT8f0wEqsZaTGdrmSfI?=
 =?us-ascii?Q?2J233D8BRG3/iwWiEjZQuqjdiEAXCVxkeavYKJ9P3I/9mUe9LFL8tIbNxyIi?=
 =?us-ascii?Q?EdTSxHHxFl5RantlZ0WE0ceon+M5dxxy4id50dcBRE2FQpSCwB6hZchdhl7h?=
 =?us-ascii?Q?QiqibUYVR14jqFJtXeugxCQDTAW3ylZ5dZiYrhaeTPkZ7yZMlMCLwjEOOk9m?=
 =?us-ascii?Q?1++ZPN/+WKZ1yShT7fadYh2SBydeCDocnI09d8NqXfmF9Ti+MqT2l7eTDixE?=
 =?us-ascii?Q?yaCaAzplFEKEyfs9N3qWU/uvpok1/CR2dFpZdxiO4U92qjlAWugHf/1GAg1Q?=
 =?us-ascii?Q?O5cd1nb/AkWFcozgWuacLYaUMl/MHoRadM1bO/U9W69PIfWjUNDFCsNVnlHD?=
 =?us-ascii?Q?eQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6be1248-d6d8-45cb-5fa5-08da5a12e30d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2022 21:03:59.3280
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TL3YYpJHkZ8Qy9XrKyr3hglPzpFdr7eRyyaA/GwBOsvRdx2EzaOJnhQvT0ZbqdJHvFG5rSsA9Gw0KPGOvx6/6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3236
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-29_22:2022-06-28,2022-06-29 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=824 suspectscore=0
 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206290072
X-Proofpoint-GUID: uRFBuCnnTgJB672AYIzeN8PGWKlc8Q9C
X-Proofpoint-ORIG-GUID: uRFBuCnnTgJB672AYIzeN8PGWKlc8Q9C
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/29/22 14:09, Muchun Song wrote:
> On Mon, Jun 27, 2022 at 01:51:53PM -0700, Mike Kravetz wrote:
> > On 06/24/22 17:36, James Houghton wrote:
> > > This is needed to handle PTL locking with high-granularity mapping. We
> > > won't always be using the PMD-level PTL even if we're using the 2M
> > > hugepage hstate. It's possible that we're dealing with 4K PTEs, in which
> > > case, we need to lock the PTL for the 4K PTE.
> > 
> > I'm not really sure why this would be required.
> > Why not use the PMD level lock for 4K PTEs?  Seems that would scale better
> > with less contention than using the more coarse mm lock.  
> >
> 
> Your words make me thing of another question unrelated to this patch.
> We __know__ that arm64 supports continues PTE HugeTLB. huge_pte_lockptr()
> did not consider this case, in this case, those HugeTLB pages are contended
> with mm lock. Seems we should optimize this case. Something like:
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 0d790fa3f297..68a1e071bfc0 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -893,7 +893,7 @@ static inline gfp_t htlb_modify_alloc_mask(struct hstate *h, gfp_t gfp_mask)
>  static inline spinlock_t *huge_pte_lockptr(struct hstate *h,
>                                            struct mm_struct *mm, pte_t *pte)
>  {
> -       if (huge_page_size(h) == PMD_SIZE)
> +       if (huge_page_size(h) <= PMD_SIZE)
>                 return pmd_lockptr(mm, (pmd_t *) pte);
>         VM_BUG_ON(huge_page_size(h) == PAGE_SIZE);
>         return &mm->page_table_lock;
> 
> I did not check if elsewhere needs to be changed as well. Just a primary
> thought.

That seems perfectly reasonable to me.

Also unrelated, but using the pmd lock is REQUIRED for pmd sharing.  The
mm lock is process specific and does not synchronize shared access.  I
found that out the hard way. :)

-- 
Mike Kravetz