Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <14b0ee4f-a12f-ccf2-633a-470be3cdfa38@roeck-us.net>
Date:   Wed, 29 Jun 2022 14:18:11 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] hwmon: (lm90) Use worker for alarm notifications
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        linux-hwmon@vger.kernel.org
Cc:     Jean Delvare <jdelvare@suse.com>, linux-kernel@vger.kernel.org
References: <20220629154210.2389765-1-linux@roeck-us.net>
 <ba43ed2c-0290-ca5b-ab4b-1f25dad9d882@collabora.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <ba43ed2c-0290-ca5b-ab4b-1f25dad9d882@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/29/22 13:02, Dmitry Osipenko wrote:
> On 6/29/22 18:42, Guenter Roeck wrote:
>> Reporting alarms using hwmon_notify_event() may result in a callback
>> from the thermal subsystem. This means that such notifications must
>> not hold the update lock to avoid a deadlock. To avoid this situation,
>> use a worker to handle notifications.
>>
>> Reported-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> Fixes: e182cf579f0f ("hwmon: (lm90) Rework alarm/status handling")
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> Dmitry,
>>
>> can you give this patch a try in your system ?
> 
> It works, thanks!
> 
> Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> 
Thanks a lot for testing!

Guenter