Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Jun 2022 02:37:49 +0300
From:   Sakari Ailus <sakari.ailus@iki.fi>
To:     Krzysztof =?utf-8?Q?Ha=C5=82asa?= <khalasa@piap.pl>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Jacopo Mondi <jacopo@jmondi.org>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Joe Perches <joe@perches.com>
Subject: Re: [PATCH v8 2/2] On Semi AR0521 sensor driver
Message-ID: <YrziTabYLlZ2bX+1@valkosipuli.retiisi.eu>
References: <m3pmn66pie.fsf@t19.piap.pl>
 <m3h78i6p4t.fsf@t19.piap.pl>
 <20220301093107.ihokyp4xptkzpbpc@uno.localdomain>
 <m38rtt7sx7.fsf@t19.piap.pl>
 <20220301143044.2l4vlwbnh5n3g5ng@uno.localdomain>
 <m37d7ufrzx.fsf@t19.piap.pl>
 <m3pmkryywn.fsf@t19.piap.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <m3pmkryywn.fsf@t19.piap.pl>
Precedence: bulk

Hi Krzysztof,

On Fri, May 06, 2022 at 08:10:16AM +0200, Krzysztof Hałasa wrote:
> Hi Mauro et al,
> 
> Mauro, you are the drivers/media maintainer. Is the AR0521 driver ready
> to be merged, are there still unresolved issues, or the driver is not no
> be merged at all? I understand everyone's so busy but a simple yes or no
> isn't too much, is it?

Apologies for the late reply.

Please run checkpatch.pl --strict --max-line-length=80 on the patch in the
future. Some of the output is often troublesome to address though. I've
applied it with these changes:

diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c
index 1cce512ff62b0..9c7a07d31ace6 100644
--- a/drivers/media/i2c/ar0521.c
+++ b/drivers/media/i2c/ar0521.c
@@ -347,8 +347,10 @@ static int ar0521_set_stream(struct ar0521_dev *sensor, bool on)
 		return ret;
 
 	} else {
-		/* Reset gain, the sensor may produce all white pixels without
-		   this */
+		/*
+		 * Reset gain, the sensor may produce all white pixels without
+		 * this
+		 */
 		ret = ar0521_write_reg(sensor, AR0521_REG_GLOBAL_GAIN, 0x2000);
 		if (ret)
 			return ret;
@@ -1056,4 +1058,4 @@ module_i2c_driver(ar0521_i2c_driver);
 
 MODULE_DESCRIPTION("AR0521 MIPI Camera subdev driver");
 MODULE_AUTHOR("Krzysztof Hałasa <khalasa@piap.pl>");
-MODULE_LICENSE("GPL v2");
+MODULE_LICENSE("GPL");

-- 
Kind regards,

Sakari Ailus