Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: 0848zM7eVcrVz3FXwyH6A/zJEqKyyKmdbmoRm+F0W6vZogU34p4WVkdG4MnlR3FtyW5nS2U17b
 4Mb6rEM7OTYZ4dIw2K+/S41eIkUPlWR/0xdvzPE3q5UzuAnFDzA/xyvXcZkxuu9VQJxsWV4W4j
 YWjps3UGlDLguQhCrm1NTcn6XqjF5VX6h68lhdXwXIVTEFPJIJW8o7PejRF3m3UK26dZJwVgj3
 MyTir6WJ1GlvGQ+n/m0nZuoKr3CKNBqRiTjw2Zp1itKboLIsr/2qg1UH5VFSO8BsX1P9J/xoSr
 XhTm89BcqyADKRk4XdoiBrvv
IronPort-SDR: YvHmEM916nhzL4pxUvcq5SdNUcdaPbIOuVTiGsO+2m8ET+D3616cEcg+NMerZndT0CbI3ekjiP
 +bCg18V142IoPDvtMiBTMQ1X5wpCb6YFj3GKAqvjvJe4KDRBVo1TyWjUmZmWbY7aiLzZ0Z9Dd5
 R63MOC9RIUmHcAcU94OqCuhQY5zqtpg+Hw8gkZHeTvssFDM8FfbLixrk4G+YaJ5AOK7eLqyPNA
 SBWZZxcf7OjqrperH7dgf0L6CFYejSCaKDHxLoE99W4iS2KUVLOF5sFAY/DvuAUNTN5Of3OCSf
 ePM=
WDCIronportException: Internal
Message-ID: <9448ff77-9b0e-95fd-1366-a5103fdb3ea0@opensource.wdc.com>
Date:   Thu, 30 Jun 2022 08:03:57 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings
Content-Language: en-US
To:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        John Garry <john.garry@huawei.com>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1656335540-50293-1-git-send-email-john.garry@huawei.com>
 <69ed5587-52fd-4171-b97f-091df8b377c6@opensource.wdc.com>
 <9caef01c-b601-c19f-10eb-720e8d7b35dc@omp.ru>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <9caef01c-b601-c19f-10eb-720e8d7b35dc@omp.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 6/29/22 22:32, Sergey Shtylyov wrote:
> On 6/29/22 4:51 AM, Damien Le Moal wrote:
>=20
>>> x86_64 allmodconfig build with W=3D1 gives these warnings:
>>>
>>> drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_piomode=E2=
=80=99:
>>> drivers/ata/pata_cs5535.c:93:11: error: variable =E2=80=98dummy=E2=80=
=99 set but not used [-Werror=3Dunused-but-set-variable]
>>>   u32 reg, dummy;
>>>            ^~~~~
>>> drivers/ata/pata_cs5535.c: In function =E2=80=98cs5535_set_dmamode=E2=
=80=99:
>>> drivers/ata/pata_cs5535.c:132:11: error: variable =E2=80=98dummy=E2=80=
=99 set but not used [-Werror=3Dunused-but-set-variable]
>>>   u32 reg, dummy;
>>>            ^~~~~
>>> cc1: all warnings being treated as errors
>>>
>>> Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is
>>> stubbed, which is the same as what we already do in pata_cs5536.c .
>>>
>>> Signed-off-by: John Garry <john.garry@huawei.com>
>>
>> Applied to for-5.20. Thanks !
>=20
>    Why not to 5.19? The warnings are fatal as can be seen from the comm=
it log...

This is only a compile warning and nobody complained, not even the 0-day
bot/linux-next builds, and for years... Most definitely not an urgent fix=
.

But yeah, sure, can do 5.19 fixes too.

>=20
> MBR, Sergey
>=20


--=20
Damien Le Moal
Western Digital Research